Closed Bug 696305 Opened 12 years ago Closed 11 years ago

Suppress all current failures in Linux Valgrind jobs

Categories

(Testing :: General, defect)

Product:
Testing
Component:
General
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jruderman, Assigned: gkw)

References

Details

Attachments

(1 obsolete file) 

Suppress all current failures in Valgrind jobs. Both our bugs (which need bug reports in Bugzilla) and bugs in system libraries.

Notes:

* Suppressions go in mozilla/build/valgrind/.

* Use "..." when you don't care about part of the stack.
** Useful when a function is inlined on one system but not on another.
** Useful when a function and its callees all use uninitialized memory.

* In rare cases, you may wish to suppress errors from an entire library, even though you have symbols for that library. --xml=yes can help here by showing the name of the library, which you can prefix with "obj:".

Once we have the current failures suppressed, we'll have something whose color we can watch :)
About a year old. Not sure how useful this is.
Blocks: 696302
Turns out V tended to report a lot of false uninitialised value errors
in 10.7 system libraries as a result of an LLVM optimisation that
fools it.  A month back I landed a "fix" that gets rid of those on OSX
only, at some expense.  So recent V builds on OSX should be a lot
quieter.  https://bugs.kde.org/show_bug.cgi?id=242137 for the whole
sorry tale.

I also updated the default suppressions file to shut it up on errors
in the OSX system libraries that showed up running Fx.
(just to clarify, suppression files are in build/valgrind in the repository, not mozilla/build/valgrind in the repository)

https://hg.mozilla.org/mozilla-central/rev/b2654d3d5c28

landed a lot of suppressions after tbpl Valgrind was upgraded to Valgrind 3.8.1.

(njn had a quick eyeball via IRC, thanks go out to khuey, njn, RyanVM, philor, Jesse, nthomas and whoever else I missed, for helping out in #developers)

Some false positives might still show up, because we have not yet enabled "--show-possibly-lost=no" as per bug 793509, and there might be more errors after the first 50MB of the log, since tbpl truncates logs to 50 MB for sanity purposes.
I've landed the patch to fix bug 793509, so we now run Valgrind with "--show-possibly-lost=no" and "--smc-check=all-non-file".

I can't watch the m-c tree so I've landed more suppressions to mozilla-inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/1d682c2055a4

So far, I've only updated the 64-bit suppression file with new suppressions due to bug 793584, and also removed the old suppressions which were circa-2010 from bug 493791.
Whiteboard: [leave open]
https://hg.mozilla.org/mozilla-central/rev/1d682c2055a4
Assignee: nobody → gary
Flags: in-testsuite-
Comment on attachment 568585 [details]
jesse's valgrind suppression file (for fuzzing)

We've constructed new Valgrind suppression files for issues that show up during tbpl runs, they are located at:

http://mxr.mozilla.org/mozilla-central/source/build/valgrind/
Attachment #568585 - Attachment is obsolete: true
As of:

https://tbpl.mozilla.org/?noignore=1&jobname=valgrind&rev=2fae8bd461da

we are all green!

Resolving FIXED since all known leaks have been suppressed.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [leave open]
You need to log in before you can comment on or make changes to this bug.