The default bug view has changed. See this FAQ.

Port |Bug 681588 - Cleanup wrap malloc and its use on Android| to comm-central

RESOLVED FIXED in Thunderbird 11.0

Status

MailNews Core
Build Config
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

Trunk
Thunderbird 11.0
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Found while working on bug 694371.

Let's resync' c-c (step by step).
Flags: in-testsuite-
(Assignee)

Updated

6 years ago
Depends on: 696455
(Assignee)

Comment 1

6 years ago
Created attachment 568895 [details] [diff] [review]
(Av1) Replace WRAP_MALLOC_* with WRAP_LDFLAGS
[Checked in: Comment 5]

Please double check whether the last configure.in block (= export + sed) is wanted or not.
Ftr,
0) in bug 605376, I had not ported the old block, as I thought it was useless as is,
1) in the current bug, I assume c-c should have the new block wrt 'mozilla',
2) then I also wonder whether some kind of support should be added to LDAP C-SDK too (in a separate bug).
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #568895 - Flags: review?(mbanner)
Comment on attachment 568895 [details] [diff] [review]
(Av1) Replace WRAP_MALLOC_* with WRAP_LDFLAGS
[Checked in: Comment 5]

Sorry, but this looks like Android-only/largely Android specific. As none of our c-c apps currently work with android, I'm not willing to spend time reviewing Android specific patches. I'd much rather have the time spent on bug 648979 which would stop the need for us for porting these bugs. You are welcome to ask other build config peers.
Attachment #568895 - Flags: review?(mbanner)
(Assignee)

Updated

5 years ago
Attachment #568895 - Flags: review?(kairo)
Attachment #568895 - Flags: review?(gozer)

Comment 3

5 years ago
Comment on attachment 568895 [details] [diff] [review]
(Av1) Replace WRAP_MALLOC_* with WRAP_LDFLAGS
[Checked in: Comment 5]

Review of attachment 568895 [details] [diff] [review]:
-----------------------------------------------------------------

I don't really care about Android, as no c-c apps build on it anyhow, but I'd rather r+ it than let anyone else lose time over it.

Other than that, I agree with Mark's comment, though.
Attachment #568895 - Flags: review?(kairo)
Attachment #568895 - Flags: review?(gozer)
Attachment #568895 - Flags: review+

Comment 4

5 years ago
Oh, and FTR, this merges bug 680373 and bug 681588 both into one patch against c-c.
(Assignee)

Comment 5

5 years ago
Comment on attachment 568895 [details] [diff] [review]
(Av1) Replace WRAP_MALLOC_* with WRAP_LDFLAGS
[Checked in: Comment 5]

http://hg.mozilla.org/comm-central/rev/410f1fa9ebc6


(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #4)
> Oh, and FTR, this merges bug 680373 and bug 681588 both into one patch
> against c-c.

I don't think so: bug 680373 is ported in bug 696455.
Attachment #568895 - Attachment description: (Av1) Replace WRAP_MALLOC_* with WRAP_LDFLAGS → (Av1) Replace WRAP_MALLOC_* with WRAP_LDFLAGS [Checked in: Comment 5]
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 11.0
(Assignee)

Comment 6

5 years ago
(In reply to Serge Gautherie (:sgautherie) from comment #5)
> 
> (In reply to Robert Kaiser (:kairo@mozilla.com) from comment #4)
> > Oh, and FTR, this merges bug 680373 and bug 681588 both into one patch
> > against c-c.
> 
> I don't think so: bug 680373 is ported in bug 696455.

Ah, I see what you mean: I agree, but I preferred to do them separately :-|
You need to log in before you can comment on or make changes to this bug.