Closed Bug 696627 Opened 8 years ago Closed 8 years ago

Re-enable incremental linking for debug builds using VC10/11

Categories

(Firefox Build System :: General, defect)

All
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla10

People

(Reporter: matjk7, Assigned: matjk7)

References

Details

Attachments

(1 file)

No description provided.
Flags: in-testsuite-
Attached patch patchSplinter Review
Attachment #568930 - Flags: review?(khuey)
Keywords: checkin-needed
In my queue, which is going via try (due to the rest of the changesets) then onto inbound:
https://tbpl.mozilla.org/?tree=Try&rev=d3d2522ed095

Thanks :-)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ba1eba586280
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
[Of course, incremental linking as always worked for debug VC8/9 x64 builds.]
I'm afraid that this fix is at least partially wrong.
Today I hit this bug building TB with VC 2010 Express.

I had to comment out
#ifeq (,$(filter-out 1400 1500,$(_MSC_VER)))
(and relevant endif, of course) to be able to compile.
(In reply to Mike Kaganski from comment #6)
> I'm afraid that this fix is at least partially wrong.
> Today I hit this bug building TB with VC 2010 Express.
> 
> I had to comment out
> #ifeq (,$(filter-out 1400 1500,$(_MSC_VER)))
> (and relevant endif, of course) to be able to compile.

Is the error the same as bug 653662? Does it happen on both opt and debug builds?
Yes, the error is the same, and I mistakingly wrote in that bug first, sorry for noise.
I only tested on debug build.
(In reply to Mike Kaganski from comment #8)
> Yes, the error is the same, and I mistakingly wrote in that bug first, sorry
> for noise.
> I only tested on debug build.

Are you using the 32 bit version of Windows? If so, http://social.msdn.microsoft.com/Forums/en-US/vcgeneral/thread/c34d5c37-ca4a-4580-9c7c-4379a8c76d1f/ might be relevant here and we should only whitelist incremental linking on 64 bit systems.
Yes, my system is WinXP Pro SP3 32-bit with 2 GB RAM.
Yeah we should only do it on 64-bit.
(In reply to Siddharth Agarwal [:sid0] from comment #11)
> Yeah we should only do it on 64-bit.

I filed bug 700959.
No longer blocks: 700959
Depends on: 700959
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.