Re-enable incremental linking for debug builds using VC10/11

RESOLVED FIXED in mozilla10

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Matheus Kerschbaum, Assigned: Matheus Kerschbaum)

Tracking

Trunk
mozilla10
All
Windows 7
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Created attachment 568930 [details] [diff] [review]
patch
Attachment #568930 - Flags: review?(khuey)
Attachment #568930 - Flags: review?(khuey) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed

Comment 2

6 years ago
In my queue, which is going via try (due to the rest of the changesets) then onto inbound:
https://tbpl.mozilla.org/?tree=Try&rev=d3d2522ed095

Thanks :-)
Keywords: checkin-needed

Comment 3

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba1eba586280
https://hg.mozilla.org/mozilla-central/rev/ba1eba586280
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 5

6 years ago
[Of course, incremental linking as always worked for debug VC8/9 x64 builds.]

Comment 6

6 years ago
I'm afraid that this fix is at least partially wrong.
Today I hit this bug building TB with VC 2010 Express.

I had to comment out
#ifeq (,$(filter-out 1400 1500,$(_MSC_VER)))
(and relevant endif, of course) to be able to compile.
(Assignee)

Comment 7

6 years ago
(In reply to Mike Kaganski from comment #6)
> I'm afraid that this fix is at least partially wrong.
> Today I hit this bug building TB with VC 2010 Express.
> 
> I had to comment out
> #ifeq (,$(filter-out 1400 1500,$(_MSC_VER)))
> (and relevant endif, of course) to be able to compile.

Is the error the same as bug 653662? Does it happen on both opt and debug builds?

Comment 8

6 years ago
Yes, the error is the same, and I mistakingly wrote in that bug first, sorry for noise.
I only tested on debug build.
(Assignee)

Comment 9

6 years ago
(In reply to Mike Kaganski from comment #8)
> Yes, the error is the same, and I mistakingly wrote in that bug first, sorry
> for noise.
> I only tested on debug build.

Are you using the 32 bit version of Windows? If so, http://social.msdn.microsoft.com/Forums/en-US/vcgeneral/thread/c34d5c37-ca4a-4580-9c7c-4379a8c76d1f/ might be relevant here and we should only whitelist incremental linking on 64 bit systems.

Comment 10

6 years ago
Yes, my system is WinXP Pro SP3 32-bit with 2 GB RAM.
Yeah we should only do it on 64-bit.
Blocks: 657571
Blocks: 700959
(In reply to Siddharth Agarwal [:sid0] from comment #11)
> Yeah we should only do it on 64-bit.

I filed bug 700959.
(Assignee)

Updated

6 years ago
No longer blocks: 700959
Depends on: 700959
You need to log in before you can comment on or make changes to this bug.