696627 - Re-enable incremental linking for debug builds using VC10/11

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Matheus Kerschbaum]

Attachment: patch

Comment 2

[Ed Morley [:emorley]]

In my queue, which is going via try (due to the rest of the changesets) then onto inbound:
https://tbpl.mozilla.org/?tree=Try&rev=d3d2522ed095

Thanks :-)

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ba1eba586280

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/ba1eba586280

Comment 5

[[e-mail]]

[Of course, incremental linking as always worked for debug VC8/9 x64 builds.]

Comment 6

[Mike Kaganski]

I'm afraid that this fix is at least partially wrong.
Today I hit this bug building TB with VC 2010 Express.

I had to comment out
#ifeq (,$(filter-out 1400 1500,$(_MSC_VER)))
(and relevant endif, of course) to be able to compile.

Comment 7

[Matheus Kerschbaum]

(In reply to Mike Kaganski from comment #6)
> I'm afraid that this fix is at least partially wrong.
> Today I hit this bug building TB with VC 2010 Express.
> 
> I had to comment out
> #ifeq (,$(filter-out 1400 1500,$(_MSC_VER)))
> (and relevant endif, of course) to be able to compile.

Is the error the same as bug 653662? Does it happen on both opt and debug builds?

Comment 8

[Mike Kaganski]

Yes, the error is the same, and I mistakingly wrote in that bug first, sorry for noise.
I only tested on debug build.

Comment 9

[Matheus Kerschbaum]

(In reply to Mike Kaganski from comment #8)
> Yes, the error is the same, and I mistakingly wrote in that bug first, sorry
> for noise.
> I only tested on debug build.

Are you using the 32 bit version of Windows? If so, http://social.msdn.microsoft.com/Forums/en-US/vcgeneral/thread/c34d5c37-ca4a-4580-9c7c-4379a8c76d1f/ might be relevant here and we should only whitelist incremental linking on 64 bit systems.

Comment 10

[Mike Kaganski]

Yes, my system is WinXP Pro SP3 32-bit with 2 GB RAM.

Comment 11

[Rain [:rain1] (inactive)]

Yeah we should only do it on 64-bit.

Comment 12

[Serge Gautherie (:sgautherie)]

(In reply to Siddharth Agarwal [:sid0] from comment #11)
> Yeah we should only do it on 64-bit.

I filed bug 700959.