Last Comment Bug 696627 - Re-enable incremental linking for debug builds using VC10/11
: Re-enable incremental linking for debug builds using VC10/11
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All Windows 7
: -- normal (vote)
: mozilla10
Assigned To: Matheus Kerschbaum
:
:
Mentors:
Depends on: 700959
Blocks: 657571
  Show dependency treegraph
 
Reported: 2011-10-23 01:59 PDT by Matheus Kerschbaum
Modified: 2011-11-12 16:17 PST (History)
8 users (show)
matjk7: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.10 KB, patch)
2011-10-23 02:02 PDT, Matheus Kerschbaum
khuey: review+
Details | Diff | Splinter Review

Description Matheus Kerschbaum 2011-10-23 01:59:44 PDT

    
Comment 1 Matheus Kerschbaum 2011-10-23 02:02:29 PDT
Created attachment 568930 [details] [diff] [review]
patch
Comment 2 Ed Morley [:emorley] 2011-10-28 03:41:12 PDT
In my queue, which is going via try (due to the rest of the changesets) then onto inbound:
https://tbpl.mozilla.org/?tree=Try&rev=d3d2522ed095

Thanks :-)
Comment 4 Matt Brubeck (:mbrubeck) 2011-10-28 12:18:29 PDT
https://hg.mozilla.org/mozilla-central/rev/ba1eba586280
Comment 5 neil@parkwaycc.co.uk 2011-10-28 16:47:25 PDT
[Of course, incremental linking as always worked for debug VC8/9 x64 builds.]
Comment 6 Mike Kaganski 2011-11-08 21:27:51 PST
I'm afraid that this fix is at least partially wrong.
Today I hit this bug building TB with VC 2010 Express.

I had to comment out
#ifeq (,$(filter-out 1400 1500,$(_MSC_VER)))
(and relevant endif, of course) to be able to compile.
Comment 7 Matheus Kerschbaum 2011-11-08 21:51:15 PST
(In reply to Mike Kaganski from comment #6)
> I'm afraid that this fix is at least partially wrong.
> Today I hit this bug building TB with VC 2010 Express.
> 
> I had to comment out
> #ifeq (,$(filter-out 1400 1500,$(_MSC_VER)))
> (and relevant endif, of course) to be able to compile.

Is the error the same as bug 653662? Does it happen on both opt and debug builds?
Comment 8 Mike Kaganski 2011-11-08 22:19:03 PST
Yes, the error is the same, and I mistakingly wrote in that bug first, sorry for noise.
I only tested on debug build.
Comment 9 Matheus Kerschbaum 2011-11-08 22:31:05 PST
(In reply to Mike Kaganski from comment #8)
> Yes, the error is the same, and I mistakingly wrote in that bug first, sorry
> for noise.
> I only tested on debug build.

Are you using the 32 bit version of Windows? If so, http://social.msdn.microsoft.com/Forums/en-US/vcgeneral/thread/c34d5c37-ca4a-4580-9c7c-4379a8c76d1f/ might be relevant here and we should only whitelist incremental linking on 64 bit systems.
Comment 10 Mike Kaganski 2011-11-08 23:35:14 PST
Yes, my system is WinXP Pro SP3 32-bit with 2 GB RAM.
Comment 11 Siddharth Agarwal [:sid0] (inactive) 2011-11-08 23:53:31 PST
Yeah we should only do it on 64-bit.
Comment 12 Serge Gautherie (:sgautherie) 2011-11-09 00:19:37 PST
(In reply to Siddharth Agarwal [:sid0] from comment #11)
> Yeah we should only do it on 64-bit.

I filed bug 700959.

Note You need to log in before you can comment on or make changes to this bug.