Enable incremental linking on 64-bit Windows, but not on 32-bit

RESOLVED FIXED in Firefox 10

Status

RESOLVED FIXED
7 years ago
a year ago

People

(Reporter: sgautherie, Assigned: sid0)

Tracking

({regression})

Trunk
mozilla11
x86
Windows Server 2003
regression
Dependency tree / graph

Firefox Tracking Flags

(firefox10 fixed)

Details

(Whiteboard: fixed-in-bs [qa-])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
Per bug 653662 and bug 696627 discussions.
(Reporter)

Comment 1

7 years ago
Fwiw:

(In reply to neil@parkwaycc.co.uk from bug 653662 comment #24)
> What's actually tipping the ilk over the limit? MOZ_DEBUG is a sledgehammer,
> so if you do subsequently tweak the condition you might want to consider
> conditioning on MOZ_DEBUG_SYMBOLS or MOZ_OPTIMIZE instead as appropriate.
Created attachment 573156 [details] [diff] [review]
patch

http://social.msdn.microsoft.com/Forums/en-US/vcgeneral/thread/c34d5c37-ca4a-4580-9c7c-4379a8c76d1f/ indicates that enabling it should be fine on VC9/64 too.
Assignee: nobody → sagarwal
Status: NEW → ASSIGNED
Attachment #573156 - Flags: review?(ted.mielczarek)
Created attachment 573163 [details] [diff] [review]
better patch
[Checked in: Comment 10 & 11]
Attachment #573156 - Attachment is obsolete: true
Attachment #573156 - Flags: review?(ted.mielczarek)
Attachment #573163 - Flags: review?(ted.mielczarek)
Comment on attachment 573163 [details] [diff] [review]
better patch
[Checked in: Comment 10 & 11]

Review of attachment 573163 [details] [diff] [review]:
-----------------------------------------------------------------

Ugh. GNU Make makes me sad. :-(
Attachment #573163 - Flags: review?(ted.mielczarek) → review+
Can we take this patch on Aurora? Otherwise some supported build setups won't work for some people in fx10.
Blocks: 696627
No longer depends on: 696627
Keywords: regression
(Reporter)

Updated

7 years ago
Attachment #573163 - Flags: approval-mozilla-aurora?
If this needs to land in Aurora urgently could someone else land it please? I'm on mobile internet until Monday and don't have a fresh Aurora checkout.
Oh, and this should be low risk enough because it doesn't affect any tinderbox builds.

Updated

7 years ago
Attachment #573163 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/a7b08c15904b
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Reporter)

Updated

7 years ago
Attachment #573163 - Attachment description: better patch → better patch [Checked in: Comment 11]
(Reporter)

Updated

7 years ago
Flags: in-testsuite-
Whiteboard: fixed-in-bs → [ToDo: check in to m-a] [fixed-in-bs]
(Reporter)

Updated

7 years ago
Attachment #573163 - Attachment description: better patch [Checked in: Comment 11] → better patch [Checked in: Comment 10 & 11]
(Reporter)

Updated

7 years ago
Whiteboard: [ToDo: check in to m-a] [fixed-in-bs] → fixed-in-bs
(Reporter)

Updated

7 years ago
Blocks: 703852
Marking qa- as I don't think this is something QA needs to verify. Please set to qa+ if this is not the case.
Whiteboard: fixed-in-bs → fixed-in-bs [qa-]

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.