697197 - Remove UI links to TCBU

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[[:jberkus] Josh Berkus]

Laura asked me to file this bug so that everyone was aware of current status.

While we wait for resolution on bug 690462, Top Crashers By Url is NOT being updated for new products.   This is because the code to do so was never written since we don't know what we're doing with that report.

Comment 5

[Robert Helmer [:rhelmer]]

We should remove the current UI, or at least the links to the reports.

Comment 6

[Schalk Neethling [:espressive]]

[:rhelmer] Should I remove the links to report by URL, as you suggest, then?

Comment 7

[Schalk Neethling [:espressive]]

submitted pull request: https://github.com/mozilla/socorro/pull/228

TEST CASE
----------

There should be no links to top crashers by url and the link in the reports drop down should be removed as well.

Comment 8

[Schalk Neethling [:espressive]]

because the access points to tcbu's is being removed by this bug, there are some tests such as _verify_current_version_selected_in_top_crashers_by_url_header that are now going to fail.

Just pointing this out so QA is aware.

Comment 9

[[github robot]]

Commit pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/6eaef9ddfcfb972bae3bd7a13d5b102dfa9051c6
Merge pull request #228 from ossreleasefeed/bug697197-remove-byurl-links

removed links to top crashers by url :: fixes bug 697197

Comment 10

[Robert Helmer [:rhelmer]]

Should "links to TCBU" also include the "by domain" and "by top site" reports (I think the data comes from the same place?)

If so, these aren't removed (we don't have data for them on stage which is why I am asking). If not, please resolve and ignore!

Comment 11

[Schalk Neethling [:espressive]]

[:rhelmer] I also noticed that there was no data for these on prod yesterday irrespective of the version of Firefox I chose. I someone can confirm that the domain and top site links needs to be removed, then I will go ahead and do this.

Comment 12

[[:jberkus] Josh Berkus]

Yes, those all have the same data source and should all be removed.

Comment 13

[Schalk Neethling [:espressive]]

removing them as well

Comment 14

[Schalk Neethling [:espressive]]

sent pull request: https://github.com/mozilla/socorro/pull/246

TEST CASE
-----------

No links in drop downs or in page links should exist to reports by domain or top site.

Comment 15

[[github robot]]

Commit pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/10bf1b09200c269eb928e27ca3320aa832439665
Merge pull request #246 from ossreleasefeed/bug697197-remove-byurl-links

removed additional links to domain and top url fixes bug 697197

Comment 16

[Matt Brandt [:mbrandt]]

QA verified on stage, tcbd and tcbs are no longer in the product drop-down filter nor in the featured product links. Thanks for the steps to verify in comment 14.

Comment 17

[Matt Brandt [:mbrandt]]

Attachment: qa verified - tcbd and tcbs removed

And a screenshot to verify