Port bug 665196 (submit crash report & reload plugin in one step) and bug 688083 (sync submit crash report checkbox between instances) to Thunderbird

RESOLVED FIXED in Thunderbird 10.0

Status

Thunderbird
Mail Window Front End
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

(Depends on: 1 bug)

Trunk
Thunderbird 10.0
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird11 wontfix)

Details

Attachments

(2 attachments)

(Assignee)

Description

7 years ago
Created attachment 570226 [details] [diff] [review]
The fix

The two bugs we need to port broke our unit tests.

I've ported the changes but I suspect our unit tests may still be broken, but I can't test that on my Mac at the moment.

Mike: can you test it for me?
Attachment #570226 - Flags: review?(mconley)
Comment on attachment 570226 [details] [diff] [review]
The fix

Review of attachment 570226 [details] [diff] [review]:
-----------------------------------------------------------------

Hey Mark,

Code looks good - just a few tiny (but critical) bugs that were causing test failures on my Linux box.

I have fixed this locally, and my tests are passing - is it acceptable/good manners for me to update your patch for you?

-Mike
PS:  Still building on OSX - I'll let you know how those tests go when they're done.

::: mail/base/content/plugins.js
@@ -552,1 +574,3 @@
> >      if (doPrompt) {
> > +      let submitReportsPrefObserver = {
> > +        QueryInterface: XPCOMUtils.generateQI([Ci.nsIObserver,

At this point in the code, Ci is undefined.

@@ -585,2 +624,5 @@
> >  
> >      let link = doc.getAnonymousElementByAttribute(plugin, "class", "reloadLink");
> > +#ifdef MOZ_CRASHREPORTER
> > +    this.addLinkClickCallback(
> > +      link, "retryPluginPage", browser, plugin, pluginDumpID, BrowserDumpId);

Should be "browserDumpID"
Attachment #570226 - Flags: review?(mconley) → review-
Created attachment 570321 [details] [diff] [review]
My corrections to the patch

Here's my alterations to your patch to make the tests work properly.
Comment on attachment 570226 [details] [diff] [review]
The fix

Alright, with the changes I've provided in the other patch, this patch looks good to me.
Attachment #570226 - Flags: review- → review+
(Assignee)

Comment 4

7 years ago
Checked in: http://hg.mozilla.org/comm-central/rev/654ab89c2ab5
Assignee: nobody → mbanner
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 10.0
(Assignee)

Comment 5

7 years ago
Just a note, the core bug has been backed out of TB 11, so I've backed this out as well.
status-thunderbird11: --- → wontfix
You need to log in before you can comment on or make changes to this bug.