Closed Bug 697964 Opened 13 years ago Closed 13 years ago

Port bug 665196 (submit crash report & reload plugin in one step) and bug 688083 (sync submit crash report checkbox between instances) to Thunderbird

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set
normal

Tracking

(thunderbird11 wontfix)

RESOLVED FIXED
Thunderbird 10.0
Tracking Status
thunderbird11 --- wontfix

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(2 files)

Attached patch The fixSplinter Review
The two bugs we need to port broke our unit tests.

I've ported the changes but I suspect our unit tests may still be broken, but I can't test that on my Mac at the moment.

Mike: can you test it for me?
Attachment #570226 - Flags: review?(mconley)
Comment on attachment 570226 [details] [diff] [review]
The fix

Review of attachment 570226 [details] [diff] [review]:
-----------------------------------------------------------------

Hey Mark,

Code looks good - just a few tiny (but critical) bugs that were causing test failures on my Linux box.

I have fixed this locally, and my tests are passing - is it acceptable/good manners for me to update your patch for you?

-Mike
PS:  Still building on OSX - I'll let you know how those tests go when they're done.

::: mail/base/content/plugins.js
@@ -552,1 +574,3 @@
> >      if (doPrompt) {
> > +      let submitReportsPrefObserver = {
> > +        QueryInterface: XPCOMUtils.generateQI([Ci.nsIObserver,

At this point in the code, Ci is undefined.

@@ -585,2 +624,5 @@
> >  
> >      let link = doc.getAnonymousElementByAttribute(plugin, "class", "reloadLink");
> > +#ifdef MOZ_CRASHREPORTER
> > +    this.addLinkClickCallback(
> > +      link, "retryPluginPage", browser, plugin, pluginDumpID, BrowserDumpId);

Should be "browserDumpID"
Attachment #570226 - Flags: review?(mconley) → review-
Here's my alterations to your patch to make the tests work properly.
Comment on attachment 570226 [details] [diff] [review]
The fix

Alright, with the changes I've provided in the other patch, this patch looks good to me.
Attachment #570226 - Flags: review- → review+
Checked in: http://hg.mozilla.org/comm-central/rev/654ab89c2ab5
Assignee: nobody → mbanner
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 10.0
Depends on: 698405
Just a note, the core bug has been backed out of TB 11, so I've backed this out as well.
You need to log in before you can comment on or make changes to this bug.