698405 - Permanent Orange: TEST-UNEXPECTED-FAIL | test-plugin-crashing.js | setupModule

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

The test seems to fail out here:

TEST-START | e:\buildbot\comm-central-win32-opt-unittest-mozmill\build\mozmill\content-tabs\test-plugin-crashing.js | setupModule
Test Failure: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsICrashReporter.submitReports]
NEXT ERROR TEST-UNEXPECTED-FAIL | e:\buildbot\comm-central-win32-opt-unittest-mozmill\build\mozmill\content-tabs\test-plugin-crashing.js | setupModule
TEST-START | e:\buildbot\comm-central-win32-opt-unittest-mozmill\build\mozmill\content-tabs\test-plugin-crashing.js | test_can_crash_plugin
Test Skipped: "setupModule failed."
WARNING | test_can_crash_plugin | (SKIP) setupModule failed.
TEST-START | e:\buildbot\comm-central-win32-opt-unittest-mozmill\build\mozmill\content-tabs\test-plugin-crashing.js | test_crashed_plugin_notification_bar
Test Skipped: "setupModule failed."

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

It turns out that setting nsICrashReporter.submitReports to true on Windows results in an NS_ERROR_FAILURE.

It's also completely unnecessary for this test.

Removing this line causes the test to pass on Windows.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Thanks!  Committed as: http://hg.mozilla.org/comm-central/rev/1a22958b82ca

Comment 3

[Mike Conley (:mconley) (:⚙️)]

I'll set to RESOLVED FIXED when I see those tests all pass.  :)

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Orange seems to be gone now.

Comment 5

[Mark Banner (:standard8)]

Just a note, the core bug has been backed out of TB 11, so I've backed this out as well.