698719 - Gloda global search: Changes of subject line not updated when saving drafts, missing results and false positives (testing on unique short subject word)

Status: NEW

(Thunderbird :: Search, defect)

Description

[Thomas D. (:thomas8)]

Filed against trunk, 10.0a1 2011-10-31 (didn't check branches)

Changes of subject line words, saved into an existing draft, are not reflected correctly in Gloda searches, leading to missing results and false positives

STR

1) compose new mail (on pop 3 account, probably doesn't matter)
2) type unique short word into subject line (something you know will not occur in other messages, like "mxn", everything without quotes in this STR)
3) Save and close the draft
4) Perform gloda search for "mxn"

5) Edit draft and change subject to "mzn"
6) Save and close the draft
7) Perform gloda search for "mzn"
7b) Perform gloda search for "mxn"

Actual result

4) gloda will correctly find mail with "mxn" in subject (after first saving of draft)
7) gloda will NOT find existing saved draft with "mzn" in subject (after saving subject line changes to draft)
7b) gloda will WRONGLY find existing saved draft with "mzn" in subject, but we were searching for "mxn" (so changes of subject in saved draft have NOT been updated in gloda, we still have record of the old version)

Sample use case (showing severity of this bug):

In real life, this means e.g. when user saves a draft with subject "Business plan (draft version)", and later changes subject to "Business plan (final version)", gloda search for "final version" will find nothing, and searching for "draft version" will find "final version". Bad stuff -> major.

Additional info:

Reproducable every time (though I think I saw some inexplicable and non-reproducable exceptions). Things don't change if user changes some more subject words, or adds a lot of text in body, or restarts TB, etc. (didn't try long waiting, though). Seems to work fine for similar short word changes in body text.

Thoughts for fixing:

Since we do everything correctly when draft is saved for *1st* time, there seems to be a difference in how we handle 1st and subsequent saving. I don't think there should be. On the other hand, body changes seem to reflect correctly (no matter how little). So maybe it's something like a "message-has-changed-for-gloda" kind of flag which we don't update when user changes subject.

Comment 1

[Ludovic Hirlimann [:Usul]]

Isn't that just a dup of the bug where we don't index drafts ?

Comment 2

[Thomas D. (:thomas8)]

(In reply to Ludovic Hirlimann [:Usul] from comment #1)
> Isn't that just a dup of the bug where we don't index drafts ?

I'm not aware of that bug (pls let me know), and if it exists it doesn't seem to be listed under glodafailtracker.

Comment 3

[Ludovic Hirlimann [:Usul]]

I was thinking about 537775 - but my memory doesn't work so well theses days.

Comment 4

[Thomas D. (:thomas8)]

(In reply to Ludovic Hirlimann [:Usul] from comment #1)
> Isn't that just a dup of the bug where we don't index drafts ?

FTR: As hinted in comment 0, apart from the subject line (on subsequent saving) it seems we *do* index drafts correctly (e.g. the body text; didn't test for header).

Comment 5

[Wayne Mery (:wsmwk)]

(In reply to Ludovic Hirlimann [:Usul] from comment #3)

I was thinking about bug 537775 - but my memory doesn't work so well theses days.

Right - that was fixed in bug 545469 circa version 3.1, 9 years ago and thus before this bug was created.

Do we need to change the bug summary?

Comment 6

[Thomas D. (:thomas8)]

(In reply to Wayne Mery (:wsmwk) from comment #5)

Do we need to change the bug summary?

Don't think so. This bug has clear STR so it can be tested if it still fails. If someone tests STR and finds things are now working, I will double-check to make sure.