698917 - Be smarter about removing & from prompt labels

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P4)

Description

[Wesley Johnston (:wesj)]

When I was writing the prompt service I saw some of our common prompts included & in the button labels to designate access keys. I took a rather hasty approach and just yanked all "&" symbols from the string, but our prompt service already had a smarter regex/algroythm. 

We should keep using it to format the labels and just throw out the accesskeys for now.

Comment 1

[Wesley Johnston (:wesj)]

mfinkle pointed out on IRC, also need to catch strings at:

http://hg.mozilla.org/projects/birch/file/f853e2b1e753/mobile/components/PromptService.js#l303

Comment 4

[Wesley Johnston (:wesj)]

Attachment: Patch

Still testing this

Comment 5

[Wesley Johnston (:wesj)]

Attachment: Patch

This works here. I set http://www.maths.surrey.ac.uk/hosted-sites/R.Knott/Fibonacci/fibCalcX.html to calculate 1000 results. The checkbox label should then have its "&" removed.

I'm not removing these from Titles and Messages. Messages likely come from web content and don't expect this. I don't know that title support it either? Context menu list items might need clean up, but I think we control those fairly tightly, and we use the same code path for Select elements, which would be filled in by sites.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 586190 [details] [diff] [review]
Patch

Adding the check to getLocaleString seems safe enough from looking at how it is used. I think we need to add a call to cleanupLabel for user-supplied button strings:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/components/PromptService.js#303

Since we do it in XUL too:
http://mxr.mozilla.org/mozilla-central/source/mobile/xul/components/PromptService.js#450

r+ with that addition

Comment 7

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/af4f9dd24993

Comment 8

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/mozilla-central/rev/af4f9dd24993

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 586190 [details] [diff] [review]
Patch

[Approval Request Comment]
Needed to help avoid bad strings in the native UI dialogs. Some internal strings can cause the extra "&" but add-ons can too.

Comment 10

[LegNeato]

Comment on attachment 586190 [details] [diff] [review]
Patch

[triage comment]
Approved for aurora. Mobile bug.

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a47ce0cc4986

Comment 12

[Cristian Nicolae (:xti)]

Verified fixed on:

Mozilla/5.0 (Android;Linux armv7l;rv:11.0a2)Gecko/20120130
Firefox/11.0a2 Fennec/11.0a2
Device: Samsung Galaxy S
OS: Android 2.2

Mozilla/5.0 (Android;Linux armv7l;rv:12.0a1)Gecko/20120130
Firefox/12.0a1 Fennec/12.0a1
Device: Samsung Galaxy S
OS: Android 2.2