Be smarter about removing & from prompt labels

VERIFIED FIXED

Status

()

Firefox for Android
General
P4
normal
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: wesj, Assigned: wesj)

Tracking

unspecified
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
When I was writing the prompt service I saw some of our common prompts included & in the button labels to designate access keys. I took a rather hasty approach and just yanked all "&" symbols from the string, but our prompt service already had a smarter regex/algroythm. 

We should keep using it to format the labels and just throw out the accesskeys for now.
(Assignee)

Comment 1

6 years ago
mfinkle pointed out on IRC, also need to catch strings at:

http://hg.mozilla.org/projects/birch/file/f853e2b1e753/mobile/components/PromptService.js#l303

Updated

6 years ago
Priority: -- → P4
Assignee: nobody → mark.finkle
Assignee: mark.finkle → wjohnston
Duplicate of this bug: 699677
Duplicate of this bug: 715001
(Assignee)

Comment 4

6 years ago
Created attachment 585627 [details] [diff] [review]
Patch

Still testing this
(Assignee)

Comment 5

6 years ago
Created attachment 586190 [details] [diff] [review]
Patch

This works here. I set http://www.maths.surrey.ac.uk/hosted-sites/R.Knott/Fibonacci/fibCalcX.html to calculate 1000 results. The checkbox label should then have its "&" removed.

I'm not removing these from Titles and Messages. Messages likely come from web content and don't expect this. I don't know that title support it either? Context menu list items might need clean up, but I think we control those fairly tightly, and we use the same code path for Select elements, which would be filled in by sites.
Attachment #585627 - Attachment is obsolete: true
Attachment #586190 - Flags: review?(mark.finkle)
Comment on attachment 586190 [details] [diff] [review]
Patch

Adding the check to getLocaleString seems safe enough from looking at how it is used. I think we need to add a call to cleanupLabel for user-supplied button strings:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/components/PromptService.js#303

Since we do it in XUL too:
http://mxr.mozilla.org/mozilla-central/source/mobile/xul/components/PromptService.js#450

r+ with that addition
Attachment #586190 - Flags: review?(mark.finkle) → review+
status-firefox11: --- → affected
status-firefox12: --- → affected
(Assignee)

Comment 7

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/af4f9dd24993
Whiteboard: [inbound]
(Assignee)

Comment 8

6 years ago
https://hg.mozilla.org/mozilla-central/rev/af4f9dd24993
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Comment on attachment 586190 [details] [diff] [review]
Patch

[Approval Request Comment]
Needed to help avoid bad strings in the native UI dialogs. Some internal strings can cause the extra "&" but add-ons can too.
Attachment #586190 - Flags: approval-mozilla-aurora?

Comment 10

6 years ago
Comment on attachment 586190 [details] [diff] [review]
Patch

[triage comment]
Approved for aurora. Mobile bug.
Attachment #586190 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/a47ce0cc4986
status-firefox11: affected → fixed
status-firefox12: affected → fixed
Verified fixed on:

Mozilla/5.0 (Android;Linux armv7l;rv:11.0a2)Gecko/20120130
Firefox/11.0a2 Fennec/11.0a2
Device: Samsung Galaxy S
OS: Android 2.2

Mozilla/5.0 (Android;Linux armv7l;rv:12.0a1)Gecko/20120130
Firefox/12.0a1 Fennec/12.0a1
Device: Samsung Galaxy S
OS: Android 2.2
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.