Closed Bug 698917 Opened 12 years ago Closed 12 years ago
Be smarter about removing & from prompt labels
When I was writing the prompt service I saw some of our common prompts included & in the button labels to designate access keys. I took a rather hasty approach and just yanked all "&" symbols from the string, but our prompt service already had a smarter regex/algroythm. We should keep using it to format the labels and just throw out the accesskeys for now.
mfinkle pointed out on IRC, also need to catch strings at: http://hg.mozilla.org/projects/birch/file/f853e2b1e753/mobile/components/PromptService.js#l303
Still testing this
This works here. I set http://www.maths.surrey.ac.uk/hosted-sites/R.Knott/Fibonacci/fibCalcX.html to calculate 1000 results. The checkbox label should then have its "&" removed. I'm not removing these from Titles and Messages. Messages likely come from web content and don't expect this. I don't know that title support it either? Context menu list items might need clean up, but I think we control those fairly tightly, and we use the same code path for Select elements, which would be filled in by sites.
Comment on attachment 586190 [details] [diff] [review] Patch Adding the check to getLocaleString seems safe enough from looking at how it is used. I think we need to add a call to cleanupLabel for user-supplied button strings: http://mxr.mozilla.org/mozilla-central/source/mobile/android/components/PromptService.js#303 Since we do it in XUL too: http://mxr.mozilla.org/mozilla-central/source/mobile/xul/components/PromptService.js#450 r+ with that addition
Attachment #586190 - Flags: review?(mark.finkle) → review+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 586190 [details] [diff] [review] Patch [Approval Request Comment] Needed to help avoid bad strings in the native UI dialogs. Some internal strings can cause the extra "&" but add-ons can too.
Attachment #586190 - Flags: approval-mozilla-aurora?
Comment on attachment 586190 [details] [diff] [review] Patch [triage comment] Approved for aurora. Mobile bug.
Attachment #586190 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed on: Mozilla/5.0 (Android;Linux armv7l;rv:11.0a2)Gecko/20120130 Firefox/11.0a2 Fennec/11.0a2 Device: Samsung Galaxy S OS: Android 2.2 Mozilla/5.0 (Android;Linux armv7l;rv:12.0a1)Gecko/20120130 Firefox/12.0a1 Fennec/12.0a1 Device: Samsung Galaxy S OS: Android 2.2
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.