699537 - Create a contextcommands.js to hold our default context menu handlers

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect, P5)

Description

[Wesley Johnston (:wesj)]

In the initial context menus patch I just landed support for two commands, initialized in NativeWindow as examples/testing. We should move them somewhere more formal. mfinkle suggested creating a contextmenus.js file where we handled all/most of these. To keep this simple, probably best to start with just those two and file individual bugs (like bug 697265) for other commands?

Just for reference though, additional commands we used to support:
Copy
Copy All
Paste
Paste & Go
Select All
Bookmark Link
Copy Link
Copy Email
Copy Phone Number
Copy Image Location
Share Link
Share Media
Play
Pause
Fullscreen (video only)
Save Video
Share Video
Edit Bookmark
Remove Bookmark
Send to homescreen (for bookmarks)
Change Input Method
Save Image
Save Link (as pdf?)
View Image

Comment 5

[Wesley Johnston (:wesj)]

Attachment: mute3.5

This moves all of the context menu code out of browser.js. We still need it at startup. We could theoretically use a lazy listener that added all of the context menu items when first invoked, but we have items added at random places in browser.js that would have to be moved. And if bug 853700 (adding context menu items to the native ui) lands, we'll need it for that as well.

After trying a few ways, I decided an easy first step might be to just get this out of browser.js for now. Alternatively, we could #include this at buildtime?

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 778255 [details] [diff] [review]
mute3.5

I'd like to back burner this until bug 768667 lands. It will bitrot a lot of that patch.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 778255 [details] [diff] [review]
mute3.5

This will need unbitrotted since you landed bug 768667 and I think we want to investigate using JSM for ContextMenus.

Comment 8

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.