<a class="header-button" href="https://bugzilla.mozilla.org/home" title="Go to home page"> Bugzilla

Comment 4

•

13 years ago

(In reply to Naoki Hirata :nhirata from comment #3) > < 1 min 88.7 % 134 I add the startupcrash keyword.

Summary: Crash Report [@ pr_FindSymbolInLib ] → Crash in nsPluginFile::GetPluginInfo @ pr_FindSymbolInLib

Whiteboard: [mobile-crash],[native-crash:P4], str-needed → [mobile-crash],[native-crash:P4], str-needed, startupcrash

Naoki Hirata :nhirata (please use needinfo instead of cc)

Comment 5

•

13 years ago

I checked the devices where it happens: * PANTECH IS06 * WA CT704 * FUJITSU TOSHIBA MOBILE COMMUNICATIONS LIMITED IS04 * FUJITSU TOSHIBA MOBILE COMMUNICATIONS LIMITED ISW11F * FUJITSU TOSHIBA MOBILE COMMUNICATIONS LIMITED T-01C * Sony Ericsson LT15i * telechips MID8024 * telechips MID8127 * HTC Desire * MBX MBX DVBT reference board (c03ref) * telechips X7G * samsung GT-I9100 * renesas Livall There are no CPU or graphical controller correlations. My guess is that it's caused by an old Flash version.

Crash Signature: [@ pr_FindSymbolInLib ] [@ pr_FindSymbolInLib] → [@ pr_FindSymbolInLib]

Reporter

Comment 6

•

13 years ago

This crash is still occurring: Last crash happened yesterday : https://crash-stats.mozilla.com/report/list?product=FennecAndroid&query_search=signature&query_type=contains&query=pr_FindSymbolInLib&reason_type=contains&date=02%2F09%2F2012%2014%3A24%3A19&range_value=30&range_unit=days&hang_type=any&process_type=any&do_query=1&signature=pr_FindSymbolInLib

Naoki Hirata :nhirata (please use needinfo instead of cc)

Reporter

Updated

•

13 years ago

Keywords: topcrash

Naoki Hirata :nhirata (please use needinfo instead of cc)

Reporter

Comment 7

•

13 years ago

https://crash-stats.mozilla.com/report/index/0fa5978f-9caf-4a4f-93e6-57fd12120223 Samsung 'GT-I9100M' URL at : http://phony/ Uptime 2 I wonder if we can put a trap in for detecting old versions of flash?

Comment 8

•

13 years ago

It's #49 top crasher in 14.0b2. I am removing the topcrash keyword.

Keywords: topcrash

Naoki Hirata :nhirata (please use needinfo instead of cc)

Comment 9

•

13 years ago

It's #10 top crasher in 14.0.

blocking-fennec1.0: --- → ?

Keywords: topcrash

Alex Keybl [:akeybl]

Comment 10

•

13 years ago

Let's get URLs for this bug to see if we can find STR.

Keywords: needURLs

Reporter

Updated

•

13 years ago

Keywords: qawanted

Naoki Hirata :nhirata (please use needinfo instead of cc)

Reporter

Comment 12

•

13 years ago

From previous to this date: https://crash-stats.mozilla.com/report/list?product=FennecAndroid&query_search=signature&query_type=contains&query=pr_FindSymbolInLib&reason_type=contains&date=06%2F27%2F2012%2021%3A47%3A38&range_value=4&range_unit=weeks&hang_type=any&process_type=any&do_query=1&admin=1&signature=pr_FindSymbolInLib Bugs listed with this crash signature: 693363 692149 70543 747296 700583 URLs 27 about:home 9 about:blank 2 http://mosa-d-web.mosa-d.gov.sa/infoCust.aspx 2 http://www.google.com/ 2 http://m.youtube.com/#/watch?v=uW0bXp-jXxI 1 https://www.google.com/m?q=www&ie=utf-8&oe=utf-8&aq=t&rls=org.mozilla:en-US:offi 1 http://m.youtube.com/watch?v=g1CJijhGnfo 1 http://static.bada.com/contents/deviceterms/603.txt 1 http://m.facebook.com/story.php?story_fbid=453843457968732&id=100000292462822&re 1 http://coderwall.com/ 1 https://addons.mozilla.org/en-US/android/addon/full-screen-252573/?src=api 1 https://www.google.com/m?oe=utf-8&q=hayghe.com 1 http://m.youtube.com/watch?v=uW0bXp-jXxI 1 http://www.youtube.com/ 1 https://www.icloud.com/ 1 http://www.google.ca/ 1 http://www.google.com/#hl=en&sa=X&ei=vDzIT5n3DILWgQe749lI&sqi=2&ved=0CAQQBSgA&q= 1 http://www.hulu.com/ 1 http://wap.bild.de/ 1 http://symbianannagame.blogspot.com/2012/02/adobe-shockwave-player-115-free.html 1 http://www.google.com.tr/#hl=tr&sclient=psy-ab&q=yaygara+tv+kurtlar+vadisi+pusu& 1 http://ptf.com/shockwave/shockwave+.apk/ 1 http://www.google.com.vn/#hl=vi&gs_nf=1&cp=3&gs_id=m&xhr=t&q=mshoatoeic&pf=p&scl 1 http://m.youtube.com/#/watch?v=g1CJijhGnfo 1 http://www.google.com.tr/#hl=tr&sclient=psy-ab&q=yaygara+tv+kurtlar+vadisi+pusu& 1 https://www.google.com/url?url=http://www.adobe.com/shockwave/welcome/&rct=j&sa= 1 http://www.freeandroidtv.com/index.php

Naoki Hirata :nhirata (please use needinfo instead of cc)

Reporter

Comment 13

•

13 years ago

Possibly old flash plugin? ( https://bugzilla.mozilla.org/show_bug.cgi?id=700583#c5 )

Keywords: needURLs, qawanted

Mark Finkle (:mfinkle) (use needinfo?)

Updated

•

13 years ago

tracking-fennec: --- → +

blocking-fennec1.0: ? → -

Comment 14

•

13 years ago

This is rising on 14.0.1 now.

Assignee

Comment 15

•

13 years ago

Bug 783263 has kinda-str for this. I'll dup it to this one. This has to do with a Flash upgrade, probably we timed out the plugin container after 5 minutes of no-use and then try to restart it but the Flash DLL is no longer present.

Assignee

Comment 17

•

13 years ago

ok, I didn't realize that this was filed against mobile: I think that it's the same basic issue though: the Flash player DLL is either missing (uninstalled while we're running? or cannot be loaded for some reason. We can certainly protected against that with null check which should cover both desktop and mobile. In the desktop case, this is because the Flash DLL name changes on upgrade and we weren't locking it, but the root problem might be fundamentally different on mobile.

Assignee

Comment 18

•

13 years ago

Attached patch Null checking and error handling, rev. 1 — Details — Splinter Review

Assignee: nobody → benjamin

Status: NEW → ASSIGNED

Attachment #652826 - Flags: review?(joshmoz)

Comment 19

•

13 years ago

As this seems to be connected to Flash and is in the top 10 crashes on mobile, CCing snorp, so he knows about it. Would be nice to get that patch in possibly for 15, if it really helps with those mobile crashes.

Comment 20

•

13 years ago

This is #5 in FennecAndroid 14.0.1 now, and #6 on FennecAndroid 15.0b5, in the latter case with only a Flash signatures in front of it besides four that are fixed for 15.0b6, so this might very well turn out to be #2 for 15.

Assignee

Updated

•

13 years ago

tracking-firefox15: --- → ?

tracking-firefox16: --- → ?

Updated

•

13 years ago

status-firefox15: --- → affected

status-firefox16: --- → affected

tracking-firefox15: ? → +

Comment 21

•

13 years ago

I'd like to know the risk assessment for this fix if it was nominated for beta approval. It will indeed rise in Fennec topcrashers but to what extent? Could we live with this for 6 weeks or keep it as a possible ride-along in case there's a 15 chemspill?

tracking-firefox16: ? → +

Josh Aas

Updated

•

13 years ago

Attachment #652826 - Flags: review?(joshmoz) → review+

http://hg.mozilla.org/mozilla-central/rev/1b51c7bf1e05

Assignee

Comment 22

•

13 years ago

Status: ASSIGNED → RESOLVED

Closed: 13 years ago

Resolution: --- → FIXED

Assignee

Comment 23

•

13 years ago

Comment on attachment 652826 [details] [diff] [review] Null checking and error handling, rev. 1 [Approval Request Comment] Bug caused by (feature/regressing bug #): inability to load the Flash plugin. On Windows desktop we have found that this can happen if Flash updates itself while the browser has been idle for a while. On mobile we're not sure why this is happening: perhaps Flash doesn't work on the device at all, or it is currently being updated, or it is currently being uninstalled or was uninstalled in the past. User impact if declined: Continued crashes, most notably on mobile Testing completed (on m-c, etc.): just landed on m-c Risk to taking this patch (and alternatives if risky): This patch is a straightforward null-check with error propagation. It feels very non-risky to me, but this is of course plugin code so it's difficult to test in the wild. String or UUID changes made by this patch: None

Attachment #652826 - Flags: approval-mozilla-beta?

Attachment #652826 - Flags: approval-mozilla-aurora?

Updated

•

13 years ago

status-firefox17: --- → fixed

Target Milestone: --- → mozilla17

Comment 24

•

13 years ago

Comment on attachment 652826 [details] [diff] [review] Null checking and error handling, rev. 1 While this bug will shoot up to being a higher crash in Fennec (due to other topcrashers being fixed for b6) we're too close to final beta to get the proper crash data back on this between now and gtb for RC on Friday 8/24. Approving for Aurora, we can watch how this helps there when it moved to Beta on 8/27.

Attachment #652826 - Flags: approval-mozilla-beta?

Attachment #652826 - Flags: approval-mozilla-beta-

Attachment #652826 - Flags: approval-mozilla-aurora?

Attachment #652826 - Flags: approval-mozilla-aurora+

Alex Keybl [:akeybl]

Updated

•

13 years ago

status-firefox15: affected → wontfix

https://hg.mozilla.org/releases/mozilla-aurora/rev/def773f1aeac

Assignee

Comment 25

•

13 years ago

status-firefox16: affected → fixed

Comment 26

•

13 years ago

(In reply to Lukas Blakk [:lsblakk] from comment #24) > While this bug will shoot up to being a higher crash in Fennec (due to other > topcrashers being fixed for b6) It's indeed #1 top crasher in 15.0b6.

Comment 27

•

13 years ago

Scoobidiver, with such a low amount of people running that (and a low amount of crashes in the list), we should be careful with statements like that, with more usage the ranking can easily change. Still, you are right for early 15.0b6 data, we'll see after the weekend if 15.0b7 looks the same, but we should expect it to. This crash exists in 14.0.1 as well, and the relative volume seems to be similar, so this is all expected and we are OK with that (as long as the volume doesn't explode). We might have fixed this crash for 16 (note that so far there's no real confirmation that the patch even helps for mobile), and we'll need to verify there and on Nightly.

Comment 28

•

13 years ago

(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #27) > Scoobidiver, with such a low amount of people running that (and a low amount > of crashes in the list), we should be careful with statements like that, > with more usage the ranking can easily change. For top crashers, the rank is usually stable although it's early in the cycle. It also confirms that the fix of bug 776334 has made other top crashers shift in ranking. Finally, I am fine with the decision of not fixing it for 15.0, but if no regression is found in 16.0 Beta or Aurora 17.0, building a 15.0.1 should be considered.

Assignee

Comment 29

•

13 years ago

I am 99.44% certain that this patch fixes the crash on mobile. I don't know what will happen next: Flash just won't work, or no visible issue at all.

Comment 30

•

13 years ago

(In reply to Scoobidiver from comment #28) > [...], building a 15.0.1 should be > considered. We will not do a 15.0.1 just for this issue. If a 15.0.1 comes along for *other* reasons (security or bad regressions) and we have confirmation that this patch works on 16, then this patch might be a ride-along for that. This is not a regression, at least it doesn't look like one right now, so no concern at all that could trigger a 15.0.1 by itself and no reason to push hard for making 15.0 itself. Actually, if something would come up right now that would be grave enough that we'd know we'd need to do a 15.0.1 for it, we'd probably instead see to get it into 15.0 itself, as only large regressions and critical security issues (0days) would trigger such a chemspill and we'd not want to ship a final knowing about such issues. All that said, thanks to bsmedberg for comment 29, makes me feel more confident that we have the crash itself fixed for 16 - though we'll only feel really good when we see data confirming that.

Comment 31

•

13 years ago

Now that bug 783754 is fixed in 15.0b7, a Flash crash takes the lead and this one is only #2.

Alex Keybl [:akeybl]

Comment 32

•

13 years ago

(In reply to Scoobidiver from comment #31) > Now that bug 783754 is fixed in 15.0b7, a Flash crash takes the lead and > this one is only #2. Given the prevalence of this crash on 14.* and 15.0b*, I'm really surprised that it's not showing up in the reviews more often. I don't have a good feel for why that might be - perhaps it's really intermittent but affecting a large population?

Comment 33

•

13 years ago

Comment on attachment 652826 [details] [diff] [review] Null checking and error handling, rev. 1 [Triage Comment] We're doing a 15.0.1 and taking this as a ride-along

Attachment #652826 - Flags: approval-mozilla-release+

Attachment #652826 - Flags: approval-mozilla-beta-

Attachment #652826 - Flags: approval-mozilla-beta+

Josh Aas

Comment 34

•

13 years ago

pushed to mozilla-release https://hg.mozilla.org/releases/mozilla-release/rev/faa9affedb6c Required re-application due to a context difference, and the patch on the bug here has an error ("nresult" instead of "nsresult").