Closed Bug 703102 Opened 13 years ago Closed 7 years ago

Signatures containing [] don't get connected to bugs. like -[NativeMenuItemTarget menuItemHit:] (Objective-C, ObjC)

Categories

(Socorro :: Backend, task)

Product:
Socorro
Component:
Backend
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: kairo, Unassigned)

References

Details

https://crash-stats.mozilla.com/report/list?signature=-[NativeMenuItemTarget%20menuItemHit%3A] and https://crash-stats.mozilla.com/report/list?signature=%400x0%20|%20-[NativeMenuItemTarget%20menuItemHit%3A] don't link to bug reports, even though bug 670914 exists for them. I guess that's because of the square brackets that are part of the signatures (!) but also used as delimiters.
Those are ObjC methods, FWIW.
Component: Socorro → General
Product: Webtools → Socorro
Blocks: 670914, 711917
Summary: Signatures containing [] don't get connected to bugs → Signatures containing [] don't get connected to bugs. like -[NativeMenuItemTarget menuItemHit:]
Bug 769894 is another case of this.
And bug 893973. Who's the right owner for this?
Flags: needinfo?(chris.lonnen)
Unclear. It would have been me a while ago, maybe I can get to it next week. Anyone is welcome to take it earlier. If it's suddenly a priority we can find someone I'm sure. The issue is here: https://github.com/mozilla/socorro/blob/master/socorro/cron/jobs/bugzilla.py#L243 Basically the parser doesn't keep track of bracket pairs in the signature. It needs to be modified to check for opening '[' inside an '[@' and only match the signature when it's sure to be matching the appropriate closing ']' for '[@'.
Flags: needinfo?(chris.lonnen)
I can't believe we never noticed this before. :)
Summary: Signatures containing [] don't get connected to bugs. like -[NativeMenuItemTarget menuItemHit:] → Signatures containing [] don't get connected to bugs. like -[NativeMenuItemTarget menuItemHit:] (Objective-C, ObjC)
I can also make QA, if needed.
Component: General → Backend
OS: Linux → All
Hardware: x86_64 → All
Version: Trunk → unspecified
Pretty sure this got fixed as part of bug #1366814. That bug sure sounds a lot like this one. Marking as FIXED. If it's still not fixed, please provide a more recent test case and I can look into it.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
LGTM
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.