70436 - [rfe] link from attached patch to colored diffs (cvsview2.cgi)

Status: RESOLVED DUPLICATE of bug 174942

(Bugzilla :: Creating/Changing Bugs, enhancement, P2)

Description

[Jesse Ruderman]

Bugzilla should put a link next to each attached patch that runs the patch 
through the pretty-colored diff script (cvsview2.cgi) on bonsai.  This could be 
added between the date (which is also the link to the actual patch) and the 
name of the patch.  The link could be called "show patch in context", or 
perhaps something shorter.

Making this feature work would probably require adding code to bonsai that lets 
the user specify a URL for a new patch for display in cvsview2.cgi.  Cvsview2 
should probably link back to the patch, perhaps by replacing "Version [new]" 
with "With _patch_" when it's running patches that haven't yet been checked in.

Since patches contain the old version number, it should be possible to display 
a patch even if it's not against the latest version.  Cvsview2.cgi should 
complain about out-of-date patches, though, to make it easier to notice when 
patches need to be updated.  Maybe some red text at the top containing a few 
links:

This patch was made against version _1.1_, but the newest version of this file 
is _1.4_.
_Show diff_ between 1.1 and 1.4.


Random bug with a patch: bug 62445

To get a random patch shown in cvsview2.cgi, go to 
http://tinderbox.mozilla.org/showbuilds.cgi?tree=SeaMonkey, click on someone's 
name, click on "last check-in", and click on the revision number.

Comment 1

[Håkan Waara]

This would increase my reviewing powers by 300%.

Comment 2

[Jesse Ruderman]

Hmm, I forgot that many patches touch multiple files.  I guess there would have 
to be an extra script (probably on bonsai) to take the patch and list the files 
it touches, letting you look at colored diffs for each file.

Comment 3

[timeless]

that's not too hard, i have a script that converts patches into a list of files 
which it checks out from cvs (based on the listed revision).

Comment 4

[Håkan Waara]

Is there anything I can do to convince you guys that this would help reviewing 
patches a lot easier? And would probably increase general productivity a lot!

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Nope, since I'm already convinced. :-)

Comment 6

[Dave Miller [:justdave]]

-> Bugzilla product

Comment 7

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 8

[Jesse Ruderman]

*** This bug has been marked as a duplicate of 174942 ***

Comment 9

[Dave Miller [:justdave]]

clearing milestone in INVALID/WONTFIX/DUPLICATE/WORKSFORME so they'll show up as
untriaged if they get reopened.