705767 - Validate credentials before completing setup

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Android Sync, defect, P1)

Description

[Richard Newman [:rnewman]]

Filing here until we get a component.

Comment 2

[Richard Newman [:rnewman]]

I expect most setup processes to be via J-PAKE, so this isn't an immediate concern.

Comment 4

[Andreea Pod]

Is this implying the state of "Connect" button also? Meaning that it should be disabled if, for example the email address is not in a valid email address format, or if the sync key has less characters than a valid sync key, or one of the fields is not empty.

Comment 5

[Chenxia Liu [:liuche]]

In the current m-c build, the connect button should not be enabled if any of the fields is empty - please reopen bug 711868 with the device you are using if this is the case (if relevant).

This does bug does not include validation checks for email and sync-key size (AFAIK actually, XUL fennec sync did not validate email addresses).

Comment 6

[Richard Newman [:rnewman]]

This bug is about "live" validation -- that is, before you complete setup, make some network request and do some work to make sure that the credentials you've entered will be able to sync. That's a superset of syntactic validation.

Comment 7

[Richard Newman [:rnewman]]

If it's a blocker, it's a P1.

Comment 8

[Chenxia Liu [:liuche]]

Pull request in github awaiting review and feedback.

Comment 9

[Allison Naaktgeboren :ally]

re-nomming as this should be a beta blocker or not a blocker at all,  and closing the related string bug, as l10n says no strings without features.

Comment 10

[Chenxia Liu [:liuche]]

Github pull request:
https://github.com/mozilla-services/android-sync/pull/143

Not blocking Fennec, so won't be landing anytime soon.

Comment 11

[Richard Newman [:rnewman]]

Needs a fix. Back to Chenxia.

Comment 12

[Chenxia Liu [:liuche]]

Attachment: Validate credentials patch

depends loosely on patch from bug 717707.

Comment 13

[Chenxia Liu [:liuche]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9e508c1d3d6d

STR:

- Launch Sync setup. Click "Advanced Setup" to launch manual credential entry.
- Type in credentials.
- Manually sleep the device (or wait for powersave).

Expected:
Username and Sync Key are not cleared; password field will be cleared.

Comment 14

[Chenxia Liu [:liuche]]

Whoops, wrong bug STR and inbound link.

https://hg.mozilla.org/integration/mozilla-inbound/rev/5685dcf1f147

STR:
1. Launch Sync setup, click on "Advanced Setup" to go to manual credential entry.
2. Enter username, password, sync key.
3. When all three fields are non-empty, "Connect" should become clickable.
4. If either username or password is incorrect, verification should fail.

Notes:
- Please test w/ non-email-form usernames as well (from early sync accounts), because these should also work.

Comment 15

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5685dcf1f147

Comment 16

[Richard Newman [:rnewman]]

Comment on attachment 630323 [details] [diff] [review]
Validate credentials patch

Not a blocker, and code already landed. Clearing flag.

Comment 17

[Tracy Walker [:tracy]]

verified with latest nightly

Comment 19

[Tracy Walker [:tracy]]

This was minused blocking fennec1.0 back in April.  Lingering tracking 11+ flag has caused some confusion. So I am removing that flag and marking status-firefox16 verified as that was the eventual target milestone. Then was fixed and verified in m-c at that time.