707395 - Remove deprecated PR_ABS/PR_MIN/PR_MAX uses from nsSHistory.cpp

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Serge Gautherie (:sgautherie)]

Bug 683777 added these, after bug 518502 removed them from the tree :-/

Comment 1

[Thomas Prip Vestergaard [:prip]]

Attachment: Replace PR_MIN/PR_MAX/PR_ABS with NS_MIN/NS_MAX/NS_ABS

I replaced PR_ABS with NS_ABS. Should we do that?

Comment 2

[Justin Lebar (not reading bugmail)]

> I replaced PR_ABS with NS_ABS. Should we do that?

Yep.  This looks great!

If you post a new patch with a checkin comment in the form of

  Bug XXX - Replace PR_MIN/PR_MAX/PR_ABS with NS_MIN/NS_MAX/NS_ABS

I'll check it in for you.

Comment 3

[Thomas Prip Vestergaard [:prip]]

Attachment: Bug 707395 - Replace PR_MIN/PR_MAX/PR_ABS with NS_MIN/NS_MAX/NS_ABS

Comment 4

[Justin Lebar (not reading bugmail)]

Comment on attachment 579950 [details] [diff] [review]
Bug 707395 - Replace PR_MIN/PR_MAX/PR_ABS with NS_MIN/NS_MAX/NS_ABS

Thanks for your patch!

Pushed to mozilla-inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/a6c007e53973

I don't expect this to cause test failures, but you can keep an eye at https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=a6c007e53973

(By the way, it looks like this file had Windows line-endings.  In the future, please submit patches with Unix endings.  You can use the tool dos2unix to convert them.)

Comment 5

[Ed Morley [:emorley]]

This has now made it's way to mozilla-central - thanks for the patch! :-)

If you're interested in working on more bugs and need some inspiration, pop onto #developers and say hi!

https://hg.mozilla.org/mozilla-central/rev/a6c007e53973