Remove deprecated PR_ABS/PR_MIN/PR_MAX uses from nsSHistory.cpp

RESOLVED FIXED in mozilla11

Status

()

Core
Document Navigation
--
minor
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: sgautherie, Assigned: prip)

Tracking

(Blocks: 1 bug)

Trunk
mozilla11
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=jlebar][lang=c++], URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Bug 683777 added these, after bug 518502 removed them from the tree :-/
(Reporter)

Updated

6 years ago
Whiteboard: [good first bug]
(Reporter)

Updated

6 years ago
Flags: in-testsuite-
(Reporter)

Updated

6 years ago
Blocks: 707396
Whiteboard: [good first bug] → [mentor=jlebar]

Updated

6 years ago
Whiteboard: [mentor=jlebar] → [mentor=jlebar][lang=c++]
(Assignee)

Comment 1

6 years ago
Created attachment 579692 [details] [diff] [review]
Replace PR_MIN/PR_MAX/PR_ABS with NS_MIN/NS_MAX/NS_ABS

I replaced PR_ABS with NS_ABS. Should we do that?

Updated

6 years ago
Attachment #579692 - Flags: review?(justin.lebar+bug)
(Reporter)

Updated

6 years ago
Blocks: 708277
(Reporter)

Updated

6 years ago
Summary: Remove 3 deprecated PR_MIN/PR_MAX uses from nsSHistory.cpp → Remove deprecated PR_ABS/PR_MIN/PR_MAX uses from nsSHistory.cpp
> I replaced PR_ABS with NS_ABS. Should we do that?

Yep.  This looks great!

If you post a new patch with a checkin comment in the form of

  Bug XXX - Replace PR_MIN/PR_MAX/PR_ABS with NS_MIN/NS_MAX/NS_ABS

I'll check it in for you.
Attachment #579692 - Flags: review?(justin.lebar+bug) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 579950 [details] [diff] [review]
Bug 707395 - Replace PR_MIN/PR_MAX/PR_ABS with NS_MIN/NS_MAX/NS_ABS
Attachment #579692 - Attachment is obsolete: true
Comment on attachment 579950 [details] [diff] [review]
Bug 707395 - Replace PR_MIN/PR_MAX/PR_ABS with NS_MIN/NS_MAX/NS_ABS

Thanks for your patch!

Pushed to mozilla-inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/a6c007e53973

I don't expect this to cause test failures, but you can keep an eye at https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=a6c007e53973

(By the way, it looks like this file had Windows line-endings.  In the future, please submit patches with Unix endings.  You can use the tool dos2unix to convert them.)

Comment 5

6 years ago
This has now made it's way to mozilla-central - thanks for the patch! :-)

If you're interested in working on more bugs and need some inspiration, pop onto #developers and say hi!

https://hg.mozilla.org/mozilla-central/rev/a6c007e53973
Assignee: nobody → thomas
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.