No tab item is selected after removing last tab in a group outside Panorama (follow up)

RESOLVED FIXED in Firefox 11

Status

Firefox Graveyard
Panorama
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: Stefan, Assigned: raymondlee)

Tracking

({regression})

Trunk
Firefox 11
regression

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

6 years ago
User Agent:  

Steps to reproduce:

1) Open two groups in Panorama. Each group with one tab.
2) Click on one tabitem
3) In the normal browser mode, 
4) Close/restart Fx.
5) Close the last tab.



Actual results:

No tab item is selected.


Expected results:

A tab item is selected.

Related to 
Bug 705621 - No tab item is selected after removing last tab in a group outside Panorama
Mozilla/5.0 (X11; Linux x86_64; rv:11.0a1) Gecko/20111204 Firefox/11.0a1

Confirmed using Stefan's STR.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Other → All
Hardware: Other → All
(Assignee)

Updated

6 years ago
Assignee: nobody → raymond
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

6 years ago
Created attachment 579009 [details] [diff] [review]
v1
Attachment #579009 - Flags: review?(ttaubert)
Comment on attachment 579009 [details] [diff] [review]
v1

Review of attachment 579009 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks! Please add a test for this.

::: browser/base/content/browser-tabview.js
@@ +132,4 @@
>                if (self._closedLastVisibleTabBeforeFrameInitialized) {
>                  self._closedLastVisibleTabBeforeFrameInitialized = false;
> +                win.UI.showTabView(false);
> +                win.UI.setActive(win.GroupItems.getActiveGroupItem());

Please move this to UI.init() and wrap it in 'if (!GroupItems.getActiveGroupItem()) { ... }' if that works.
Attachment #579009 - Flags: review?(ttaubert) → feedback+
(Assignee)

Comment 4

6 years ago
Created attachment 579615 [details] [diff] [review]
v2

I've looked into this and fixed the root cause. Also, added a test.
Attachment #579009 - Attachment is obsolete: true
Attachment #579615 - Flags: review?(tim.taubert)
Blocks: 669694
Keywords: regression
Comment on attachment 579615 [details] [diff] [review]
v2

Review of attachment 579615 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, that fix is obviously much better. Thanks for digging into that!
Attachment #579615 - Flags: review?(tim.taubert) → review+
(Assignee)

Comment 6

6 years ago
Created attachment 579676 [details]
Patch for checkin

Pushed to try and waiting for results
https://tbpl.mozilla.org/?tree=Try&rev=9f1395703e05
Attachment #579615 - Attachment is obsolete: true
(Assignee)

Comment 7

6 years ago
Passed Try!
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/8d91ee82719c
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Sorry, didn't mean to mark it as fixed, yet.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/8d91ee82719c
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 11
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.