707466 - No tab item is selected after removing last tab in a group outside Panorama (follow up)

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Stefan]

User Agent:  

Steps to reproduce:

1) Open two groups in Panorama. Each group with one tab.
2) Click on one tabitem
3) In the normal browser mode, 
4) Close/restart Fx.
5) Close the last tab.



Actual results:

No tab item is selected.


Expected results:

A tab item is selected.

Related to 
Bug 705621 - No tab item is selected after removing last tab in a group outside Panorama

Comment 1

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (X11; Linux x86_64; rv:11.0a1) Gecko/20111204 Firefox/11.0a1

Confirmed using Stefan's STR.

Comment 2

[Raymond Lee [:raymondlee]]

Attachment: v1

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 579009 [details] [diff] [review]
v1

Review of attachment 579009 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks! Please add a test for this.

::: browser/base/content/browser-tabview.js
@@ +132,4 @@
>                if (self._closedLastVisibleTabBeforeFrameInitialized) {
>                  self._closedLastVisibleTabBeforeFrameInitialized = false;
> +                win.UI.showTabView(false);
> +                win.UI.setActive(win.GroupItems.getActiveGroupItem());

Please move this to UI.init() and wrap it in 'if (!GroupItems.getActiveGroupItem()) { ... }' if that works.

Comment 4

[Raymond Lee [:raymondlee]]

Attachment: v2

I've looked into this and fixed the root cause. Also, added a test.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 579615 [details] [diff] [review]
v2

Review of attachment 579615 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, that fix is obviously much better. Thanks for digging into that!

Comment 6

[Raymond Lee [:raymondlee]]

Attachment: Patch for checkin

Pushed to try and waiting for results
https://tbpl.mozilla.org/?tree=Try&rev=9f1395703e05

Comment 7

[Raymond Lee [:raymondlee]]

Passed Try!

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/8d91ee82719c

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

Sorry, didn't mean to mark it as fixed, yet.

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/8d91ee82719c