708780 - Tapping links can leave focus rings

Status: VERIFIED WORKSFORME

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Deb Richardson [:dria] (plz NEEDINFO)]

Tapping links in Fennec seems to have a few possible results:

1) Tap works fine and does what it's supposed to
2) Tapping highlights the link (blue background) but doesn't actually do anything until I tap again
3) Tapping highlights the link (blue background) but doesn't actually do anything until I tap again at which point it temporarily outlines the link with a blue box while the new page loads
4) Tapping outlines the link with a blue box while the new page loads
5) Tapping does nothing at all -- no highlight, no box, no new page.  It tends to stay in this state until I scroll around a bit or zoom the page.

Obviously it would be ideal if we could just have #1 be the result of a click :)

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Deb can you try on the latest?  To note, haptic feedback also occurs when you tap on a link now.  Also could you let us know which device you are on and which build you are on please?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

#1 and #4 are basically the same state, just painting speed/update differences
#2 and #3 are basically the same state, just painting speed/update differences
#5 is a different bug

We have been working on code related to tapping, so testing again would be helpful.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Wes - Can you take a look at this. Not sure if certain pages are more likely to be erratic or not.

Deb - Can you give us an update of the situation?

Comment 4

[Wesley Johnston (:wesj)]

No update. QA, can you help verify or close this?

Comment 5

[Deb Richardson [:dria] (plz NEEDINFO)]

Testing on the build from Jan 16th (today's was crashing on me a ton) on my Galaxy Nexus, I'm still getting erratic link-tapping results.

Mostly it seems ok - I tap, get haptic feedback, the link is outlined with a blue box and the new page loads.  Other times:

1) There's lag -- I tap and nothing happens for a fraction of a second (a noticeably large fraction) then there's haptic feedback, link outline, etc.
2) Nothing happens
3) I tap and get haptic feedback but no blue outline but the page loads
4) I tap and get haptic feedback but no blue outline and the page doesn't load
5) I tap and get double haptic feedback (bzz bzz) with no outline but the page loads

The sites I was testing on were: New York Times, Epicurious, and Google News for the most part.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

We need more QA here. We don't know how widespread the issue has become. I am lowering priority until we get more feedback from others.

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

I can repeat the same issue with the HTC thunderbolt with varying results as well.  It looks like it has to do with how soon the tap occurs after the page lands and/or how long you tap.  Still experimenting.  In order to get to the state of the screenshot, I ended up semilong tapping on the first link, hitting the back button and quickly tapping on the second link as soon as the page landed.

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Looks like 2 can be reproduced by semi long tapping.  ie Long tap long enough to almost consider it a long tap but short enough for it not to bring up the context menu.

Quick tap can produce the blue box while loading

I can't seem to reproduce 5 consistently, though I have a suspicion that it may have something to do with responsiveness.  Need more to investigate 5 more.

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Hi Deb, can you take a look at this bug again with the latest nightly?  I can't seem to reproduce 5 at all.

Comment 11

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Dria stated in irc chan she hasn't noticed atm for step 5.

Comment 12

[Kevin Brosnan [Ex-Mozilla]]

Looks like the focus ring issue is the only thing open from comment 0 then.

Comment 14

[Paul [pwd]]

Attachment: I'm seeing this in orange

I too am seeing this bug. It's happening on links and select boxes. Also if the link is on two lines it will draw an outline that encapsulates the whole link.

Comment 15

[Brad Lassey [:blassey] (use needinfo?)]

we don't do focus rings anymore

Comment 16

[Cristian Nicolae (:xti)]

I can reproduce this issue on the latest Nightly.

STR:
1. Go to news.google.com
2. Tap on any link
3. After the new page is loaded tap on back button

Actual result:
After step 3, the selected link is selected by a dotted grey line.
After step 2, there is the same selection left until the new page is loaded.

--
Firefox 18.0a1 (2012-09-17)
Device: Galaxy Note
OS: Android 4.0.4

Comment 17

[Aaron Train [:aaronmt]]

Not the same nor the issue reported.

Comment 18

[Cristian Nicolae (:xti)]

(In reply to Aaron Train [:aaronmt] from comment #17)
> Not the same nor the issue reported.

Is it an issue or it's expected? I cannot reproduce STR from comment #16 on the stock browser.

Closing this bug as verified WFM