Closed
Bug 708788
Opened 13 years ago
Closed 13 years ago
Add telemetry probes for new/close tab animations
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 11
People
(Reporter: lmandel, Assigned: dao)
References
(Blocks 1 open bug)
Details
(Whiteboard: [Snappy] [Telemetry])
Attachments
(1 file)
4.25 KB,
patch
|
dietrich
:
review+
taras.mozilla
:
review+
|
Details | Diff | Splinter Review |
As requested by product (see https://etherpad.mozilla.org/desktop-responsiveness) add a telemetry probe for new tab and closed tab animations.
Assignee | ||
Updated•13 years ago
|
Component: Telemetry → Tabbed Browser
Product: Toolkit → Firefox
QA Contact: telemetry → tabbed.browser
Comment 1•13 years ago
|
||
Is this to measure the time spent solely animating, as distinct from the full time to open/close a tab?
Comment 2•13 years ago
|
||
It might be useful to track the time in between returning from removeTab, and _endRemoveTab (the end of the animation), to detect how much it varies from the specified animation time in practice.
Comment 3•13 years ago
|
||
yes, I want to know whether or not we're actually getting the user experience we've specified in the CSS. I'll have separate bugs for tuning that transition timing in the css.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → dao
Assignee | ||
Comment 4•13 years ago
|
||
I don't know if my histogram definitions make sense -- when should LINEAR be used and what motivates the bucket size?
Attachment #581634 -
Flags: review?(taras.mozilla)
Attachment #581634 -
Flags: review?(dietrich)
Comment 5•13 years ago
|
||
Comment on attachment 581634 [details] [diff] [review] patch Review of attachment 581634 [details] [diff] [review]: ----------------------------------------------------------------- code changes look fine. per Taras comment on other telemetry patch, should add the unit (eg: "_MS" or something) to the histogram name. wrt to the maximum value - you should do some timings in a few different environments to see what the values look like to see what high/low values you get. we can also adjust later if the in-the-wild values are radically different. wrt to buckets - i don't really know. am not sure about why/where it's important to have more or less buckets. maybe when variation in results is quite high?
Attachment #581634 -
Flags: review?(dietrich) → review+
Comment 6•13 years ago
|
||
Comment on attachment 581634 [details] [diff] [review] patch I don't see value in measuring up to 3 seconds of tab anim, but up to you. Please add _MS to histogram names that measure milliseconds
Attachment #581634 -
Flags: review?(taras.mozilla) → review+
Assignee | ||
Comment 7•13 years ago
|
||
3 seconds is the time after which tabbrowser gives up waiting for the animation to finish and forcefully removes the tab. Some users seem to still hit that limit.
Assignee | ||
Comment 8•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/5c428813b210
Target Milestone: --- → Firefox 11
Comment 9•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5c428813b210
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•13 years ago
|
Comment 10•13 years ago
|
||
Already paying back. Looks like this caught a regression between fx9 and fx10: bug 724349.
You need to log in
before you can comment on or make changes to this bug.
Description
•