The default bug view has changed. See this FAQ.

Add telemetry probes for new/close tab animations

RESOLVED FIXED in Firefox 11

Status

()

Firefox
Tabbed Browser
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: lmandel, Assigned: dao)

Tracking

(Blocks: 2 bugs)

unspecified
Firefox 11
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Snappy] [Telemetry])

Attachments

(1 attachment)

4.25 KB, patch
dietrich
: review+
(dormant account)
: review+
Details | Diff | Splinter Review
As requested by product (see https://etherpad.mozilla.org/desktop-responsiveness) add a telemetry probe for new tab and closed tab animations.
(Assignee)

Updated

5 years ago
Component: Telemetry → Tabbed Browser
Product: Toolkit → Firefox
QA Contact: telemetry → tabbed.browser
Is this to measure the time spent solely animating, as distinct from the full time to open/close a tab?
It might be useful to track the time in between returning from removeTab, and _endRemoveTab (the end of the animation), to detect how much it varies from the specified animation time in practice.

Comment 3

5 years ago
yes, I want to know whether or not we're actually getting the user experience we've specified in the CSS. I'll have separate bugs for tuning that transition timing in the css.
Blocks: 596954
(Assignee)

Updated

5 years ago
Assignee: nobody → dao
(Assignee)

Updated

5 years ago
Blocks: 671039
(Assignee)

Comment 4

5 years ago
Created attachment 581634 [details] [diff] [review]
patch

I don't know if my histogram definitions make sense -- when should LINEAR be used and what motivates the bucket size?
Attachment #581634 - Flags: review?(taras.mozilla)
Attachment #581634 - Flags: review?(dietrich)
Comment on attachment 581634 [details] [diff] [review]
patch

Review of attachment 581634 [details] [diff] [review]:
-----------------------------------------------------------------

code changes look fine. per Taras comment on other telemetry patch, should add the unit (eg: "_MS" or something) to the histogram name.

wrt to the maximum value - you should do some timings in a few different environments to see what the values look like to see what high/low values you get. we can also adjust later if the in-the-wild values are radically different.

wrt to buckets - i don't really know. am not sure about why/where it's important to have more or less buckets. maybe when variation in results is quite high?
Attachment #581634 - Flags: review?(dietrich) → review+

Comment 6

5 years ago
Comment on attachment 581634 [details] [diff] [review]
patch

I don't see value in measuring up to 3 seconds of tab anim, but up to you. Please add _MS to histogram names that measure milliseconds
Attachment #581634 - Flags: review?(taras.mozilla) → review+
(Assignee)

Comment 7

5 years ago
3 seconds is the time after which tabbrowser gives up waiting for the animation to finish and forcefully removes the tab. Some users seem to still hit that limit.
(Assignee)

Comment 8

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/5c428813b210
Target Milestone: --- → Firefox 11
https://hg.mozilla.org/mozilla-central/rev/5c428813b210
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Blocks: 593680
No longer blocks: 596954
Blocks: 671038
Already paying back. Looks like this caught a regression between fx9 and fx10: bug 724349.

Updated

5 years ago
Duplicate of this bug: 708673
Duplicate of this bug: 708672
You need to log in before you can comment on or make changes to this bug.