709385 - Passwords repository layer for Fennec local DB

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Android Sync, defect, P1)

Description

[Allison Naaktgeboren :ally]

might make the first drop if mobile gets us the content provider in time.

Comment 1

[Jason Voll [:jvoll]]

Where I left off:
Currently code will run if the patch from mobile is applied (Bug 704682). This should land soon. We also need to encrypt/decrypt passwords (Bug 711636).

Comment 2

[Richard Newman [:rnewman]]

Waiting on the content provider interface for this, too.

Comment 3

[Richard Newman [:rnewman]]

Aiming for end of Jan, assuming that the Fennec CP is ready. Removing block for initial repository set, because we decided those were bookmarks and history.

Comment 5

[Richard Newman [:rnewman]]

Ready to work on as soon as Bug 718760 lands…

(Lifting that transitive dependency to here to make it easier to see.)

Comment 6

[Allison Naaktgeboren :ally]

the work is taking place on github, and is waiting review

Comment 7

[Nick Alexander :nalexander [he/him]]

I made a build with this and form history enabled.  After sync, form history item for username is in Fennec moz_formhistory and password is in moz_logins (there is no form history item for password in Fennec moz_formhistory -- this seems correct).

I begin to enter username and form history correctly shows completion, but selecting unique completion does not complete password box.

What gives?

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

what's the status here?

Comment 9

[Richard Newman [:rnewman]]

(In reply to Brad Lassey [:blassey] from comment #8)
> what's the status here?

Reviewing this afternoon.

https://github.com/mozilla-services/android-sync/pull/156
https://github.com/mozilla-services/android-sync/pull/155

Comment 10

[Richard Newman [:rnewman]]

Pushed with review comments self-addressed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/3e5b3359a469

Comment 11

[Richard Newman [:rnewman]]

Attachment: Disabler.

Looks like the Fennec CP can be crashy. If that doesn't get resolved soon, here's a patch to disable password sync.

Comment 12

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/3e5b3359a469

Comment 13

[Richard Newman [:rnewman]]

Temporarily disabled until Bug 744816 is resolved.

https://hg.mozilla.org/integration/mozilla-inbound/rev/bbfe59782089

Comment 14

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/bbfe59782089

Comment 15

[Richard Newman [:rnewman]]

(In reply to Richard Newman [:rnewman] from comment #13)
> Temporarily disabled until Bug 744816 is resolved.
> 
> https://hg.mozilla.org/integration/mozilla-inbound/rev/bbfe59782089

This was re-enabled by

changeset:   91647:190a237b1456
user:        Nick Alexander <[e-mail]>
date:        Fri Apr 13 19:41:40 2012 -0700
summary:     Bug 739629 - Expose safe account creation API for profile migration. r=rnewman