711536 - finalize statements and close connection

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: finalize statements and close connection

https://tbpl.mozilla.org/?tree=Try&rev=5f8c44d410f4

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 582321 [details] [diff] [review]
finalize statements and close connection

Review of attachment 582321 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/downloads/nsDownloadManager.cpp
@@ +1954,5 @@
> +
> +    mGetIdsForURIStatement->Finalize();
> +    mUpdateDownloadStatement->Finalize();
> +    mozilla::DebugOnly<nsresult> rv = mDBConn->Close();
> +    MOZ_ASSERT(NS_SUCCEEDED(rv));

please just set the statements to nsnull and add the usual comment like // Null statements to finalize them.

apart that looks ok, it's a bit hard to figure out if someone is using the provided DBConnection for async work, I couldn't find any.

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=64a62ab8cf98

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/64a62ab8cf98

Comment 5

[Josh Matthews [:jdm]]

For reference, this was uplifted to Aurora (seemingly without any approval here?) in http://hg.mozilla.org/releases/mozilla-aurora/rev/64a62ab8cf98, and backed out to un-regress bug 713172 in http://hg.mozilla.org/releases/mozilla-aurora/rev/cd135c7ca5af.

Comment 6

[Marco Bonardo [:mak]]

(In reply to Josh Matthews [:jdm] from comment #5)
> For reference, this was uplifted to Aurora (seemingly without any approval
> here?)

IIRC it was just part of the merge from central to aurora on the merge day.

Btw, moving TM to 12