Pre-commit underline is not shown for the composing text

RESOLVED FIXED in Firefox 11

Status

()

Firefox for Android
General
P4
normal
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: nhirata, Assigned: alexp)

Tracking

unspecified
Firefox 12
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed, fennec11+)

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

1. go to http://people.mozilla.com/~nhirata/html_tp/formsninput.html
2. long tap in a text field and select simeji
3. click in a text field
4. type some japanese characters

Expected: underline underneath the Japanese character before committing
Actual: no underline.

used : fennec-11.0a1.en-US.android-arm_1324041795
on Samsung Galaxy S II Android OS 2.3
(Assignee)

Comment 1

6 years ago
With the bug 595008 fix the underline for the composing text is not displayed now regardless of the IME used. That's due to different handling of the IME events.
It is a step back compared to the previous implementation, but still on par with the stock browser, which does not show the underline either.
I am planning to look into this, but I believe it's not a high priority issue.
Assignee: nobody → alexp
Summary: Tinderbox build does not show the precommit underline when using simeji → Pre-commit underline is not shown for the composing text
Priority: -- → P4
tracking-fennec: --- → ?
We probably need this for CJK IMEs
tracking-fennec: ? → +
(Assignee)

Comment 3

5 years ago
Created attachment 588606 [details] [diff] [review]
WIP Patch

Implements the composition style handling. The patch needs a bit tweaking though to make sure everything works in all situations.
(Assignee)

Comment 4

5 years ago
Created attachment 589415 [details] [diff] [review]
Patch 2

Composition events are now issued more correctly, with the composing transaction kept open while the text is being edited.

setComposingRegion() still needs a better implementation.
Attachment #588606 - Attachment is obsolete: true
(Assignee)

Comment 5

5 years ago
Created attachment 590079 [details] [diff] [review]
WIP Patch 3

Added handling for setComposingRegion(), but this is really work-in-progress, which needs to be fixed, as it causes very weird behavior with SwiftKey X.
Attachment #589415 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #590079 - Attachment is obsolete: true
(Assignee)

Comment 6

5 years ago
Comment on attachment 589415 [details] [diff] [review]
Patch 2

The second version of the patch is probably the best way to go at the moment. It implements the most of the functionality without major side-effects.

The composition events are issued more or less correctly, the composing text style is handled in most cases, with pre-commit underline being displayed.

Later if needed I may have another approach to further improve this in a follow-up bug.
Attachment #589415 - Attachment description: WIP Patch 2 → Patch 2
Attachment #589415 - Attachment is obsolete: false
Attachment #589415 - Flags: review?(blassey.bugs)
Attachment #589415 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/c53d7932f6b7
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
(Assignee)

Comment 8

5 years ago
Comment on attachment 589415 [details] [diff] [review]
Patch 2

[Approval Request Comment]
Regression caused by (bug #): Bug 595008
User impact if declined: IME composition events are fired not quite correctly; Slower typing with VKB with extra selections of the text; No underline and special text style while typing with VKB, which is important especially for Japanese and similar languages.
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): Possible regressions for untested IMEs.
Attachment #589415 - Flags: approval-mozilla-aurora?

Comment 9

5 years ago
Comment on attachment 589415 [details] [diff] [review]
Patch 2

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #589415 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
tracking-fennec: + → 11+
(Assignee)

Updated

5 years ago
Blocks: 720333
https://hg.mozilla.org/releases/mozilla-aurora/rev/fa0ab73ef86f
status-firefox11: --- → fixed
status-firefox12: --- → fixed
Depends on: 743468
You need to log in before you can comment on or make changes to this bug.