1. go to http://people.mozilla.com/~nhirata/html_tp/formsninput.html 2. long tap in a text field and select simeji 3. click in a text field 4. type some japanese characters Expected: underline underneath the Japanese character before committing Actual: no underline. used : fennec-11.0a1.en-US.android-arm_1324041795 on Samsung Galaxy S II Android OS 2.3
With the bug 595008 fix the underline for the composing text is not displayed now regardless of the IME used. That's due to different handling of the IME events. It is a step back compared to the previous implementation, but still on par with the stock browser, which does not show the underline either. I am planning to look into this, but I believe it's not a high priority issue.
We probably need this for CJK IMEs
Created attachment 588606 [details] [diff] [review] WIP Patch Implements the composition style handling. The patch needs a bit tweaking though to make sure everything works in all situations.
Created attachment 589415 [details] [diff] [review] Patch 2 Composition events are now issued more correctly, with the composing transaction kept open while the text is being edited. setComposingRegion() still needs a better implementation.
Created attachment 590079 [details] [diff] [review] WIP Patch 3 Added handling for setComposingRegion(), but this is really work-in-progress, which needs to be fixed, as it causes very weird behavior with SwiftKey X.
Comment on attachment 589415 [details] [diff] [review] Patch 2 The second version of the patch is probably the best way to go at the moment. It implements the most of the functionality without major side-effects. The composition events are issued more or less correctly, the composing text style is handled in most cases, with pre-commit underline being displayed. Later if needed I may have another approach to further improve this in a follow-up bug.
Comment on attachment 589415 [details] [diff] [review] Patch 2 [Approval Request Comment] Regression caused by (bug #): Bug 595008 User impact if declined: IME composition events are fired not quite correctly; Slower typing with VKB with extra selections of the text; No underline and special text style while typing with VKB, which is important especially for Japanese and similar languages. Testing completed (on m-c, etc.): Risk to taking this patch (and alternatives if risky): Possible regressions for untested IMEs.
Comment on attachment 589415 [details] [diff] [review] Patch 2 [Triage Comment] Mobile only - approved for Aurora.