743468 - Entering accented characters on HKB causes mobile.twitter.com to eat subsequent input characters

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[Chris Peterson [:cpeterson]]

STR:
1. With a phone with HKB like the Droid Pro, log into http://mobile.twitter.com
2. In the "What's happening?" input form, type a couple 'a' characters. No problem.
3. Now press and hold the 'a' button for one second.
4. A popup menu of accented 'a' characters will open.
5. Choose any of the accented 'a' characters and it will be displayed in the text input box.
6. Now continue typing other characters.

AR:
Subsequent characters will overwrite the accented character in place.

ER:
Should be able to keep typing.

This bug affects HKB only. VKB works correctly.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

is this related to bug 695626?

Comment 2

[Johnathan Nightingale [:johnath]]

We'd like to know how widespread this is - does it affect other sites, or is twitter doing something unique with its text input boxes?

Comment 3

[Andreea Pod]

This is reproducible on other pages that have search fields like google.com or ask.com.
Build: Firefox 14.0a1 (2012-04-12)
Device: Motorola Droid Pro (Android 2.3.4)

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Any input text field.  http://people.mozilla.com/~nhirata/html_tp/formsninput.html  

This doesn't exhibit an issue using French IME with desktop Mac Firefox using the mobile UA.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

qawanted to see if this issue is unique to the droid pro

Comment 6

[Kevin Brosnan [Ex-Mozilla]]

Works for me using a G2/Desire Z using today's nightly. Leaving qawanted to get a Droid 2/3 or other HKB phone.

Comment 7

[Chris Peterson [:cpeterson]]

Accented characters work correctly in XUL Fennec on my Droid Pro, so this is a new issue for Native Fennec. I need to determine whether this is a regression.

Comment 8

[Adrian Tamas (:AdrianT)]

Tested on Motorola Droid 2 (Android 2.3.3) and HTC Desire Z (Android 2.3.3) on Nightly/14.0a1 2012-04-22.

I am seeing the behavior from Bug 747845 but also I can see that the accented character is overwritten by the next character typed and any new character typed replaces the character situated in that position. The user has to use backspace to erase the position in order to continue typing.

Comment 9

[Adrian Tamas (:AdrianT)]

On Nightly/12.0a1 2012-01-01 the issue is not reproducible. On Nightly/12.0a1 2012-01-31 the issue in reproducible. This is a regression.

Comment 10

[Chris Peterson [:cpeterson]]

I believe this regression started with Nightly 2012-01-21:

* 2012-01-01 = PASS
* 2012-01-15 = PASS
* 2012-01-19 = PASS
* 2012-01-20 = PASS
* 2012-01-21 = FAIL
* 2012-01-22 = FAIL
* 2012-01-23 = FAIL
* 2012-01-24 = FAIL
* 2012-01-26 = FAIL
* 2012-01-31 = FAIL

Comment 11

[Matt Brubeck (:mbrubeck)]

Regression range from 1/20 nightly to 1/21 nightly:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5c2bc94d359c&tochange=e46cca506613

Maybe a regression from bug 711648?

Comment 12

[Chris Peterson [:cpeterson]]

Yes, I believe this bug is a regression from changeset c53d7932f6b7 ("bug 711648 - Pre-commit underline is not shown for the composing text") related to caret position.

Comment 13

[Chris Peterson [:cpeterson]]

Attachment: bug-743468-end-ephemeral-composition-string.patch

If IME begins an ephemeral composition string, then end it when done.

Comment 14

[Chris Peterson [:cpeterson]]

Comment on attachment 618764 [details] [diff] [review]
bug-743468-end-ephemeral-composition-string.patch

[Approval Request Comment]
Regression caused by (bug #): bug 711648
User impact if declined: Fennec users with hardware keyboards will not be able to enter accented characters.
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): Java only. Unlikely risk could include text boxes getting into bad input state with some untested IME.
String changes made by this patch: N/A

Comment 15

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/620c80e2a024

Comment 16

[JP Rosevear [:jpr]]

Comment on attachment 618764 [details] [diff] [review]
bug-743468-end-ephemeral-composition-string.patch

Mobile only.

Comment 17

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6f99e37fc4c1

Comment 18

[Chris Peterson [:cpeterson]]

oops. I did not intend to change this bug's status/resolution or milestone. Fixing now.

Comment 19

[JP Rosevear [:jpr]]

Comment on attachment 618764 [details] [diff] [review]
bug-743468-end-ephemeral-composition-string.patch

Removing Aurora approval.  Please re-nom when the fall out is fixed.

Comment 20

[Adrian Tamas (:AdrianT)]

This is still an issue on Nightly 15.0a1 2012-05-18 and Aurora 14.0a2 2012-05-18 using both HTC Desire Z (Android 2.3.3) and Motorola Droid Pro (Android 2.3.4). Bug 756429 was logged for tracking the issue.

Comment 21

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 618764 [details] [diff] [review]
bug-743468-end-ephemeral-composition-string.patch

[Triage Comment]

Comment 22

[Chris Peterson [:cpeterson]]

Fixed by bug 751513:
https://hg.mozilla.org/releases/mozilla-beta/rev/da68f7ed63d5

Comment 23

[Paul Feher]

Verified fixed on Nightly 16.0a1 2012-06-27 and Aurora 15.0a2 2012-06-22 and Firefox Beta 14.0b8 2012-06-22 using HTC Desire Z (Android 2.3.3)