711995 - Favicons should be imported from Chrome

Status: VERIFIED FIXED

(Firefox :: Migration, enhancement)

Description

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (X11; Linux x86_64; rv:11.0a1) Gecko/20111208 Firefox/11.0a1

STR:
1. Erase or modify the Firefox folder.
2. Start Firefox.
3. Import from Chrome.

Actual result: favicons of bookmark and history pages are displayed with default favicon unless loading the respective pages.

Favicons are loaded correctly when importing in Chrome from Firefox.

Comment 1

[Makoto Kato [:m_kato]]

We need access Favions sqlite file on importing.

sqlite> .schema favicons
CREATE TABLE favicons(id INTEGER PRIMARY KEY,url LONGVARCHAR NOT NULL,last_updat
ed INTEGER DEFAULT 0,image_data BLOB,icon_type INTEGER DEFAULT 1, sizes LONGVARC
HAR);
CREATE INDEX favicons_url ON favicons(url);

Comment 2

[Asaf Romano (gone)]

See bug 326701 for the same enhancement request for the safari migrator.

Comment 3

[Seba S.]

Hi,

I could repro this issue on Nightly 77.0a1 Windows 10.

Regards,

Comment 7

[Bryan Macoy]

My doc contribution for this ticket:
https://docs.google.com/document/d/1U81uIPEZlY5KQavIb5sM6UM9nh1q41w_-wOIwOb_A1Q/edit#

Comment 8

[Raluca Popovici, Desktop QA]

This issue is also reproducible for import from Opera/Vivaldi browser on MacOS 11.6 and Win 10 using Nightly 109.0a1.

Comment 9

[Bryan Macoy]

Attachment: Bug 711995 - Favicons should be imported from Chrome.

Comment 10

[Bryan Macoy]

Attachment: WIP: Bug 711995 - Favicons should be imported from Chrome. R?mconley.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/695609b39bd2
Favicons should be imported from Chrome. r=mconley

Comment 12

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/695609b39bd2

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Did we want to call this and bug 326701 out in the Fx113 relnotes? Please nominate if so :)

Comment 14

[Mike Conley (:mconley) (:⚙️)]

Release Note Request (optional, but appreciated)
[Why is this notable]:

Users that import from a Chrome-based browser will find that most of their bookmark favicons should appear, rather than being the default globe favicon.

This is similar to bug 326701, which adds favicon import support to Safari.

[Affects Firefox for Android]:

No.

[Suggested wording]:

Importing bookmarks from Safari or a Chrome-based browser? The favicons for those bookmarks will now also be imported by default to make them easier to identify.

[Links (documentation, blog post, etc)]:

None.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Added to the 113 Nightly relnotes, thanks!

Comment 17

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified as part of QA-1784 that user bookmarks and favicons from Chrome-based browsers are successfully imported into Firefox Nightly 113.0a1 on the following operating systems and browsers:

• Windows 10x64: Edge, Edge Beta, Chrome, Chrome Beta, Chrome Canary, Chromium, Brave, Opera, OperaGX, Vivaldi, and 360 Secure Browser
• macOS 12: Edge, Edge Beta, Chrome, Chrome Canary, Chromium, Brave, Opera, OperaGX, and Vivaldi
• Ubuntu 20.04: Chrome, Chrome Dev, Chromium, Chrome Beta, Brave, Opera, Vivaldi.

During testing, we encountered bug 1825239 (S3) which is not considered a blocker for this implementation. More details can be found in Testrail Report.
We will leave this open until verification is performed on Firefox 113 beta as well.

Comment 18

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified as part of QA-1784 that user bookmarks and favicons from Chrome-based browsers are successfully imported into Firefox Beta 113.0bx on the following operating systems and browsers:

• Windows 11x64: Edge, Edge Beta, Chrome, Chrome Beta, Chrome Canary, Chromium, Brave, Opera, OperaGX, Vivaldi, and 360 Secure Browser
• macOS 12 arm: Edge, Edge Beta, Chrome, Chrome Canary, Chromium, Brave, Opera, OperaGX, and Vivaldi
• Ubuntu 22.04: Chrome, Chrome Dev, Chromium, Chrome Beta, Brave, Opera, Vivaldi.

Only bug 1825239 (S3) was encountered during testing. More details can be found in Testrail Report.