71206 - theme switching crash

Status: VERIFIED DUPLICATE of bug 71208

(SeaMonkey :: Themes, defect)

Description

[(not reading, please use [e-mail] instead)]

I crash when switching themes when I have just the mail window open.

I had it open to with "account central" showing.  It doesn't seem to happen with
when I've got a thread pane:

here's the stack trace:

#0  nsCSSFrameConstructor::ConstructXULFrame (this=0x827e848,
    aPresShell=0x827e8e0, aPresContext=0x8256cd0, aState=@0xbfffef00,
    aContent=0x86df838, aParentFrame=0x887fad8, aTag=0x81880b8,
    aNameSpaceID=6, aStyleContext=0x88a95a8, aFrameItems=@0xbfffe91c,
    aXBLBaseTag=0, aHaltProcessing=@0xbfffe648)
    at nsCSSFrameConstructor.cpp:5772
#1  0x412a998f in nsCSSFrameConstructor::ConstructFrameInternal (
    this=0x827e848, aPresShell=0x827e8e0, aPresContext=0x8256cd0,
    aState=@0xbfffef00, aContent=0x86df838, aParentFrame=0x887fad8,
    aTag=0x81880b8, aNameSpaceID=6, aStyleContext=0x88a95a8,
    aFrameItems=@0xbfffe91c, aXBLBaseTag=0) at nsCSSFrameConstructor.cpp:7137
#2  0x412a8eee in nsCSSFrameConstructor::ConstructFrame (this=0x827e848,
    aPresShell=0x827e8e0, aPresContext=0x8256cd0, aState=@0xbfffef00,
    aContent=0x86df838, aParentFrame=0x887fad8, aFrameItems=@0xbfffe91c)
    at nsCSSFrameConstructor.cpp:7036
#3  0x412bba50 in nsCSSFrameConstructor::ProcessChildren (this=0x827e848,
    aPresShell=0x827e8e0, aPresContext=0x8256cd0, aState=@0xbfffef00,
    aContent=0x86b39d0, aFrame=0x887fad8, aCanHaveGeneratedContent=0,
    aFrameItems=@0xbfffe91c, aParentIsBlock=0, aTableCreator=0x0)
    at nsCSSFrameConstructor.cpp:11157
#4  0x412a63c8 in nsCSSFrameConstructor::ConstructXULFrame (this=0x827e848,
    aPresShell=0x827e8e0, aPresContext=0x8256cd0, aState=@0xbfffef00,
    aContent=0x86b39d0, aParentFrame=0x861ec58, aTag=0x8189000,
    aNameSpaceID=6, aStyleContext=0x88a8c58, aFrameItems=@0xbfffee18,
    aXBLBaseTag=0, aHaltProcessing=@0xbfffeae8)
    at nsCSSFrameConstructor.cpp:5777
#5  0x412a998f in nsCSSFrameConstructor::ConstructFrameInternal (
    this=0x827e848, aPresShell=0x827e8e0, aPresContext=0x8256cd0,
    aState=@0xbfffef00, aContent=0x86b39d0, aParentFrame=0x861ec58,
    aTag=0x8189000, aNameSpaceID=6, aStyleContext=0x88a8c58,
    aFrameItems=@0xbfffee18, aXBLBaseTag=0) at nsCSSFrameConstructor.cpp:7137
#6  0x412a8eee in nsCSSFrameConstructor::ConstructFrame (this=0x827e848,
    aPresShell=0x827e8e0, aPresContext=0x8256cd0, aState=@0xbfffef00,
    aContent=0x86b39d0, aParentFrame=0x861ec58, aFrameItems=@0xbfffee18)
    at nsCSSFrameConstructor.cpp:7036
#7  0x412b0d28 in nsCSSFrameConstructor::ContentInserted (this=0x827e848,
    aPresContext=0x8256cd0, aContainer=0x8563448, aChild=0x86b39d0,
    aIndexInContainer=4, aFrameState=0x0) at nsCSSFrameConstructor.cpp:8523
#8  0x41475bb0 in StyleSetImpl::ContentInserted (this=0x827e758,
    aPresContext=0x8256cd0, aContainer=0x8563448, aChild=0x86b39d0,
    aIndexInContainer=4) at nsStyleSet.cpp:1223
#9  0x411749fa in PresShell::ContentInserted (this=0x827e8e0,
    aDocument=0x8256448, aContainer=0x8563448, aChild=0x86b39d0,
    aIndexInContainer=4) at nsPresShell.cpp:4335
#10 0x413cf268 in nsXBLStreamListener::Load (this=0x860c710, aEvent=0x83eaef4)
    at nsXBLService.cpp:164
#11 0x410fdaf8 in nsEventListenerManager::HandleEvent (this=0x86301a8,
    aPresContext=0x0, aEvent=0xbffff3ac, aDOMEvent=0xbffff378,
    aCurrentTarget=0x87e27a4, aFlags=7, aEventStatus=0xbffff3a8)
    at nsEventListenerManager.cpp:1381
#12 0x413fa6ae in nsDocument::HandleDOMEvent (this=0x87e2778,
    aPresContext=0x0, aEvent=0xbffff3ac, aDOMEvent=0x0, aFlags=1,
    aEventStatus=0xbffff3a8) at nsDocument.cpp:2782
#13 0x4133d8d0 in nsXMLDocument::EndLoad (this=0x87e2778)
    at nsXMLDocument.cpp:682
#14 0x41330d6e in nsXMLContentSink::DidBuildModel (this=0x89847c8,
    aQualityLevel=1) at nsXMLContentSink.cpp:288
#15 0x40d15891 in ?? ()
   from /builds/seth/outliner/mozilla/dist/bin/components/libhtmlpars.so
#16 0x40d097ec in ?? ()
   from /builds/seth/outliner/mozilla/dist/bin/components/libhtmlpars.so
#17 0x40d0a847 in ?? ()
   from /builds/seth/outliner/mozilla/dist/bin/components/libhtmlpars.so
#18 0x40d0b1e4 in ?? ()
   from /builds/seth/outliner/mozilla/dist/bin/components/libhtmlpars.so
#19 0x413cdf5f in nsXBLStreamListener::OnStopRequest (this=0x860c710,
    aChannel=0x8a52a28, aCtxt=0x0, aStatus=0, aStatusArg=0x4013de68)
    at nsXBLService.cpp:289
#20 0x40c08871 in ?? ()
   from /builds/seth/outliner/mozilla/dist/bin/components/libnecko.so
#21 0x40b913ec in ?? ()
   from /builds/seth/outliner/mozilla/dist/bin/components/libnecko.so
#22 0x40b90f69 in ?? ()
   from /builds/seth/outliner/mozilla/dist/bin/components/libnecko.so
#23 0x400f695e in ?? () from /builds/seth/outliner/mozilla/dist/bin/libxpcom.so
#24 0x400f67f9 in ?? () from /builds/seth/outliner/mozilla/dist/bin/libxpcom.so
#25 0x400f83fc in ?? () from /builds/seth/outliner/mozilla/dist/bin/libxpcom.so
#26 0x4068827f in ?? ()
   from /builds/seth/outliner/mozilla/dist/bin/components/libwidget_gtk.so
#27 0x40687f4d in ?? ()
   from /builds/seth/outliner/mozilla/dist/bin/components/libwidget_gtk.so
#28 0x4083f52a in ?? () from /usr/lib/libglib-1.2.so.0
#29 0x40840be6 in ?? () from /usr/lib/libglib-1.2.so.0
#30 0x408411a1 in ?? () from /usr/lib/libglib-1.2.so.0
#31 0x40841341 in ?? () from /usr/lib/libglib-1.2.so.0
#32 0x4076b209 in ?? () from /usr/lib/libgtk-1.2.so.0
#33 0x40688dcc in ?? ()
   from /builds/seth/outliner/mozilla/dist/bin/components/libwidget_gtk.so
#34 0x405a3195 in ?? ()
   from /builds/seth/outliner/mozilla/dist/bin/components/libnsappshell.so
#35 0x8051d7b in main1 (argc=4, argv=0xbffffa14, nativeApp=0x0)
    at nsAppRunner.cpp:978
#36 0x80529a6 in main (argc=4, argv=0xbffffa14) at nsAppRunner.cpp:1272

here's what I've done in my local tree, to prevent the crash:

Index: nsCSSFrameConstructor.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/html/style/src/nsCSSFrameConstructor.cpp,v
retrieving revision 1.555.2.2
diff -u -r1.555.2.2 nsCSSFrameConstructor.cpp
--- nsCSSFrameConstructor.cpp   2001/02/14 19:56:52     1.555.2.2
+++ nsCSSFrameConstructor.cpp   2001/03/07 20:21:12
@@ -5769,6 +5769,8 @@
       nsCOMPtr<nsIDocument> doc;
       aContent->GetDocument(*getter_AddRefs(doc));
       nsCOMPtr<nsIBindingManager> bindingManager;
+      NS_ASSERTON(doc, "no document, bailing out");
+      if (!doc) return NS_ERROR_FAILURE;
       doc->GetBindingManager(getter_AddRefs(bindingManager));
       if (processChildren) {
         bindingManager->ShouldBuildChildFrames(aContent, &processChildren);

with that patch, I don't crash, but the 3 pane window has lost the toolbar and
the account central page.

this was on the mailnews performance branch, so I'm keeping it low key (for now,
bhuvan and hyatt).

bhuvan, can you test this on the trunk, and if it crashes for you, try my patch,
and then find the proper owner for this bug?

Comment 1

[(not reading, please use [e-mail] instead)]

whoops, that should be NS_ASSERTION() not NS_ASSERTON().

also, with a thread pane, after as skin switch the menus won't come up anymore.

if none of this happens on the trunk, feel free to re-assign to me and I'll
re-investigate after we land on the trunk.

Comment 2

[(not reading, please use [e-mail] instead)]

you'll need this patch to prevent crashes for account central or thread pane.

with the patch, after the switch, the toolbar is gone.

Comment 3

[Scott MacGregor]

I think this bug is invalid. 

we don't support other themes with the outliner widget yet. Who knows what will
happen none of the rules are there!

Comment 4

[racham]

This one loks like more like a branch problem.

On testing with the trunk builds, I haven't noticed any crash. However, I
noticed AccountCentral page (when in that mode) as well as the messagepane
(iframe that displays message body) when in 3 pane mode going blank. Looks like
in the process of swithicng skins, all iframes are cleared. Is there a open bug
on that.

I have to mention that I didn't crash anywhere in the process and the toolbar is
right there. I heard that branch, for now, is supporting only modern skin. So,
as mentioned by Scott, we may encounter many problems on skin switch. So, at
this stage I think this bug is invalid. Seth ?

I am going to file a separate bug on blank iframes (atleast in the messenger app). 

Comment 5

[racham]

Bug 71236 now tracks the issue of blank iframes rendered on skin switch.

Comment 6

[(not reading, please use [e-mail] instead)]

this will crash (at least on linux), even if there is no outliner (using just
account central.)

I'll take the bug from racham, and keep it in mind for when we land.

as I've mentioned in other bugs, we have changes from jan varga on 2/24 for the
classic skin outliner.

Comment 7

[(not reading, please use [e-mail] instead)]

re-assign to hyatt.

this is a duplicate of one of his bugs.

Comment 8

[David Hyatt]

*** This bug has been marked as a duplicate of 71208 ***

Comment 9

[[e-mail] (gone - use [e-mail] instead)]

I had this same bug and already verified it in mail/news (when we landed the new
outliner coded).  Verified, fixed.