712120 - Graphite2 adds many compiler warnings

Status: RESOLVED WORKSFORME

(Core :: Layout: Text and Fonts, defect)

Description

[Gregory Szorc [:gps]]

When Graphite was enabled, it created a bunch of new compiler warnings:

http://jenkins.gregoryszorc.com:9000/job/mozilla-central/223/

This recorded 94 new compiler warnings on Windows.

Most of the errors look like:

  'gr_tag_to_str' : inconsistent dll linkage

or

  locally defined symbol _gr_face_find_fref imported in function "public: virtual bool __thiscall gfxGraphiteShaper::InitTextRun(class gfxContext *,class gfxTextRun *,wchar_t const *,unsigned int,unsigned int,int)" (?InitTextRun@gfxGraphiteShaper@@UAE_NPAVgfxContext@@PAVgfxTextRun@@PB_WIIH@Z)

See http://jenkins.gregoryszorc.com:9000/job/mozilla-central/223/warningsResult/new/? for the full list. I can't guarantee that site will be available forever. To reproduce in case it is gone, just compile on Windows and watch the output.

Comment 1

[Bernd]

http://msdn.microsoft.com/en-us/library/aa3se25k%28v=vs.80%29.aspx

Comment 4

[Jonathan Kew [:jfkthame]]

Closing this as WFM. We have taken numerous new graphite library versions since this was filed, and I don't see these warnings in current Windows build logs. Please re-open if I'm missing something and this is still an issue.