Closed Bug 712414 Opened 9 years ago Closed 9 years ago

Throbber does not stop after running on pages that use document.write without document.close

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 12
Tracking Status
firefox11 --- fixed
firefox12 --- fixed

People

(Reporter: nhirata, Assigned: mfinkle)

References

Details

Attachments

(1 file)

1. download the startup5.html
2. adb push startup5.html /sdcard/download
3. am start -a android.intent.action.VIEW -n org.mozilla.fennec/.App -d file://mnt/sdcard/download/startup5.html#63728494

Expected: throbber will stop at some point in time
Actual: the throbber keeps going

Note:
20111220 build
The build is wrong : http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/latest-mozilla-central-android-r7/

However, I cannot test to see if this still occurs because of : bug 712163 is blocking all s0/s1 testing.
Attached patch patchSplinter Review
The startup5.html file uses document.write() but never does a document.close() and I think we never get a DOCUMENT stop notificiation.

This patch switches Fennec to use NETWORK start and stop instead of DOCUMENT start and stop. Desktop Firefox also uses NETWORK:
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#4547
Assignee: nobody → mark.finkle
Attachment #583508 - Flags: review?(mbrubeck)
Attachment #583508 - Flags: review?(mbrubeck) → review+
Summary: Throbber does not stop after running the s0/s1 (onload local/twitter local) test pages. → Throbber does not stop after running on pages that use document.write without document.close
Whiteboard: [fennec-aurora]
https://hg.mozilla.org/mozilla-central/rev/c82245ed1e82
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Why has Fennec decided to differ from Firefox here?  Firefox leaves the throbber spinning; see bug 81980.  (And see bug 605937...)
(In reply to Jesse Ruderman from comment #5)
> Why has Fennec decided to differ from Firefox here?  Firefox leaves the
> throbber spinning; see bug 81980.  (And see bug 605937...)

Jesse - ironically, we wanted to match how desktop Firefox handled the page in question.
Verified fixed on Native Fennec 12.0a1 build 20120104031035.
Status: RESOLVED → VERIFIED
Comment on attachment 583508 [details] [diff] [review]
patch

[Approval Request Comment]
We want this behavior so we don't appear to be taking forever to load
Attachment #583508 - Flags: approval-mozilla-aurora?
Whiteboard: [fennec-aurora]
Comment on attachment 583508 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #583508 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.