712421 - allow pasting a URL in the download manager window to download it

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Apparently Safari has this feature. It seems neat.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

This works. There may be an more elegant way to hook into "paste", though.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 4

[[e-mail]]

Comment on attachment 583291 [details] [diff] [review]
patch

Sorry for the delay in getting around to reviewing this.

>+  try {
>+    trans.getAnyTransferData(type, data, {});
>+    if (flavors.indexOf(type.value) == -1)
Transferables can only ever return flavours that you added to them, so this check is entirely unnecessary.

>+    [url, name] = data.value.QueryInterface(Ci.nsISupportsString).data.split("\n");
>+  } catch (ex) {}
Separate try/catch blocks are preventing you from declaring your variables here (and even I wouldn't use var as a workaround). I don't see any downside to having one catch to rule them all.

>+    <key id="pasteKey"
>+         key="V"
>+         modifiers="accel"
>+         oncommand="pasteHandler();"/>
I can't remember whether this will conflict with the search textbox (I assume here that you want Accel+V to have its usual effect there) and SeaMonkey's download manager uses a proper command controller which definitely won't conflict with the textbox so I can give you f+ but not r+.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

I tested - the <key> doesn't interfere with pasting in the text box.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/546e69d2fe66

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/546e69d2fe66

Comment 8

[Loic]

*ROFL*
See Bug 506881, 3-year duplicate closed as WONTFIX.
Anyway this 'trick' is practical, great to see it added.

Just a question: 
- pasting an URL in the download manager is allowed,
- dragging & dropping an element of a webpage into the download manager is allowed,
Why dragging & dropping directly an URL from the location bar into the download manager is not allowed?

May I fill a bug for that?

Comment 9

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

(In reply to Loic from comment #8)
> *ROFL*
> See Bug 506881, 3-year duplicate closed as WONTFIX.

These things happen.

> Why dragging & dropping directly an URL from the location bar into the
> download manager is not allowed?
> 
> May I fill a bug for that?

Please do. And if you want to write the patch... :)

Comment 10

[Loic]

(In reply to Paul O'Shannessy [:zpao] from comment #9)
> (In reply to Loic from comment #8)
> > May I fill a bug for that?
> 
> Please do. And if you want to write the patch... :)

Filled Bug 722670.