Closed
Bug 713445
Opened 14 years ago
Closed 14 years ago
[Mac Default] tabbrowser tab title text styling is wrong in Lion
Categories
(SeaMonkey :: Themes, defect)
Tracking
(seamonkey2.8 fixed)
RESOLVED
FIXED
seamonkey2.9
| Tracking | Status | |
|---|---|---|
| seamonkey2.8 | --- | fixed |
People
(Reporter: stefanh, Assigned: stefanh)
Details
(Keywords: regression)
Attachments
(1 file)
|
745 bytes,
patch
|
mnyromyr
:
review+
iannbugzilla
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
On Lion, text in native tabs turns white on selection. Also, a text-shadow is applied. This comes from toolkit/themes/pinstripe/global/tabbox.css:
48
49 @media (-moz-mac-lion-theme) {
50 tab[selected="true"] {
51 color: #FFF;
52 text-shadow: rgba(0, 0, 0, 0.4) 0 1px;
53 }
54 }
This makes our tabbrowser tabs look really bad when you select them. We need to override these rules.
|
Assignee | |
Comment 1•14 years ago
|
||
I just added some overrides to the existing selector instead of adding a new just for Lion.
|
|
Assignee | |
Comment 2•14 years ago
|
||
Oh, and this happens of course with bottom tabs as well. That's a toolkit issue, though (will file a bug for that).
|
|
Assignee | |
Comment 3•14 years ago
|
||
This was caused by bug 681425 (fixed for Firefox 11), so we'll need this for comm-aurora.
tracking-seamonkey2.8:
--- → ?
Keywords: regression
|
|
Assignee | |
Comment 4•14 years ago
|
||
(In reply to Stefan [:stefanh] from comment #2)
> Oh, and this happens of course with bottom tabs as well. That's a toolkit
> issue, though (will file a bug for that).
Bug 713446.
|
||
Comment 5•14 years ago
|
||
Comment on attachment 584263 [details] [diff] [review]
v1.0
Note: Since I'm on 10.6.8 still, I commented out the Lion media designator to test this.
Attachment #584263 -
Flags: review?(mnyromyr) → review+
|
|
Assignee | |
Comment 6•14 years ago
|
||
Comment on attachment 584263 [details] [diff] [review]
v1.0
This is very safe and it fixes a highly visible regression (looks quite bad).
Attachment #584263 -
Flags: approval-comm-aurora?
|
|
Assignee | |
Comment 7•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.9
Comment on attachment 584263 [details] [diff] [review]
v1.0
a=me for c-a
Attachment #584263 -
Flags: approval-comm-aurora? → approval-comm-aurora+
|
|
Assignee | |
Comment 9•14 years ago
|
||
(In reply to Ian Neal from comment #8)
> Comment on attachment 584263 [details] [diff] [review]
> v1.0
>
> a=me for c-a
Thanks, will try and land this tomorrow.
|
|
Assignee | |
Comment 10•14 years ago
|
||
status-seamonkey2.8:
--- → fixed
tracking-seamonkey2.8:
? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•