715559 - Remove Windows CE support, in LDAP C-SDK

Status: RESOLVED FIXED

(Directory :: LDAP C SDK, defect)

Description

[Serge Gautherie (:sgautherie)]

"Found 8 matching lines in 3 files"

Unless you do want to keep this support (ftb).

Comment 1

[James Napolitano]

Attachment: remove WinCE build support for LDAP, v1

Serge, could you take a look and see if this patch is basically correct? This is essentially a first patch for me. I know this bug is unconfirmed, but it seemed simple enough to learn the ropes with.

I can't really test my patch myself due to an unrelated TB build error I suddenly started getting (something about the idl-parser erroring out on some DOM event interface). What command(s) can I use to build just the LDAP C-SDK?

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 607020 [details] [diff] [review]
remove WinCE build support for LDAP, v1

(In reply to James Napolitano from comment #1)

> Serge, could you take a look and see if this patch is basically correct?

Exactly what I expected, by code inspection :-)

> What command(s) can I use to build just the LDAP C-SDK?

I have no idea.

Comment 3

[Kathleen :Brade]

Comment on attachment 607020 [details] [diff] [review]
remove WinCE build support for LDAP, v1

These changes look fine.

Comment 4

[Mark Smith [:mcs]]

Comment on attachment 607020 [details] [diff] [review]
remove WinCE build support for LDAP, v1

These changes are fine (sorry about the extra bug traffic; that's what happens when you use your colleague's computer without checking who you are logged into in Bugzilla).

Comment 5

[Serge Gautherie (:sgautherie)]

See
https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Comment 6

[James Napolitano]

Attachment: remove WinCE build support for LDAP, v2

ready for checkin

Comment 7

[James Napolitano]

(In reply to Serge Gautherie (:sgautherie) from comment #5)
> See
> https://developer.mozilla.org/en/
> Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-
> in_for_me.3F

Ah thanks. I wasn't going to request review until I had time to sort out my (unrelated) Gecko build error. What would be a good place I could ask for help with that (irc, a newsgroup, etc.)? Also, do I have to sign some Mozilla contributer agreement?

(In reply to Mark Smith from comment #4)
> Comment on attachment 607020 [details] [diff] [review]
> remove WinCE build support for LDAP, v1
> 
> These changes are fine (sorry about the extra bug traffic; that's what
> happens when you use your colleague's computer without checking who you are
> logged into in Bugzilla).

That's fine, though at first it made me think my simple patch caused some kind of controversy ;). I was thinking of doing bug 458660 and bug 616066 next, when I have some time. Does that sound good to you?

First, for working on the LDAP C-SDK, I had some questions: what command(s) can I use to just build the C-SDK (instead of having to buld an entire comm-central app)? I looked at https://wiki.mozilla.org/LDAP_C_SDK, but I wasn't clear which build configuration/options to use, and the page seems to be old and still uses cvs.

Also, I suppose I should develop against the tip of http://hg.mozilla.org/projects/ldap-sdks/, rather than the tagged version that comm-central pulls? Is this correct?

Comment 8

[James Napolitano]

(In reply to James Napolitano from comment #7)
> What would be a good place I could ask for
> help with that (irc, a newsgroup, etc.)?

Nevermind, I found the mozilla.dev.builds newsgroup.

Can one of you two do the checkin for me?

Comment 9

[Mark Banner (:standard8)]

Checked in:

http://hg.mozilla.org/projects/ldap-sdks/rev/673c71519674

(In reply to James Napolitano from comment #7)
> Also, I suppose I should develop against the tip of
> http://hg.mozilla.org/projects/ldap-sdks/, rather than the tagged version
> that comm-central pulls? Is this correct?

Generally comm-central pulls something similar to the default tip, however it is generally best to run against default (you can pass an argument into client.py to do this).

Comment 10

[Serge Gautherie (:sgautherie)]

(In reply to James Napolitano from comment #1)
> I can't really test my patch myself due to an unrelated TB build error I
> suddenly started getting (something about the idl-parser erroring out on
> some DOM event interface).

Try to clobber your obj dir: something like this happened on some tinderboxes recently...


(In reply to James Napolitano from comment #7)
> Also, do I have to sign some Mozilla contributer agreement?

Not mandatory, but you probably should at some point.

> I was thinking of doing bug 458660 and bug 616066
> next, when I have some time. Does that sound good to you?

Sure.

> First, for working on the LDAP C-SDK, I had some questions: what command(s)
> can I use to just build the C-SDK (instead of having to buld an entire
> comm-central app)? I looked at https://wiki.mozilla.org/LDAP_C_SDK, but I
> wasn't clear which build configuration/options to use, and the page seems to
> be old and still uses cvs.

As you already have the comm-central source, you should manage to build just the LDAP part rather than Thunderbird for example.

> Also, I suppose I should develop against the tip of
> http://hg.mozilla.org/projects/ldap-sdks/, rather than the tagged version
> that comm-central pulls? Is this correct?

Exact.


(In reply to James Napolitano from comment #8)
> Nevermind, I found the mozilla.dev.builds newsgroup.

Or try irc: #developers or #maildev channels.