Flash app restarts after clicking a selection when click to play is turned on

VERIFIED FIXED

Status

()

Firefox for Android
General
VERIFIED FIXED
6 years ago
11 months ago

People

(Reporter: nhirata, Assigned: Margaret)

Tracking

12 Branch
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed)

Details

(URL)

Attachments

(2 attachments)

Created attachment 586275 [details]
logcat.txt

1. go to menu -> more -> settings -> enable plugins -> Click to play
2. hit the back button and go to : https://settings.adobe.com
3. click on where it states "Tap here to activate plugins"
4. select Local Storage

Expected: flash will continue on with the app
Actual: flash app restarts

Note:
1. Samsung Nexus S, 2.3.1, flash 11, 20120105 build
2. also the flash plugin will continue to the next screen if yes was selected for the enable plugins option.
(Assignee)

Comment 1

6 years ago
This feels like a problem with the flash settings app. Possibly a dupe of bug 694546?
It's talking about the same portion, but I don't believe it's the same bug.  In the bug 694546 it's stating that it doesn't work at all.  I believe that it does work, but not when "Click to play" is enabled.
(Assignee)

Comment 3

6 years ago
With click to play enabled, I can tap to activate the plugin, but I run into problems when I try to select local storage like you say in comment 0. Does the app work correctly if you just have enable plugins set to "yes"?
Yes, the app seems to work correctly if I just enable the plugins to yes and then restart fennec.
(Assignee)

Comment 5

6 years ago
Okay, I'm seeing the same thing. I just discovered if I hit the back button after going to the busted local storage page, then click on local storage again it works. Maybe there's a problem with the order in which we're loading the plugins on the page?
Oh interesting.  Is there a way to test order of load easier?
(Assignee)

Comment 7

6 years ago
(In reply to Naoki Hirata :nhirata from comment #6)
> Oh interesting.  Is there a way to test order of load easier?

Actually, I think this problem is caused by the same root issue that's causing bug 713080 - we're re-loading all the plugins when the plugin objects are tapped, even after they're loaded. I'm working on a patch now that will hopefully fix both these bugs.
Assignee: nobody → margaret.leibovic
(Assignee)

Comment 8

6 years ago
Created attachment 586506 [details] [diff] [review]
patch

We were reloading the plugins every time the plugin object received a click event. Since we're playing all plugins when one is clicked, it's kind of tricky to remove the click event listeners, so I decided to just clear _pluginsToPlay and check its length when playAllPlugins gets called.

I also decided to get rid of the addPluginClickCallback I mostly stole from desktop, since we don't need that generic helper function, and I just replaced it with a normal click listener.

I think this will fix bug 713080 and bug 694546 as well. (I was hoping it would also fix bug 715740, but that doesn't seem to be the case.)
Attachment #586506 - Flags: review?(mark.finkle)
Comment on attachment 586506 [details] [diff] [review]
patch

Test switching between tabs with Flash to make sure we don't lose plugin info
Attachment #586506 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 10

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5971546ca35e
(Assignee)

Updated

6 years ago
Duplicate of this bug: 713080
(Assignee)

Comment 12

6 years ago
This never got marked as fixed, but it made its way into mozilla-central:

https://hg.mozilla.org/mozilla-central/rev/5971546ca35e
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Comment 13

6 years ago
Comment on attachment 586506 [details] [diff] [review]
patch

[Approval Request Comment]
User impact if declined: interactive flash objects (like embedded youtube videos) won't work
Testing completed (on m-c, etc.): baked on m-c for a few days
Attachment #586506 - Flags: approval-mozilla-aurora?
Comment on attachment 586506 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #586506 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 15

6 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/6470d94a3cac
status-firefox11: --- → fixed
status-firefox12: --- → fixed
tracking-firefox11: --- → ?
(Assignee)

Updated

6 years ago
tracking-fennec: --- → ?
tracking-firefox11: ? → ---
Verified fixed on:

Mozilla/5.0 (Android;Linux armv7l;rv:11.0a2)Gecko/20120130
Firefox/11.0a2 Fennec/11.0a2
Device: Samsung Galaxy S
OS: Android 2.2

Mozilla/5.0 (Android;Linux armv7l;rv:12.0a1)Gecko/20120130
Firefox/12.0a1 Fennec/12.0a1
Device: Samsung Galaxy S
OS: Android 2.2
Status: RESOLVED → VERIFIED
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.