715876 - Allow x64 builds to use the Mozilla Maintenance Service and verify MARs

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Brian R. Bondy [:bbondy]]

There is only one service across all channels and build types.  Currently if a build being used is a native x64 build then we neither install nor use an installed service for updates.

x64 service builds were disabled to simply testing and development of the initial landing of the service.  In particular the work for testing would have increased by a factor of 2.   We would have to test things like having an x64 service upgrading an x86 process and having an x86 service upgrading an x64 process.

This task is to enable x64 builds, test it, and fix problems if any exist.

Comment 4

[Brian R. Bondy [:bbondy]]

The only thing really blocking this work is 1) signing the x64 Windows files, and 2) Signing the x64 MAR files.

I think #2 should be trivial since it uses our own signing mechanism. But I'm not sure about #1.

Comment 5

[Brian R. Bondy [:bbondy]]

The bulk of the work was done in bug 1025640.

All that remains for this bug is to pref on using the service by default on x64.
We can't do that until we have signatures on the x64 binaries though.

Comment 6

[Brian R. Bondy [:bbondy]]

Attachment: Patch rev1.

Comment 7

[Brian R. Bondy [:bbondy]]

Attachment: rev1'

Same as before but cleans up the diff a bit more by not re-ordering the conditions.

Comment 9

[Brian R. Bondy [:bbondy]]

- Update Firefox-x64 with Maintenance service disabled
- Update Firefox-x64 with Maintenance service-x86, check logs, make sure they look ok w/o warnings
- Update Firefox-x86 with Maintenance service-x86, check logs, make sure they look ok w/o warnings
- Update Firefox-x64 with Maintenance service-x64, check logs, make sure they look ok w/o warnings
- Update Firefox-x86 with Maintenance service-x64, check logs, make sure they look ok w/o warnings

Note that rstrong mentioned that when he was testing a replace request failed once (but I assume the fallback succeeded).

I did reproduce this once, but it ended up being my fault. I had the folder open in explorer. I assume something like this was also the case before.

Re-testing with it closed worked fine w/ neither errors nor warnings.

Everything looks good with testing on Oak, going ahead with landing.

Comment 10

[Robert Strong (they/them - no direct email)]

Yay!

Comment 11

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5fc6e12c048b

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5fc6e12c048b

Comment 13

[Steffen Wilberg]

Could you please update
https://wiki.mozilla.org/Windows_Service_Silent_Update#A_single_service_and_service_versioning ?

"If the user is running on an x64 computer with a native x64 build, then the service will not be installed nor used by that build. If the user is on an x64 computer with an x86 build, then the service will be used and installed by the build as an x86 process. Future versions of Firefox will support native x64 builds with the service. Work is being tracked for native x64 builds in Bug 715876."

Comment 14

[Brian R. Bondy [:bbondy]]

Indeed that's old info, thanks for the heads up. I'll modify it.

Comment 15

[Brian R. Bondy [:bbondy]]

updated.