71625 - Getting oldemailtech notifications

Status: VERIFIED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Mike Shaver (:shaver emeritus)]

When [e-mail] added himself to the CC list on 71623, I got an old-style
bugmail notification.  According to the database, I have newemailtech turned on,
and so does [e-mail].

My email flags are:

ExcludeSelf~on~emailOwnerRemoveme~on~emailOwnerComments~on~emailOwnerAttachments~on~emailOwnerStatus~on~emailOwnerResolved~on~emailOwnerKeywords~~emailOwnerCC~~emailOwnerOther~on~emailReporterRemoveme~on~emailReporterComments~on~emailReporterAttachments~on~emailReporterStatus~on~emailReporterResolved~on~emailReporterKeywords~on~emailReporterCC~~emailReporterOther~on~emailQAcontactRemoveme~on~emailQAcontactComments~on~emailQAcontactAttachments~on~emailQAcontactStatus~on~emailQAcontactResolved~~emailQAcontactKeywords~on~emailQAcontactCC~~emailQAcontactOther~on~emailCClistRemoveme~~emailCClistComments~on~emailCClistAttachments~on~emailCClistStatus~on~emailCClistResolved~on~emailCClistKeywords~~emailCClistCC~~emailCClistOther~

Håkan's are:

ExcludeSelf~on~emailOwnerRemoveme~on~emailOwnerComments~on~emailOwnerAttachments~on~emailOwnerStatus~on~emailOwnerResolved~on~emailOwnerKeywords~on~emailOwnerCC~~emailOwnerOther~on~emailReporterRemoveme~on~emailReporterComments~on~emailReporterAttachments~on~emailReporterStatus~on~emailReporterResolved~on~emailReporterKeywords~on~emailReporterCC~~emailReporterOther~on~emailQAcontactRemoveme~on~emailQAcontactComments~on~emailQAcontactAttachments~on~emailQAcontactStatus~on~emailQAcontactResolved~on~emailQAcontactKeywords~on~emailQAcontactCC~~emailQAcontactOther~on~emailCClistRemoveme~on~emailCClistComments~on~emailCClistAttachments~on~emailCClistStatus~~emailCClistResolved~on~emailCClistKeywords~~emailCClistCC~~emailCClistOther~

Help?

Comment 1

[Jacob Steenhagen]

I've also recieved some oldmail notifications...  so far they've all come on bug
43647... a bug that I voted on.

Comment 2

[Jacob Steenhagen]

Just got another one for bug 18729... the CC in the mail header was almost
identical to the "voted on this bug" list.

Comment 3

[Jacob Steenhagen]

Testing a theory...

Comment 4

[Jacob Steenhagen]

The current hole in this theory is that bug 71623 doesn't have an votes...

Comment 5

[Dave Miller [:justdave]]

OK, we've positively identified that if you vote on a bug and have no other 
relationship with that bug that you get an oldemailtech notification when that 
bug changes.

There is apparenlty at least one other situation in which the user will get an 
oldemailtech notification that we haven't nailed down yet.

Comment 6

[Dave Miller [:justdave]]

This is a 2.12 blocker (failed regression test)

Comment 7

[Dawn Endico]

In case you're confused about why you got a mail in the first place, Asa
informs me that in the past bugzilla's behaviour has been that voting for
a bug is the same as being cc'd. I guess that's a feature, not a bug.

Comment 8

[Stephan Niemz]

Yes, it is a feature that voters also get bugmails.  It's kind of a "Bcc".

Anyway, from
http://lxr.mozilla.org/mozilla/source/webtools/bugzilla/processmail#987 :

# Make sure that everyone who was excluded because of the advanced
# filtering options (and thus are using new email tech) has the
# corresponding element in %seen set.  This is so that they won't
# also be processed by the old email tech code, which follows.

    But the voters aren't included in @excludedAddresses, so if they
aren't on the Cc list or so, they get an old tech email.  Patch is
attached, but I haven't tested it despite running perl -cw on it.

Comment 9

[Stephan Niemz]

Attachment: patch (diff -ubB == no whitespace change)

Comment 10

[Stephan Niemz]

Attachment: patch (diff -u, i.e. also removing unnecessary whitespace at line endings)

Comment 11

[Stephan Niemz]

I've just tested this patch on my local installation, and it works: I'm
getting an old tech bugmail without it and a new one with the patch.

Comment 12

[Stephan Niemz]

This is strange ... I got an old tech mail for bug 22687, although I didn't
vote for it, I'm just on the Cc list.  Someone added himself to the Cc list,
but besiedes that, the email notifys me of Matty's change of email address in
the comments section.  Attaching that email.

Comment 13

[Stephan Niemz]

Attachment: bogus old tech email

Comment 14

[Jacob Steenhagen]

We know there are at least two ways to get the oldmail notification... one of
which is voting on a bug.  The second one hasn't been tracked down yet.  Have
you changed your e-mail prefs at all?  Would it be possible for you to attach
your edit prefs page like Peter did in bug 72144?

Comment 15

[Stephan Niemz]

I have everything checked except "Do not email me bugs that I change" (see bug
72177) and I'm watching two people, Dave and Tara.

Could it be that if only *someone* votes for a bug without having another
relationship to the bug, an old tech mail is sent out to *everyone* on the
bug?  Above mentioned bug 22687 has many votes, that's why I'm guessing this.

Comment 16

[Jacob Steenhagen]

> Could it be that if only *someone* votes for a bug without having another

I really don't think so... This was first reported with bug 71623 which has no
votes at all.  Also, when looking at the CC: Header in the notification's I've
recieved, everyone listed on that line had also voted for the bug (there were a
couple missing who had also been CC'd, were the reporter, etc.).

Comment 17

[Jacob Steenhagen]

*** Bug 72404 has been marked as a duplicate of this bug. ***

Comment 18

[Jacob Steenhagen]

http://bugzilla.mozilla.org/showattachment.cgi?attach_id=27799
^^^ The biggest problem I see w/this patch is that it has no filtering at all. 
Perhaps the better solution is to treat a vote as a CC until bug 71808 is fixed
(but that's debatable).

Getting this known instance fixed would help track down what the unknown is.

Comment 19

[Jacob Steenhagen]

OK, I've just put a patch on bug 71808 which takes care of the voting half of
this bug.  It also impliments filtering prefs for it (since that's what bug
71808 is all about :)

Comment 20

[Dave Miller [:justdave]]

As noted, bug 71808 has been checked in, which should plug the hole for voters 
getting oldemailtech.

Dawn, drop a line here when you get b.m.o updated so people can start watching 
for other patterns in oldemailtech notifications.

Comment 21

[Dave Miller [:justdave]]

OK, bugzilla.mozilla.org has been updated to include the fix for voter 
notification in bug 71808.  If any of you get any old email tech again please 
note it here.  If nobody says anything in a week, I'm gonna close this, in the 
interest of getting 2.12 out the door.  So please try to break it ;)

Comment 22

[Dave Miller [:justdave]]

OK, per my previous comment (it's been almost a week), I'm going to assume this 
is fixed.  If anyone manages to reproduce this again, please reopen it.

Comment 23

[Jacob Steenhagen]

Marking this VERIFIED as I haven't seen any oldmail stuff in since this went in.

Comment 24

[Dave Miller [:justdave]]

Moving closed bugs to Bugzilla product