716334 - Slow Titlebar/Toolbar rendering when creating a new window

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Mehmet]

Attachment: four_screenshots.pdf

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_8) AppleWebKit/534.52.7 (KHTML, like Gecko) Version/5.1.2 Safari/534.52.7

Steps to reproduce:

Mac OS 10.6.8
Nightly: 12.0a1 (2012-01-07)

1) open single window
2) set in preferences 'when Nightliy starts: show my homepage' (e.g. www.google.com)
3) press fast CMD-T to open a new window


Actual results:

first the titlebar is shown and then the toolbar is shown


Expected results:

Titlebar and toolbar should be shown at the same time


***A PDF-file with four screenshots is attached***

Comment 1

[Mehmet]

sorry I mean in step 3: press >>> CMD-N  <<<

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Also happens on Windows, as mentioned in bug 720020

Comment 4

[Dão Gottwald [:dao]]

I can't reproduce this (on Windows 7).

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I can. Anything I can do to help debug it?

Comment 6

[Alex Keybl [:akeybl]]

Tracking for 12, although I was able to reproduce the titlebar being rendered separately from the toolbar in FF10 on OS X. Presumably this bug is tracking a significant slowdown in the rendering though.

Comment 7

[Alex Keybl [:akeybl]]

https://wiki.mozilla.org/Modules/All doesn't list a module owner for Themes. Who's in the best position to drive this investigation from the engineering side?

Comment 8

[Dão Gottwald [:dao]]

I don't think this depends on the "always show the tab bar" pref.

Comment 9

[Dão Gottwald [:dao]]

Attachment: patch

I think this helps... the tab container constructor runs before the load handler, so bug 618770 caused syncUI to run earlier.

Comment 10

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 603391 [details] [diff] [review]
patch

This fixes the bug for me, at least as originally reported in bug 720020 on the profile that I could reproduce the problem.

I see a different thing now: I don't see a first step with glass, but I see the browser window rendered before session store kicks in (i.e. with a blank tab at first). However, AFAICT this still happens without this patch on other profiles where I could not reproduce the bug. It seems that it's a different bug that was mitigated by this one? (as the first render of the browser was later, the initial image that I saw already had my app tabs restored)

Comment 11

[Dão Gottwald [:dao]]

(In reply to Felipe Gomes (:felipe) from comment #10)
> I see a different thing now: I don't see a first step with glass, but I see
> the browser window rendered before session store kicks in (i.e. with a blank
> tab at first). However, AFAICT this still happens without this patch on
> other profiles where I could not reproduce the bug. It seems that it's a
> different bug that was mitigated by this one? (as the first render of the
> browser was later, the initial image that I saw already had my app tabs
> restored)

attachment 511080 [details] [diff] [review] did this, as far as I remember.

Comment 12

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/120c201a6644

Comment 13

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/120c201a6644

Comment 14

[Alex Keybl [:akeybl]]

Comment on attachment 603391 [details] [diff] [review]
patch

[Triage Comment]
From reading the patch, this is low risk. It's also had a couple of days of bake time. Let's land on Aurora 12.

Comment 15

[Bill Gianopoulos [:WG9s]]

This has caused a serious regression under Linux.  (see bug 734273) I don't think landing on Aurora is very good idea.

Comment 16

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-aurora/rev/e824347e2dbb

Comment 17

[Stefan Plewako [:stef]]

(In reply to Bill Gianopoulos [:WG9s] from comment #15)
> This has caused a serious regression under Linux.  (see bug 734273) I don't
> think landing on Aurora is very good idea.

also on mac - bug 734836

Comment 18

[:Gavin Sharp [email: [e-mail]]]

(In reply to Alex Keybl [:akeybl] from comment #7)
> https://wiki.mozilla.org/Modules/All doesn't list a module owner for Themes.

"themes" are largely app-specific - the relevant module in this case is "Firefox".

Comment 19

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20100101 Firefox/12.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:12.0) Gecko/20100101 Firefox/12.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20100101 Firefox/12.0

Verified in Firefox 12 beta 4. No display issue spotted now when opening new windows. Toolbar is rendered as normal.