Port |Bug 717491 - "Warning: package error or possible missing or unnecessary file: bin/components/proxyObject.xpt (package-manifest, 151)."| to SeaMonkey

VERIFIED FIXED in Thunderbird 12.0

Status

MailNews Core
Build Config
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: sgautherie, Assigned: ewong)

Tracking

Trunk
Thunderbird 12.0
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

6 years ago
http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTrunk/1326326911.1326333403.13717.gz&fulltext=1
Linux comm-central build on 2012/01/11 16:08:31
{
Warning: package error or possible missing or unnecessary file: bin/components/proxyObject.xpt (package-manifest, 459).
}

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1326320185.1326332179.11070.gz&fulltext=1
OS X 10.5 comm-central-trunk leak test build on 2012/01/11 14:16:25
No bug :-|

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1326323109.1326333321.13646.gz&fulltext=1
OS X 10.6 comm-central-trunk nightly on 2012/01/11 15:05:09
{
Warning: package error or possible missing or unnecessary file: SeaMonkey.app/Contents/MacOS/components/proxyObject.xpt (package-manifest, 159).
}

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1326320049.1326330699.7951.gz&fulltext=1
WINNT 5.2 comm-central-trunk build on 2012/01/11 14:14:09
{
Warning: package error or possible missing or unnecessary file: bin/components/proxyObject.xpt (package-manifest, 167).
}
Flags: in-testsuite-
(Assignee)

Comment 1

6 years ago
Created attachment 589390 [details] [diff] [review]
Removed bin/components/proxyObject.xpt.
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #589390 - Flags: review?(bugspam.Callek)
(Reporter)

Updated

6 years ago
Attachment #589390 - Flags: feedback+
Comment on attachment 589390 [details] [diff] [review]
Removed bin/components/proxyObject.xpt.

While here, lets remove mail's and calendar's packaging of this file as well...
Attachment #589390 - Flags: review?(bugspam.Callek) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 589411 [details] [diff] [review]
Removed bin/components/proxyObject.xpt. (v2)
Attachment #589390 - Attachment is obsolete: true
Attachment #589411 - Flags: review?(bugspam.Callek)
(Reporter)

Comment 4

6 years ago
Comment on attachment 589411 [details] [diff] [review]
Removed bin/components/proxyObject.xpt. (v2)

package-manifest.in:
I would assume Callek's r+ can be forwarded.

removed-files.in:
I'm sure SM and TB want to keep it, I assume the same is true for Calendar.
_If_ it is needed to do something there (which I believe is not, at least for SM and TB which use omnijar), it would be to add(!) a new line, or move the existing one.
Attachment #589411 - Flags: feedback-
(Reporter)

Comment 5

6 years ago
(In reply to Serge Gautherie (:sgautherie) from comment #4)
> for SM and TB which use omnijar), it would be to add(!) a new line, or move

Arf, not omnijar exactly: see bug 718912 comment 3...
(Reporter)

Comment 6

6 years ago
Comment on attachment 589411 [details] [diff] [review]
Removed bin/components/proxyObject.xpt. (v2)

Callek, do you agree with checking this in, _without_ the removed-files.in parts?
Comment on attachment 589411 [details] [diff] [review]
Removed bin/components/proxyObject.xpt. (v2)

Review of attachment 589411 [details] [diff] [review]:
-----------------------------------------------------------------

Please don't remove it from removed-files.in
Attachment #589411 - Flags: review?(bugspam.Callek) → review-
(In reply to Serge Gautherie (:sgautherie) from comment #6)
> Comment on attachment 589411 [details] [diff] [review]
> Removed bin/components/proxyObject.xpt. (v2)
> 
> Callek, do you agree with checking this in, _without_ the removed-files.in
> parts?

Yes, without removed-files.in this patch was good.
(Assignee)

Comment 9

6 years ago
Created attachment 592558 [details] [diff] [review]
Removed bin/components/proxyObject.xpt. (v3)
Attachment #589411 - Attachment is obsolete: true
Attachment #592558 - Flags: review?(bugspam.Callek)

Updated

6 years ago
Attachment #592558 - Flags: review?(bugspam.Callek) → review+
(Assignee)

Comment 10

6 years ago
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/eb282639e268
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Target Milestone: --- → seamonkey2.9
(Reporter)

Comment 11

6 years ago
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1327889832.1327891902.22172.gz&fulltext=1
Linux x86-64 comm-central-trunk build on 2012/01/29 18:17:12

V.Fixed
Status: RESOLVED → VERIFIED
Component: Build Config → Build Config
Product: SeaMonkey → MailNews Core
QA Contact: build-config → build-config
Target Milestone: seamonkey2.9 → Thunderbird 12.0
(Reporter)

Updated

6 years ago
Depends on: 722247
(Reporter)

Updated

6 years ago
Depends on: 722251
(Reporter)

Comment 12

6 years ago
(In reply to Serge Gautherie (:sgautherie) from comment #4)
> removed-files.in:
> I'm sure SM and TB want to keep it, I assume the same is true for Calendar.
> _If_ it is needed to do something there (which I believe is not, at least
> for SM and TB which use omnijar), it would be to add(!) a new line, or move
> the existing one.

Ftr, this comment stands.
Bug 722247 or bug 722251 might tell otherwise, but I don't expect that to happen.
You need to log in before you can comment on or make changes to this bug.