Make sure the primary selection is not updated too often in the Source Editor

RESOLVED FIXED in Firefox 13

Status

()

Firefox
Developer Tools
P3
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: msucan, Assigned: msucan)

Tracking

Trunk
Firefox 13
All
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [sourceeditor][orion][fixed-in-fx-team])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Since bug 695035 landed we update the X11 primary selection when needed. We should limit the number of updates to only one after 250-500 ms of user inactivity. This would avoid potential lockups while working with really big files (and big selections).
(Assignee)

Updated

5 years ago
Assignee: nobody → mihai.sucan
(Assignee)

Comment 1

5 years ago
Created attachment 592249 [details] [diff] [review]
proposed patch

Proposed patch. Please let me know if this approach is fine with you. Thanks!
Attachment #592249 - Flags: review?(rcampbell)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Depends on: 712982
Comment on attachment 592249 [details] [diff] [review]
proposed patch

yeah, this looks ok to me. Why 250ms though. Why not 25ms? or 100?
(Assignee)

Comment 3

5 years ago
(In reply to Rob Campbell [:rc] (robcee) from comment #2)
> Comment on attachment 592249 [details] [diff] [review]
> proposed patch
> 
> yeah, this looks ok to me. Why 250ms though. Why not 25ms? or 100?

I picked it arbitrarily, I was also unsure how short the delay should be. Do you want me to put a different value?
yeah, I think 50ms or 100ms is probably sufficient. I feel like at 250ms, some fast users could switch windows and not have their clipboard populated.
(Assignee)

Comment 5

5 years ago
Created attachment 593582 [details] [diff] [review]
updated patch

Changed the timeout from 250ms to 100ms. Please let me know if further changes are needed.

Thank you!
Attachment #592249 - Attachment is obsolete: true
Attachment #592249 - Flags: review?(rcampbell)
Attachment #593582 - Flags: review?(rcampbell)
(Assignee)

Updated

5 years ago
Blocks: 700893
Attachment #593582 - Flags: review?(rcampbell) → review+
(Assignee)

Comment 6

5 years ago
Created attachment 595788 [details] [diff] [review]
[in-fx-team] rebased patch
Attachment #593582 - Attachment is obsolete: true
(Assignee)

Comment 7

5 years ago
Comment on attachment 595788 [details] [diff] [review]
[in-fx-team] rebased patch

Landed:
https://hg.mozilla.org/integration/fx-team/rev/00bce5149395
Attachment #595788 - Attachment description: rebased patch → [in-fx-team] rebased patch
(Assignee)

Updated

5 years ago
Whiteboard: [sourceeditor][orion] → [sourceeditor][orion][fixed-in-fx-team]
(Assignee)

Comment 8

5 years ago
Comment on attachment 595788 [details] [diff] [review]
[in-fx-team] rebased patch

backed out due to test failure:
https://hg.mozilla.org/integration/fx-team/rev/e732067ca81e
Attachment #595788 - Attachment description: [in-fx-team] rebased patch → rebased patch
(Assignee)

Updated

5 years ago
Whiteboard: [sourceeditor][orion][fixed-in-fx-team] → [sourceeditor][orion][backedout]
(Assignee)

Comment 9

5 years ago
Comment on attachment 595788 [details] [diff] [review]
[in-fx-team] rebased patch

Landed:
https://hg.mozilla.org/integration/fx-team/rev/ac5158b80fdf
Attachment #595788 - Attachment description: rebased patch → [in-fx-team] rebased patch
(Assignee)

Updated

5 years ago
Whiteboard: [sourceeditor][orion][backedout] → [sourceeditor][orion][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/ac5158b80fdf
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
You need to log in before you can comment on or make changes to this bug.