71776 - Column picker has empty context menu in Manage Bookmarks window

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P2)

Description

[Chris Lyon]

Using build 2001031204.
Open the Manage Bookmarks window and click on the column picker button.

Result:
A tiny empty context menu appears to the right of the window.

Expected Result:
The column picker menu should appear like it does in the History window.

Comment 1

[Fabian Guisset]

Confirmed on build 2001030904 win95. Marking NEW, blocking tracker bug 68550.

Comment 2

[Fabian Guisset]

*** Bug 74031 has been marked as a duplicate of this bug. ***

Comment 3

[Fabian Guisset]

from the duplicate bug :
"Actual Results:  JavaScript error stating "BuildTreePopup not defined" occurs. 

Expected Results:  Display of a popup with the other available columns is
displayed.

Cause of Problem:
Missing <script> for chrome://global/content/treePopups.js in bookmarks.xul"
Sounds easy to fix.

Comment 4

[Claudius Gayle]

changing platform to ALL/ALL. adding regression keyword. This used to work very recently - more
recently than the implementation of the new bookmarks manager.

Ben, I've upped the severity because -believe it or not- this bug is blocking my weekly performance
testing - I can't test the column sort without the column picker.

Comment 5

[Viswanath Ramachandran]

mozilla0.9.1, P2, nsbeta1+. 

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Fix in hand. 

Comment 7

[Fabian Guisset]

Attachment: Splitting Ben's patch in bug 76502. One-liner to fix this bug.

Comment 8

[Fabian Guisset]

Attaching a patch that adds a missing javascript file. Taken from Ben's patch in
bug 76502 which has just rotten there. Please r=/sr= this quickly, need to get
the bookmarks done right asap!

Comment 9

[Håkan Waara]

r=hwaara

Comment 10

[Alec Flett]

sr=alecf

Comment 11

[Fabian Guisset]

Fix checked in, marking FIXED.
Thanks for the reviews.

Comment 12

[Claudius Gayle]

Now the column picker widget is completely missing. This may be a different bug because it's
missing in the Global History window as well, but I'm guessing it's intricately related

Comment 13

[Viswanath Ramachandran]

claudius - could you file a different bug for the column picker being absent 
globally? thanks, Vishy. 

Comment 14

[Chris Lyon]

The global column picker bug is logged as bug 80663.

Comment 15

[Fabian Guisset]

Remarking fixed. The column picker missing is another problem and not caused by
the patch in this bug.

Comment 16

[Claudius Gayle]

ok, if fabian says he didn't break it, fine. Note this isn't really 'global' b/c the mailnews column
picker is fine, just Navigator wide.

Comment 17

[Fabian Guisset]

It's probably because mailnews uses the outliner while bookmarks and history use
trees

Comment 18

[[e-mail] (gone - use [e-mail] instead)]

Right, we're not dependant upon treePopups.js anymore.

Comment 19

[Claudius Gayle]

finally. VERIFIED Fixed with 2001061514 builds