689 bytes, patch
|Details | Diff | Splinter Review|
Using build 2001031204. Open the Manage Bookmarks window and click on the column picker button. Result: A tiny empty context menu appears to the right of the window. Expected Result: The column picker menu should appear like it does in the History window.
Confirmed on build 2001030904 win95. Marking NEW, blocking tracker bug 68550.
*** Bug 74031 has been marked as a duplicate of this bug. ***
changing platform to ALL/ALL. adding regression keyword. This used to work very recently - more recently than the implementation of the new bookmarks manager. Ben, I've upped the severity because -believe it or not- this bug is blocking my weekly performance testing - I can't test the column sort without the column picker.
mozilla0.9.1, P2, nsbeta1+.
Fix in hand.
Created attachment 33353 [details] [diff] [review] Splitting Ben's patch in bug 76502. One-liner to fix this bug.
Fix checked in, marking FIXED. Thanks for the reviews.
Now the column picker widget is completely missing. This may be a different bug because it's missing in the Global History window as well, but I'm guessing it's intricately related
claudius - could you file a different bug for the column picker being absent globally? thanks, Vishy.
The global column picker bug is logged as bug 80663.
Remarking fixed. The column picker missing is another problem and not caused by the patch in this bug.
ok, if fabian says he didn't break it, fine. Note this isn't really 'global' b/c the mailnews column picker is fine, just Navigator wide.
It's probably because mailnews uses the outliner while bookmarks and history use trees
Right, we're not dependant upon treePopups.js anymore.
finally. VERIFIED Fixed with 2001061514 builds