71779 - Need to update menus to show current XBL bindings

Status: NEW

(Core :: XUL, defect)

Description

[Akkana Peck]

Filing after discussion with Hyatt:

Bug 57078 concerns removing XUL key bindings which conflicted with XBL bindings
and overrode them.  It looks like the reason the XUL bindings weren't removed is
that XUL files are the only way to get key bindings listed in the menus.  So
we're going to end up with two redundant sets of bindings, one functional set
using XBL and another nonfunctional set that defines the accelerator text in the
menus.  These will almost certainly get out of sync.

Now that key bindings (at least for the browser and editor windows) are handled
primarily through XBL, there needs to be a mechanism for the menus to pick up
the XBL bindings corresponding to functions in that menu.  Ideally, when a menu
is displayed it should find the focused widget and query the controller(s) and
XBL bindings for that widget to find out what key definitions are active right then.

But failing that, even getting the XBL bindings for the current toplevel window
(browser or editor) would be a huge win over the current setup.

When this is working, the XUL files which are no longer needed should be
removed.  (See the first patch in bug 57078 for a tentative list of which files
are currently affected.)

Comment 1

[David Hyatt]

Accepting for 0.9.1.  This one is going to be neat.

Comment 2

[Kathleen :Brade]

*** Bug 77742 has been marked as a duplicate of this bug. ***

Comment 3

[sairuh (rarely reading bugmail)]

*** Bug 77976 has been marked as a duplicate of this bug. ***

Comment 4

[David Hyatt]

Dependent on Simon's command work.  Moving to 1.0.  Will pull in if/when simon
lands.

Comment 5

[Kathleen :Brade]

*** Bug 82230 has been marked as a duplicate of this bug. ***

Comment 6

[Kathleen :Brade]

note:  this should be in the release notes (at least on Linux) since Select All 
shows "ctrl-a" in the Edit menu but that is "go to beginning of line" on Linux; 
users should use alt-a instead.  There are probably some other cases like these 
as well (though there may not be an alternative keybinding).

Comment 7

[Aaron Leventhal]

-> Akkana

Comment 8

[Vedran Miletic]

retargeting

Comment 9

[Thomas D. (:thomas8)]

I suspect this bug has been fixed or obsoleted over time but unfortunately I don't know anything about XBL or XUL files so I can't close it.

David Hyatt, is this bug still assigned to you? Otherwise please change assigned-to accordingly.

Comment 10

[Samuel Sidler (old account; do not CC)]

(In reply to comment #9)
> David Hyatt, is this bug still assigned to you?

Haha. No way in the world.

Comment 11

[Thomas D. (:thomas8)]

Can somebody who understands more about XBL and XUL than I do confirm if this is still a problem or not?

Comment 12

[Ioana (away)]

(In reply to Thomas D. from comment #11)
> Can somebody who understands more about XBL and XUL than I do confirm if
> this is still a problem or not?

Perhaps someone on XUL could answer this question or at least point us to the right person.

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Mass-removing myself from cc; search for 12b9dfe4-ece3-40dc-8d23-60e179f64ac1 or any reasonable part thereof, to mass-delete these notifications (and sorry!)