Closed Bug 717958 Opened 9 years ago Closed 8 years ago

OMTC: Access to OGL FPS counter preference should only happen on the main thread

Categories

(Core :: Graphics, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla13
Tracking Status
blocking-fennec1.0 --- beta+

People

(Reporter: ajuma, Assigned: BenWa)

References

Details

Attachments

(1 file)

Bug 683745 made the OGL FPS counter pref 'live', so that changes take effect without a restart. However, with OMTC, this means that we are accessing preferences off the main thread (but we shouldn't be -- see bug 619487). We should either make this pref non-live again, or watch for changes to the pref on the main thread and then send a message to the compositor thread whenever there's a change.
Does this need to block bug 725095?
The correct functioning of the FPS counter itself isn't critical for bug 725095, but if accessing the pref off the main thread can cause other problems, then we need to fix this. Let's be cautious and make this block.
Blocks: land-maple
Priority: -- → P2
blocking-fennec1.0: --- → beta+
Comment on attachment 600552 [details] [diff] [review]
Dispatch a readpref event to main thread

Review of attachment 600552 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/opengl/LayerManagerOGL.cpp
@@ +364,5 @@
>        msg += NS_LITERAL_STRING("TEXTURE_RECTANGLE");
>      console->LogStringMessage(msg.get());
>    }
>  
> +  if (!NS_IsMainThread()) {

Remove the negation here.
Attachment #600552 - Flags: review+
Whiteboard: [autoland]
Whiteboard: [autoland] → [autoland-in-queue]
Autoland Patchset:
	Patches: 600552
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=93d013a929a1
Try run started, revision 93d013a929a1. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=93d013a929a1
Try run for 93d013a929a1 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=93d013a929a1
Results (out of 215 total builds):
    success: 177
    warnings: 24
    failure: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-93d013a929a1
Whiteboard: [autoland-in-queue]
https://hg.mozilla.org/mozilla-central/rev/32fcf3259a47
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
No longer blocks: omtc
Blocks: omtc
You need to log in before you can comment on or make changes to this bug.