Note: There are a few cases of duplicates in user autocompletion which are being worked on.

OMTC: Access to OGL FPS counter preference should only happen on the main thread

RESOLVED FIXED in mozilla13

Status

()

Core
Graphics
P2
normal
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: ajuma, Assigned: BenWa)

Tracking

(Blocks: 1 bug)

Trunk
mozilla13
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking-fennec1.0 beta+)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Bug 683745 made the OGL FPS counter pref 'live', so that changes take effect without a restart. However, with OMTC, this means that we are accessing preferences off the main thread (but we shouldn't be -- see bug 619487). We should either make this pref non-live again, or watch for changes to the pref on the main thread and then send a message to the compositor thread whenever there's a change.
Keywords: fennecnative-betablocker
Does this need to block bug 725095?
(Reporter)

Comment 2

6 years ago
The correct functioning of the FPS counter itself isn't critical for bug 725095, but if accessing the pref off the main thread can cause other problems, then we need to fix this. Let's be cautious and make this block.
Blocks: 725095
Priority: -- → P2
blocking-fennec1.0: --- → beta+
(Assignee)

Comment 3

6 years ago
Created attachment 600552 [details] [diff] [review]
Dispatch a readpref event to main thread
(Reporter)

Comment 4

6 years ago
Comment on attachment 600552 [details] [diff] [review]
Dispatch a readpref event to main thread

Review of attachment 600552 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/opengl/LayerManagerOGL.cpp
@@ +364,5 @@
>        msg += NS_LITERAL_STRING("TEXTURE_RECTANGLE");
>      console->LogStringMessage(msg.get());
>    }
>  
> +  if (!NS_IsMainThread()) {

Remove the negation here.
Attachment #600552 - Flags: review+
(Assignee)

Updated

6 years ago
Whiteboard: [autoland]

Updated

6 years ago
Whiteboard: [autoland] → [autoland-in-queue]

Comment 5

6 years ago
Autoland Patchset:
	Patches: 600552
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=93d013a929a1
Try run started, revision 93d013a929a1. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=93d013a929a1

Comment 6

6 years ago
Try run for 93d013a929a1 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=93d013a929a1
Results (out of 215 total builds):
    success: 177
    warnings: 24
    failure: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-93d013a929a1

Updated

6 years ago
Whiteboard: [autoland-in-queue]
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/projects/maple/rev/f99d62aca00a
https://hg.mozilla.org/integration/mozilla-inbound/rev/32fcf3259a47
Assignee: nobody → bgirard
https://hg.mozilla.org/mozilla-central/rev/32fcf3259a47
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
No longer blocks: 598873
Blocks: 598873
Blocks: 859517
You need to log in before you can comment on or make changes to this bug.