Last Comment Bug 717958 - OMTC: Access to OGL FPS counter preference should only happen on the main thread
: OMTC: Access to OGL FPS counter preference should only happen on the main thread
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: All All
: P2 normal (vote)
: mozilla13
Assigned To: Benoit Girard (:BenWa)
:
Mentors:
Depends on:
Blocks: omtc land-maple 859517
  Show dependency treegraph
 
Reported: 2012-01-13 09:06 PST by Ali Juma [:ajuma]
Modified: 2013-04-08 14:46 PDT (History)
6 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
beta+


Attachments
Dispatch a readpref event to main thread (1.16 KB, patch)
2012-02-24 15:33 PST, Benoit Girard (:BenWa)
ajuma.bugzilla: review+
Details | Diff | Review

Description Ali Juma [:ajuma] 2012-01-13 09:06:57 PST
Bug 683745 made the OGL FPS counter pref 'live', so that changes take effect without a restart. However, with OMTC, this means that we are accessing preferences off the main thread (but we shouldn't be -- see bug 619487). We should either make this pref non-live again, or watch for changes to the pref on the main thread and then send a message to the compositor thread whenever there's a change.
Comment 1 Joe Drew (not getting mail) 2012-02-22 15:25:20 PST
Does this need to block bug 725095?
Comment 2 Ali Juma [:ajuma] 2012-02-22 15:43:50 PST
The correct functioning of the FPS counter itself isn't critical for bug 725095, but if accessing the pref off the main thread can cause other problems, then we need to fix this. Let's be cautious and make this block.
Comment 3 Benoit Girard (:BenWa) 2012-02-24 15:33:55 PST
Created attachment 600552 [details] [diff] [review]
Dispatch a readpref event to main thread
Comment 4 Ali Juma [:ajuma] 2012-02-27 11:41:16 PST
Comment on attachment 600552 [details] [diff] [review]
Dispatch a readpref event to main thread

Review of attachment 600552 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/opengl/LayerManagerOGL.cpp
@@ +364,5 @@
>        msg += NS_LITERAL_STRING("TEXTURE_RECTANGLE");
>      console->LogStringMessage(msg.get());
>    }
>  
> +  if (!NS_IsMainThread()) {

Remove the negation here.
Comment 5 Mozilla RelEng Bot 2012-02-27 13:36:37 PST
Autoland Patchset:
	Patches: 600552
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=93d013a929a1
Try run started, revision 93d013a929a1. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=93d013a929a1
Comment 6 Mozilla RelEng Bot 2012-02-27 22:16:24 PST
Try run for 93d013a929a1 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=93d013a929a1
Results (out of 215 total builds):
    success: 177
    warnings: 24
    failure: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-93d013a929a1
Comment 8 Matt Brubeck (:mbrubeck) 2012-03-06 11:06:31 PST
https://hg.mozilla.org/mozilla-central/rev/32fcf3259a47

Note You need to log in before you can comment on or make changes to this bug.