859517 - LayerManagerOGL.cpp:676:68: warning: 'visibility' attribute ignored [-Wattributes]

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Daniel Holbert [:dholbert]]

Build warning:
{
/gfx/layers/opengl/LayerManagerOGL.cpp: In member function 'bool mozilla::layers::LayerManagerOGL::Initialize(nsRefPtr<mozilla::gl::GLContext>, bool)':

gfx/layers/opengl/LayerManagerOGL.cpp:676:68: warning: 'visibility' attribute ignored [-Wattributes]
}

As described in bug 832456 and bug 574430, we hit this build warning when we define a class inside of a function, and label one of its methods as NS_IMETHOD.

If we move the class definition out of the function, then all is well.

[looks like this runnable was added in https://hg.mozilla.org/mozilla-central/rev/32fcf3259a47 for Bug 717958, about a year ago -- adding dependency on that bug.]

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Looks like this helper-class needs to be declared inside the scope of LayerManagerOGL, since it makes use of LayerManagerOGL's private static variables.

This patch declares it in the 'private' block of LayerManagerOGL, adds MOZ_FINAL and MOZ_OVERRIDE keywords, and keeps the Run() impl in LayerManagerOGL.cpp, just above Initialize() instead of inside of it.

Comment 2

[Benoit Girard (:BenWa)]

Comment on attachment 734838 [details] [diff] [review]
fix v1

Review of attachment 734838 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1b86d1d851de

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1b86d1d851de