718126 - Tapping the video scrubber doesnt work on Native

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Tony Chung [:tchung]]

Attachment: screenshot of scrubber controls - Native

If you load the HTML5 video on both Fennec XUL and Fennec Native, you'll notice the video scrubber controls are missing on Native build.   Thus, there's no way to tap to skip back and forward in the video.

See screenshots

Repro:
1) install Fennec XUL 10 Beta and Fennec Nightly 1-13-2011 build
2) load URL and play HTML5 video on front page
3) playback videos on both Firefoxes
4) Verify XUL fennec allows you to tap to skip controls, whereas that functionality isnt there on Native Fennec 

Expected:
- video skipping on scrubber controls for Fennec Native

Actual;
- unable to skip

Comment 1

[Tony Chung [:tchung]]

Attachment: screenshot of scrubber controls - XUL

Comment 2

[:Margaret Leibovic]

Jared or Wes, do you know what could be going wrong here? (Or would one of you like to take this bug? ;)

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

I looked through the log for videocontrols.xml and nothing jumped out at me. Is there are regression range available?

http://hg.mozilla.org/mozilla-central/filelog/c3643d492d68/toolkit/content/widgets/videocontrols.xml

Comment 4

[:Margaret Leibovic]

Attachment: patch

Somehow this only ended up in XUL fennec's touchcontrols.css, probably because it was added while we were still developing on birch.

Anyway, fixing this CSS bustage fixes the controls.

Comment 5

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5a4a56fea608

Comment 6

[:Margaret Leibovic]

Comment on attachment 592004 [details] [diff] [review]
patch

[Approval Request Comment]
Low-risk CSS mobile-only change. This change made its way into XUL fennec, but not native fennec. Without this, the video scrubber doesn't work.

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5a4a56fea608

Comment 8

[:Margaret Leibovic]

Comment on attachment 592004 [details] [diff] [review]
patch

[Approval Request Comment]
This made its way into aurora through the merge, but it still needs to be uplifted to beta.

Comment 9

[Alex Keybl [:akeybl]]

Comment on attachment 592004 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Beta 11.

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-beta/rev/9e132f1db91b

Comment 11

[Cristian Nicolae (:xti)]

Verified fixed on:

Firefox 11.0
20120206202409
http://hg.mozilla.org/releases/mozilla-beta/rev/1c0aba74d116
Device: HTC Desire Z
OS: Android 2.3.3

However, there are still issues about the video controls even for Fx11, like:
- Play/Pause works randomly or it has a visible delay
- Video controls bar is not displayed right after tapping the screen and is not dismissed immediately after another tap is performed outside its UI
- Volume control doesn't work at all

For Fx12 and Fx12 nothing works well so far.

Comment 12

[:Margaret Leibovic]

(In reply to Cristian Nicolae (:xti) from comment #11)

> However, there are still issues about the video controls even for Fx11, like:
> - Play/Pause works randomly or it has a visible delay
> - Video controls bar is not displayed right after tapping the screen and is
> not dismissed immediately after another tap is performed outside its UI
> - Volume control doesn't work at all

Thanks for listing these issues. Could you please file these bugs if they aren't already filed?

> For Fx12 and Fx12 nothing works well so far.

Hm, that's odd, since the patch for this bug is in all 3 branches. If that's the case, then there's some regression causing it to fail on aurora and m-c.

Comment 13

[Cristian Nicolae (:xti)]

(In reply to Margaret Leibovic [:margaret] from comment #12)
> (In reply to Cristian Nicolae (:xti) from comment #11)
> 
> > However, there are still issues about the video controls even for Fx11, like:
> > - Play/Pause works randomly or it has a visible delay
> > - Video controls bar is not displayed right after tapping the screen and is
> > not dismissed immediately after another tap is performed outside its UI
> > - Volume control doesn't work at all
> 
> Thanks for listing these issues. Could you please file these bugs if they
> aren't already filed?
> 
> > For Fx12 and Fx12 nothing works well so far.
> 
> Hm, that's odd, since the patch for this bug is in all 3 branches. If that's
> the case, then there's some regression causing it to fail on aurora and m-c.

For Fx 11 and Fx 12:
- the video controls bar is displayed only after the first tap and it cannot be triggered again (or it might happen only after lots of tries).
- Video is playing even if the Play button is displayed on the Controls bar (in this case should be displayed the pause button)
- The video scrubber doesn't work at all

I will search for all related bugs for all of these issues and filling new ones if is needed. I will CC you for each new bug filled.

Comment 14

[Cristian Nicolae (:xti)]

(In reply to Cristian Nicolae (:xti) from comment #13)
> (In reply to Margaret Leibovic [:margaret] from comment #12)
> > (In reply to Cristian Nicolae (:xti) from comment #11)

> 
> For Fx 11 and Fx 12:

My mistake. Is about Fx 12 and Fx 13.

Comment 15

[Scoobidiver (away)]

This bug is fixed in Fx 11 and 12.

Comment 16

[Cristian Nicolae (:xti)]

(In reply to Margaret Leibovic [:margaret] from comment #12)
> (In reply to Cristian Nicolae (:xti) from comment #11)
> 
> Thanks for listing these issues. Could you please file these bugs if they
> aren't already filed?

The following bugs were filled: Bug 727817, Bug 727816, Bug 727812, Bug 727810, Bug 727809

I guess that all video controls issues are covered now.

Comment 17

[Cristian Nicolae (:xti)]

Video scrubber controls are displayed now as expected.

Verified fixed on:

Firefox 13.0a1 (2012-02-16)
20120216031231
http://hg.mozilla.org/mozilla-central/rev/a853f4017192

Firefox 12.0a2 (2012-02-16)
20120216042010
http://hg.mozilla.org/releases/mozilla-aurora/rev/c6fcc091279c

--
Device: Motorola Droid PRO
OS: Android 2.3.3

Comment 18

[:Margaret Leibovic]

(In reply to Cristian Nicolae (:xti) from comment #16)
> (In reply to Margaret Leibovic [:margaret] from comment #12)
> > (In reply to Cristian Nicolae (:xti) from comment #11)
> > 
> > Thanks for listing these issues. Could you please file these bugs if they
> > aren't already filed?
> 
> The following bugs were filled: Bug 727817, Bug 727816, Bug 727812, Bug
> 727810, Bug 727809

Do you have regression ranges on those bugs? I ask here, since they sound like they could all be caused by the same problem, possibly due to touch events.

Comment 19

[Cristian Nicolae (:xti)]

(In reply to Margaret Leibovic [:margaret] from comment #18)
> (In reply to Cristian Nicolae (:xti) from comment #16)
> > (In reply to Margaret Leibovic [:margaret] from comment #12)
> > > (In reply to Cristian Nicolae (:xti) from comment #11)
> > > 
> > > Thanks for listing these issues. Could you please file these bugs if they
> > > aren't already filed?
> > 
> > The following bugs were filled: Bug 727817, Bug 727816, Bug 727812, Bug
> > 727810, Bug 727809
> 
> Do you have regression ranges on those bugs? I ask here, since they sound
> like they could all be caused by the same problem, possibly due to touch
> events.

Not yet. I will try to find a regression range for all. Or it might be the same regression range. I thought that is better to narrow the issue in several bugs.

Comment 20

[Cristian Nicolae (:xti)]

I guess that all of those issues occurred since the first native builds.