Closed Bug 718220 Opened 11 years ago Closed 5 months ago

Favicons should be imported from IE

Categories

(Firefox :: Migration, enhancement, P2)

Product:
Firefox
Component:
Migration
Platform:
x86_64
Windows Vista
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: bjacob, Assigned: zcharris)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 718220 - Import favicons from IE bookmarks. r?mconley
48 bytes, text/x-phabricator-request
Details | Review 
I noticed this when mass-importing bookmarks from IE. The bookmark icons are not shown until the corresponding sites are visited. So when you import a lot of bookmarks from another browser, you get a lot of blank squares: that's kind of sad :-)

It would be nice if Firefox could automatically show all favicons for all bookmarks.

Mozilla/5.0 (Windows NT 6.0; WOW64; rv:9.0.1) Gecko/20100101 Firefox/9.0.1
yep, we never exported nor imported favicons.
Btw since related to the IE importer, moving to Migration.
Component: Bookmarks & History → Migration
QA Contact: bookmarks → migration
Summary: Bookmark favicons should load immediately, even if site is not visited yet → IE migrator should import favicons
See Also: → 1533288
See Also: → 1213284
Severity: normal → S3
Priority: -- → P3
Severity: S3 → S4
Blocks: calstate
Type: defect → enhancement
Summary: IE migrator should import favicons → Favicons should be imported from IE
Priority: P3 → P2

Hey zcharris,

Let's have you start by taking a look at this one. What I'd recommend is figuring out how you can get a copy of Internet Explorer running locally (or in a VM), and then trying to see how it was storing favicons. Other people might have written about this, so it might be solvable with some Googling around, but we'll want you to be able to test this manually too, so figuring out how to run IE somehow is going to be key.

Assignee: nobody → zcharris

properly import the favicons. r?mconley

Attachment #9299378 - Attachment description: WIP: Bug 718220 - Used NTFS to get the favicon data. Then I used this data to → Bug 718220 - Used NTFS to get the favicon data. Then I used this data to
Attachment #9299378 - Attachment description: Bug 718220 - Used NTFS to get the favicon data. Then I used this data to → Bug 718220 - Import favicons from IE bookmarks. r?mconley
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/68d35841f924
Import favicons from IE bookmarks. r=mconley

https://hg.mozilla.org/mozilla-central/rev/68d35841f924

Status: NEW → RESOLVED
Closed: 5 months ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.