Don't traverse black windows

RESOLVED FIXED

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

(Blocks: 1 bug)

12 Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 588779 [details] [diff] [review]
patch

There are cases when window is still black, but document isn't in CC generation.

I think this would be the fix for jst's Google Reader problem.

I'd like to land this small patch separately so that possible regressions are easier
to find.
Attachment #588779 - Flags: review?(jst)
Attachment #588779 - Flags: review?(continuation)
(Assignee)

Comment 1

5 years ago
The patch has been part of my bigger patch for ~two weeks now, and so far everything looks ok.
Comment on attachment 588779 [details] [diff] [review]
patch

Makes sense.  The wrapper will always keep the window alive, so this makes sense to me.  Just out of curiousity, have you looked at doing this for nsGenericElements with wrappers?
Attachment #588779 - Flags: review?(continuation) → review+
Blocks: 716598
OS: Linux → All
Hardware: x86_64 → All
(Assignee)

Comment 3

5 years ago
Yes, nodes do check blackness already. It is just that any changes to window's CC handling *may*
have more dramatic effects than changing just node/element/document handling - that is why
I want to land this small patch separately.

Updated

5 years ago
Attachment #588779 - Flags: review?(jst) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/93d7303c1684
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

5 years ago
Some unknown orange. filed bug 716598
https://hg.mozilla.org/mozilla-central/rev/b3b8d62e0d92
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 6

5 years ago
(In reply to Olli Pettay [:smaug] from comment #5)
> Some unknown orange. filed bug 716598
er, bug 718411
(Assignee)

Comment 7

5 years ago
I haven't seen the error on tryserver. Is it required to traverse timeouts even when
the window is black. But if so, why not when the document is in cc generation.
(Assignee)

Comment 8

5 years ago
I don't understand it. Timeouts should be traversed anyway, since they are stored in mJSHolders
and XPConnect should add that stuff to CC.
Have you tried turning on CC logging and seeing what they look like with and without this turned optimization?
(Assignee)

Comment 10

5 years ago
Well, there is certainly a bug in videocontrols.xml.

But no, I haven't checked the CC logs, since I can't reproduce the problem.
(Assignee)

Comment 11

5 years ago
And looks like the failure isn't caused by this. It happened even after backout.
Well, at least that means we still probably understand what is happening.
(Assignee)

Comment 13

5 years ago
https://hg.mozilla.org/mozilla-central/rev/0e7d183d0d12

The problem ended up being a regression from another patch which landed just before this one.

Hopefully better luck this time.
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.