Note: There are a few cases of duplicates in user autocompletion which are being worked on.

WebConsole doesn't show the "warning" icons on warning and errors

RESOLVED FIXED in Firefox 12

Status

()

Firefox
Developer Tools: Console
P2
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: paul, Assigned: jwalker)

Tracking

({regression})

Trunk
Firefox 12
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
(Reporter)

Comment 1

6 years ago
regression, I think it comes from bug 704182
Priority: -- → P2
(Reporter)

Updated

6 years ago
Keywords: regression
(Reporter)

Updated

6 years ago
Blocks: 704110

Updated

6 years ago
Hardware: x86 → All
Duplicate of this bug: 717770
We're partially reverting the changes made here: https://hg.mozilla.org/mozilla-central/rev/8409adc46f14
Created attachment 591767 [details] [diff] [review]
upload 1
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
Attachment #591767 - Flags: review?(paul)
Created attachment 591769 [details] [diff] [review]
upload 2

swap !important for more specific rule
Attachment #591767 - Attachment is obsolete: true
Attachment #591767 - Flags: review?(paul)
Attachment #591769 - Flags: review?(paul)
Attachment #591769 - Flags: review?(dao)
Comment on attachment 591769 [details] [diff] [review]
upload 2

>-  "  <li if=\"${command.params.length === 0}\">${l10n.helpManNone}</li>\n" +
>-  "  <li foreach=\"param in ${command.params}\">\n" +
>+  "  <li if=\"${command.params.length === 0}\" class=\"gcliterm-li-plain\">${l10n.helpManNone}</li>\n" +
>+  "  <li foreach=\"param in ${command.params}\" class=\"gcliterm-li-plain\">\n" +

Please find a class that describes the actual role of these nodes.

>+li.gcliterm-li-plain {

nit: drop the element name selector
Attachment #591769 - Flags: review?(dao) → review-
(In reply to Dão Gottwald [:dao] from comment #6)
> Comment on attachment 591769 [details] [diff] [review]
> upload 2
> 
> >-  "  <li if=\"${command.params.length === 0}\">${l10n.helpManNone}</li>\n" +
> >-  "  <li foreach=\"param in ${command.params}\">\n" +
> >+  "  <li if=\"${command.params.length === 0}\" class=\"gcliterm-li-plain\">${l10n.helpManNone}</li>\n" +
> >+  "  <li foreach=\"param in ${command.params}\" class=\"gcliterm-li-plain\">\n" +
> 
> Please find a class that describes the actual role of these nodes.

Unfortunately the purpose of the class is to reverse the effect a broad rule up the tree, so the role is to make an li plain. Do you have something else in mind?

> >+li.gcliterm-li-plain {
> 
> nit: drop the element name selector

OK - It's not there by mistake, I wanted to make this rule clearly more specific than the broad rule that it's overriding, but I think we can take it out without changing how things work.

Thanks.
I was referring to the role of the nodes, not the purpose of the class. E.g.:

<ul class="gcli-help-parameter-list">
  <li class="gcli-help-parameter"></li>
  <li class="gcli-help-parameter"></li>
</ul>
(In reply to Dão Gottwald [:dao] from comment #8)
> I was referring to the role of the nodes, not the purpose of the class. E.g.:
> 
> <ul class="gcli-help-parameter-list">
>   <li class="gcli-help-parameter"></li>
>   <li class="gcli-help-parameter"></li>
> </ul>

So are you saying that you would prefer that every time anyone uses an li inside GCLI, they have to create a new class, and all the classes say the same thing: "revert to default li styling"?
If you want this for any list item added in GCLI, just set list-style-image:none on .gcliterm-msg-body?
Created attachment 592094 [details] [diff] [review]
upload 3

(In reply to Dão Gottwald [:dao] from comment #10)
> If you want this for any list item added in GCLI, just set
> list-style-image:none on .gcliterm-msg-body?

Yes - good point, thanks. Done.
Attachment #591769 - Attachment is obsolete: true
Attachment #591769 - Flags: review?(paul)
Attachment #592094 - Flags: review?(dao)

Updated

6 years ago
Attachment #592094 - Flags: review?(dao) → review+
https://tbpl.mozilla.org/?tree=Try&rev=e6cb0ce0cbf3
Thanks Dão.
https://tbpl.mozilla.org/?tree=Fx-Team&rev=5e41076a67dd
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/5e41076a67dd
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 12
You need to log in before you can comment on or make changes to this bug.