Closed Bug 718431 Opened 8 years ago Closed 8 years ago

WebConsole doesn't show the "warning" icons on warning and errors

Categories

(DevTools :: Console, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 12

People

(Reporter: paul, Assigned: jwalker)

References

Details

(Keywords: regression)

Attachments

(1 file, 2 obsolete files)

No description provided.
regression, I think it comes from bug 704182
Priority: -- → P2
Keywords: regression
Blocks: 704110
Hardware: x86 → All
Duplicate of this bug: 717770
Attached patch upload 1 (obsolete) — Splinter Review
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
Attachment #591767 - Flags: review?(paul)
Attached patch upload 2 (obsolete) — Splinter Review
swap !important for more specific rule
Attachment #591767 - Attachment is obsolete: true
Attachment #591767 - Flags: review?(paul)
Attachment #591769 - Flags: review?(paul)
Comment on attachment 591769 [details] [diff] [review]
upload 2

>-  "  <li if=\"${command.params.length === 0}\">${l10n.helpManNone}</li>\n" +
>-  "  <li foreach=\"param in ${command.params}\">\n" +
>+  "  <li if=\"${command.params.length === 0}\" class=\"gcliterm-li-plain\">${l10n.helpManNone}</li>\n" +
>+  "  <li foreach=\"param in ${command.params}\" class=\"gcliterm-li-plain\">\n" +

Please find a class that describes the actual role of these nodes.

>+li.gcliterm-li-plain {

nit: drop the element name selector
Attachment #591769 - Flags: review?(dao) → review-
(In reply to Dão Gottwald [:dao] from comment #6)
> Comment on attachment 591769 [details] [diff] [review]
> upload 2
> 
> >-  "  <li if=\"${command.params.length === 0}\">${l10n.helpManNone}</li>\n" +
> >-  "  <li foreach=\"param in ${command.params}\">\n" +
> >+  "  <li if=\"${command.params.length === 0}\" class=\"gcliterm-li-plain\">${l10n.helpManNone}</li>\n" +
> >+  "  <li foreach=\"param in ${command.params}\" class=\"gcliterm-li-plain\">\n" +
> 
> Please find a class that describes the actual role of these nodes.

Unfortunately the purpose of the class is to reverse the effect a broad rule up the tree, so the role is to make an li plain. Do you have something else in mind?

> >+li.gcliterm-li-plain {
> 
> nit: drop the element name selector

OK - It's not there by mistake, I wanted to make this rule clearly more specific than the broad rule that it's overriding, but I think we can take it out without changing how things work.

Thanks.
I was referring to the role of the nodes, not the purpose of the class. E.g.:

<ul class="gcli-help-parameter-list">
  <li class="gcli-help-parameter"></li>
  <li class="gcli-help-parameter"></li>
</ul>
(In reply to Dão Gottwald [:dao] from comment #8)
> I was referring to the role of the nodes, not the purpose of the class. E.g.:
> 
> <ul class="gcli-help-parameter-list">
>   <li class="gcli-help-parameter"></li>
>   <li class="gcli-help-parameter"></li>
> </ul>

So are you saying that you would prefer that every time anyone uses an li inside GCLI, they have to create a new class, and all the classes say the same thing: "revert to default li styling"?
If you want this for any list item added in GCLI, just set list-style-image:none on .gcliterm-msg-body?
Attached patch upload 3Splinter Review
(In reply to Dão Gottwald [:dao] from comment #10)
> If you want this for any list item added in GCLI, just set
> list-style-image:none on .gcliterm-msg-body?

Yes - good point, thanks. Done.
Attachment #591769 - Attachment is obsolete: true
Attachment #591769 - Flags: review?(paul)
Attachment #592094 - Flags: review?(dao)
Attachment #592094 - Flags: review?(dao) → review+
https://hg.mozilla.org/mozilla-central/rev/5e41076a67dd
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 12
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.