718431 - WebConsole doesn't show the "warning" icons on warning and errors

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Comment 1

[Paul Rouget [:paul]]

regression, I think it comes from bug 704182

Comment 3

[Joe Walker [:jwalker]]

We're partially reverting the changes made here: https://hg.mozilla.org/mozilla-central/rev/8409adc46f14

Comment 4

[Joe Walker [:jwalker]]

Attachment: upload 1

Comment 5

[Joe Walker [:jwalker]]

Attachment: upload 2

swap !important for more specific rule

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 591769 [details] [diff] [review]
upload 2

>-  "  <li if=\"${command.params.length === 0}\">${l10n.helpManNone}</li>\n" +
>-  "  <li foreach=\"param in ${command.params}\">\n" +
>+  "  <li if=\"${command.params.length === 0}\" class=\"gcliterm-li-plain\">${l10n.helpManNone}</li>\n" +
>+  "  <li foreach=\"param in ${command.params}\" class=\"gcliterm-li-plain\">\n" +

Please find a class that describes the actual role of these nodes.

>+li.gcliterm-li-plain {

nit: drop the element name selector

Comment 7

[Joe Walker [:jwalker]]

(In reply to Dão Gottwald [:dao] from comment #6)
> Comment on attachment 591769 [details] [diff] [review]
> upload 2
> 
> >-  "  <li if=\"${command.params.length === 0}\">${l10n.helpManNone}</li>\n" +
> >-  "  <li foreach=\"param in ${command.params}\">\n" +
> >+  "  <li if=\"${command.params.length === 0}\" class=\"gcliterm-li-plain\">${l10n.helpManNone}</li>\n" +
> >+  "  <li foreach=\"param in ${command.params}\" class=\"gcliterm-li-plain\">\n" +
> 
> Please find a class that describes the actual role of these nodes.

Unfortunately the purpose of the class is to reverse the effect a broad rule up the tree, so the role is to make an li plain. Do you have something else in mind?

> >+li.gcliterm-li-plain {
> 
> nit: drop the element name selector

OK - It's not there by mistake, I wanted to make this rule clearly more specific than the broad rule that it's overriding, but I think we can take it out without changing how things work.

Thanks.

Comment 8

[Dão Gottwald [:dao]]

I was referring to the role of the nodes, not the purpose of the class. E.g.:

<ul class="gcli-help-parameter-list">
  <li class="gcli-help-parameter"></li>
  <li class="gcli-help-parameter"></li>
</ul>

Comment 9

[Joe Walker [:jwalker]]

(In reply to Dão Gottwald [:dao] from comment #8)
> I was referring to the role of the nodes, not the purpose of the class. E.g.:
> 
> <ul class="gcli-help-parameter-list">
>   <li class="gcli-help-parameter"></li>
>   <li class="gcli-help-parameter"></li>
> </ul>

So are you saying that you would prefer that every time anyone uses an li inside GCLI, they have to create a new class, and all the classes say the same thing: "revert to default li styling"?

Comment 10

[Dão Gottwald [:dao]]

If you want this for any list item added in GCLI, just set list-style-image:none on .gcliterm-msg-body?

Comment 11

[Joe Walker [:jwalker]]

Attachment: upload 3

(In reply to Dão Gottwald [:dao] from comment #10)
> If you want this for any list item added in GCLI, just set
> list-style-image:none on .gcliterm-msg-body?

Yes - good point, thanks. Done.

Comment 12

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Try&rev=e6cb0ce0cbf3

Comment 13

[Joe Walker [:jwalker]]

Thanks Dão.

Comment 14

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Fx-Team&rev=5e41076a67dd

Comment 15

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/5e41076a67dd