Last Comment Bug 718431 - WebConsole doesn't show the "warning" icons on warning and errors
: WebConsole doesn't show the "warning" icons on warning and errors
Status: RESOLVED FIXED
: regression
Product: Firefox
Classification: Client Software
Component: Developer Tools: Console (show other bugs)
: Trunk
: All All
: P2 normal (vote)
: Firefox 12
Assigned To: Joe Walker [:jwalker] (needinfo me or ping on irc)
:
Mentors:
: 717770 (view as bug list)
Depends on:
Blocks: 704110
  Show dependency treegraph
 
Reported: 2012-01-16 07:51 PST by Paul Rouget [:paul]
Modified: 2012-01-28 06:18 PST (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
upload 1 (5.97 KB, patch)
2012-01-26 05:54 PST, Joe Walker [:jwalker] (needinfo me or ping on irc)
no flags Details | Diff | Splinter Review
upload 2 (5.95 KB, patch)
2012-01-26 06:00 PST, Joe Walker [:jwalker] (needinfo me or ping on irc)
dao+bmo: review-
Details | Diff | Splinter Review
upload 3 (4.85 KB, patch)
2012-01-27 03:43 PST, Joe Walker [:jwalker] (needinfo me or ping on irc)
dao+bmo: review+
Details | Diff | Splinter Review

Description Paul Rouget [:paul] 2012-01-16 07:51:37 PST

    
Comment 1 Paul Rouget [:paul] 2012-01-16 08:02:08 PST
regression, I think it comes from bug 704182
Comment 2 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-01-26 05:52:03 PST
*** Bug 717770 has been marked as a duplicate of this bug. ***
Comment 3 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-01-26 05:52:59 PST
We're partially reverting the changes made here: https://hg.mozilla.org/mozilla-central/rev/8409adc46f14
Comment 4 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-01-26 05:54:20 PST
Created attachment 591767 [details] [diff] [review]
upload 1
Comment 5 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-01-26 06:00:06 PST
Created attachment 591769 [details] [diff] [review]
upload 2

swap !important for more specific rule
Comment 6 Dão Gottwald [:dao] 2012-01-26 07:41:39 PST
Comment on attachment 591769 [details] [diff] [review]
upload 2

>-  "  <li if=\"${command.params.length === 0}\">${l10n.helpManNone}</li>\n" +
>-  "  <li foreach=\"param in ${command.params}\">\n" +
>+  "  <li if=\"${command.params.length === 0}\" class=\"gcliterm-li-plain\">${l10n.helpManNone}</li>\n" +
>+  "  <li foreach=\"param in ${command.params}\" class=\"gcliterm-li-plain\">\n" +

Please find a class that describes the actual role of these nodes.

>+li.gcliterm-li-plain {

nit: drop the element name selector
Comment 7 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-01-26 08:08:44 PST
(In reply to Dão Gottwald [:dao] from comment #6)
> Comment on attachment 591769 [details] [diff] [review]
> upload 2
> 
> >-  "  <li if=\"${command.params.length === 0}\">${l10n.helpManNone}</li>\n" +
> >-  "  <li foreach=\"param in ${command.params}\">\n" +
> >+  "  <li if=\"${command.params.length === 0}\" class=\"gcliterm-li-plain\">${l10n.helpManNone}</li>\n" +
> >+  "  <li foreach=\"param in ${command.params}\" class=\"gcliterm-li-plain\">\n" +
> 
> Please find a class that describes the actual role of these nodes.

Unfortunately the purpose of the class is to reverse the effect a broad rule up the tree, so the role is to make an li plain. Do you have something else in mind?

> >+li.gcliterm-li-plain {
> 
> nit: drop the element name selector

OK - It's not there by mistake, I wanted to make this rule clearly more specific than the broad rule that it's overriding, but I think we can take it out without changing how things work.

Thanks.
Comment 8 Dão Gottwald [:dao] 2012-01-26 08:14:27 PST
I was referring to the role of the nodes, not the purpose of the class. E.g.:

<ul class="gcli-help-parameter-list">
  <li class="gcli-help-parameter"></li>
  <li class="gcli-help-parameter"></li>
</ul>
Comment 9 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-01-26 10:27:08 PST
(In reply to Dão Gottwald [:dao] from comment #8)
> I was referring to the role of the nodes, not the purpose of the class. E.g.:
> 
> <ul class="gcli-help-parameter-list">
>   <li class="gcli-help-parameter"></li>
>   <li class="gcli-help-parameter"></li>
> </ul>

So are you saying that you would prefer that every time anyone uses an li inside GCLI, they have to create a new class, and all the classes say the same thing: "revert to default li styling"?
Comment 10 Dão Gottwald [:dao] 2012-01-27 02:27:46 PST
If you want this for any list item added in GCLI, just set list-style-image:none on .gcliterm-msg-body?
Comment 11 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-01-27 03:43:21 PST
Created attachment 592094 [details] [diff] [review]
upload 3

(In reply to Dão Gottwald [:dao] from comment #10)
> If you want this for any list item added in GCLI, just set
> list-style-image:none on .gcliterm-msg-body?

Yes - good point, thanks. Done.
Comment 12 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-01-27 04:37:19 PST
https://tbpl.mozilla.org/?tree=Try&rev=e6cb0ce0cbf3
Comment 13 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-01-27 04:38:51 PST
Thanks Dão.
Comment 14 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-01-27 06:50:51 PST
https://tbpl.mozilla.org/?tree=Fx-Team&rev=5e41076a67dd
Comment 15 Tim Taubert [:ttaubert] (on PTO, back Aug 29th) 2012-01-28 06:18:04 PST
https://hg.mozilla.org/mozilla-central/rev/5e41076a67dd

Note You need to log in before you can comment on or make changes to this bug.