718861 - Add required fields to Step 3

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[Wil Clouser [:clouserw]]

Step 3 has us confirming the name, summary, and description.  There are a few more fields we can take from the add-ons site.  Added to this page should be:

- Homepage (default: blank)

- Support Information.  Let's make this only the Website field for now as the mockups we've seen don't have a place for email.

One new field (it doesn't exist for add-ons yet) is form factor compatibility.  Add this to the bottom as checkboxes.  The three options will be mobile, tablet, and desktop.  We should have pretty icons and detailed mouse-over help and I'll CC some people who can help with that.

Comment 1

[Davor Spasovski [:spasovski]]

snatchy

Comment 2

[Wil Clouser [:clouserw]]

Done by EOD but bumping to current milestone

Comment 3

[Davor Spasovski [:spasovski]]

Here is the implementation for this:

https://github.com/spasovski/zamboni/commit/0d1914d

The form tests are complete and pass, the edit app tests are written and pass, the submit app - step 3 (describe) needs a required field test. As in 'device_form' should `self.assertFormError(r, 'device_form', 'device_types', 'This field is required.')`

Comment 4

[Davor Spasovski [:spasovski]]

done: https://github.com/mozilla/zamboni/commit/3a2299c

Comment 5

[Christopher Van Wiemeersch [:cvan]]

I see this traceback on -dev:

Traceback (most recent call last):

 File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/addons/decorators.py", line 29, in wrapper
   return f(request, addon, *args, **kw)

 File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/addons/views.py", line 92, in addon_detail
   return extension_detail(request, addon)

 File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django-mobility/mobility/decorators.py", line 49, in wrapper
   return normal_fn(request, *args, **kw)

 File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django/django/views/decorators/vary.py", line 19, in inner_func
   response = func(*args, **kwargs)

 File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/addons/views.py", line 157, in extension_detail
   return jingo.render(request, 'addons/impala/details-more.html', ctx)

 File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/jingo/jingo/__init__.py", line 80, in render
   rendered = render_to_string(request, template, context)

 File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/jingo/jingo/__init__.py", line 98, in render_to_string
   return template.render(**get_context())

 File "/usr/lib64/python2.6/site-packages/jinja2/environment.py", line 891, in render
   return self.environment.handle_exception(exc_info, True)

 File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/addons/templates/addons/impala/details-more.html", line 33, in top-level template code
   {% cache addon %}

 File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/amo/ext.py", line 18, in _cache_support
   return caller()

 File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/addons/templates/addons/impala/details-more.html", line 53, in template
   {% set device_types = addon.device_types %}

 File "/usr/lib64/python2.6/site-packages/jinja2/environment.py", line 371, in getattr
   return getattr(obj, attribute)

 File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/webapps/models.py", line 109, in device_types
   return [d.device_type for d in self.addondevicetype_set.all()]

 File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django/django/db/models/query.py", line 107, in _result_iter
   self._fill_cache()

 File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django/django/db/models/query.py", line 784, in _fill_cache
   self._result_cache.append(self._iter.next())

 File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django-cache-machine/caching/base.py", line 102, in __iter__
   obj = iterator.next()

 File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django-cache-machine/caching/base.py", line 158, in fetch_by_id
   pks = [val[0] for val in vals]

 File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django/django/db/models/query.py", line 107, in _result_iter
   self._fill_cache()

 File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django/django/db/models/query.py", line 784, in _fill_cache
   self._result_cache.append(self._iter.next())

 File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django/django/db/models/query.py", line 971, in iterator
   for row in self.query.get_compiler(self.db).results_iter():

 File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django/django/db/models/sql/compiler.py", line 695, in results_iter
   for rows in self.execute_sql(MULTI):

 File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django/django/db/models/sql/compiler.py", line 750, in execute_sql
   cursor.execute(sql, params)

 File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django/django/db/backends/mysql/base.py", line 86, in execute
   return self.cursor.execute(query, args)

 File "/usr/lib64/python2.6/site-packages/MySQLdb/cursors.py", line 173, in execute
   self.errorhandler(self, exc, value)

 File "/usr/lib64/python2.6/site-packages/MySQLdb/connections.py", line 36, in defaulterrorhandler
   raise errorclass, errorvalue

DatabaseError: (1146, "Table 'appspreviewdev_allizom_org.addons_devicetypes' doesn't exist")

Comment 6

[Andy McKay]

Has the fixed update script fixed this?

Comment 7

[Christopher Van Wiemeersch [:cvan]]

It looks like we're good now.

Comment 8

[Christopher Van Wiemeersch [:cvan]]

Actually I take that back. Still a traceback. This looks like a botched migration.

Comment 9

[Davor Spasovski [:spasovski]]

I'll take a look also