Add an extra mail header to messages containing a link to a first patch

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: jdm, Assigned: dkl)

Tracking

(Blocks 1 bug)

Production
x86
macOS
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Reporter

Description

7 years ago
The contributor engagement stewards are interested in finding ways to make new contributors more visible. An extra mail header for messages announcing a new attachment which is a patch, and which is a user's first patch, would give us an extra tool to discover them and make sure they're not forgotten.
Assignee

Updated

7 years ago
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Assignee

Comment 1

7 years ago
Patch that adds X-Bugzilla-FirstPatch: $bugid to the email notifications sent
when the changer's first patch is on $bugid. This was added to the TagNewUser extension which seemed like the appropriate place.

Please review
dkl
Attachment #589967 - Flags: review?(glob)
Comment on attachment 589967 [details] [diff] [review]
Patch to add header when bug contains users first patch (v1)

this patch adds the header to all emails triggered by the user on the bug their first patch is attached to, rather than just the new attachment email as requested.

aside from that, the code looks good.
Attachment #589967 - Flags: review?(glob) → review-
Assignee

Comment 3

7 years ago
Thanks glob. Here is an updated patch.

dkl
Attachment #589967 - Attachment is obsolete: true
Attachment #590339 - Flags: review?(glob)
(In reply to David Lawrence [:dkl] from comment #3)
> Created attachment 590339 [details] [diff] [review]

i don't feel comfortable using the layout of the mail body to match against -- i'm concerned the format of the emails will change (such as in 4.2) and that will silently break this feature.

is it possible to add an x-header with the attachment id for attachment newchangedmail messages only, and they use that in our hook?  if it's easy i'd prefer that approach, however if it's too cumbersome to do so i'm happy to r+ patch v2.
Assignee

Comment 5

7 years ago
Thanks glob. I have updated Bugzilla/BugMail.pl to add "Attachment Created" to X-Bugzilla-Changed-Fields which I can now look for when adding the first patch header. I will try to push the BugMail.pm change upstream when this is complete.

dkl
Attachment #590339 - Attachment is obsolete: true
Attachment #590339 - Flags: review?(glob)
Attachment #591290 - Flags: review?(glob)
Comment on attachment 591290 [details] [diff] [review]
Patch to add header when bug contains users first patch (v3)

excellent :)  r=glob
Attachment #591290 - Flags: review?(glob) → review+
Assignee

Comment 7

7 years ago
Thanks

Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.0
modified Bugzilla/BugMail.pm
modified extensions/TagNewUsers/Extension.pm
Committed revision 8042.

dkl
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Assignee

Updated

7 years ago
Blocks: 721161
Reporter

Updated

7 years ago

Comment 8

7 years ago
Here's the text for the email for the following coding products: core, firefox, toolkit, fennec, testing, mozilla services.
(In reply to David Boswell from comment #8)
> Created attachment 593629 [details]
> Patch approved email text for coding products
> 
> Here's the text for the email for the following coding products: core,
> firefox, toolkit, fennec, testing, mozilla services.

i'm guessing that's for bug 721206 not this one?
You need to log in before you can comment on or make changes to this bug.