720898 - in-review add-ons should not be 404!

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Public Pages, enhancement, P4)

Description

[Dietrich Ayala (:dietrich)]

See https://addons.mozilla.org/en-US/firefox/addon/dontbeevil/

Instead of saying "not found", the page should say something like "this add-on is currently under review, and will be found at this url when deemed safe".

It should only go 404 once the add-on is purged from the system.

Comment 1

[krupa raj[:krupa]]

Looks like your add-on is incomplete: https://addons.mozilla.org/en-US/developers/addon/dontbeevil/versions

Selecting a review type would make your add-on available via the direct link.

Comment 2

[Dietrich Ayala (:dietrich)]

I just requested review before filing this bug.

Comment 3

[krupa raj[:krupa]]

It looks like your selection didn't stick. See http://cl.ly/131Y2O243516383L221N

You can make the review selection at https://addons.mozilla.org/en-US/developers/addon/dontbeevil/versions and things should work.

Comment 4

[Dietrich Ayala (:dietrich)]

The add-on was live after I first updated it. Then I got a review denial. At that point, the add-on page was the "not found" text.

Then I uploaded a new version, and asked for preliminary review. The add-on was still "not found".

Then I clicked on the link you showed there, and it said I needed to ask for review. (Again?!)

After doing that, the add-on is live.

IMO the URL should never be "not found" unless the add-on does not exist in the system.

The URL should say what's actually happening. "not found" is misleading and incorrect.

Comment 5

[Justin Scott [:fligtar]]

Yeah, this is part of a larger principle I'd like to see fixed that the developer and admins should always see add-on detail pages, but with a message at the top explaining why others can't see it.

so:
* pending review
* developer-disabled/inactive
* admin-disabled

should all show the details page to the authors and admins with a message detailing the exact reason. This is especially useful for developers trying to tweak their listing page prior to it going live.

Comment 7

[Christopher Van Wiemeersch [:cvan]]

(In reply to Justin Scott [:fligtar] from comment #5)
> Yeah, this is part of a larger principle I'd like to see fixed that the
> developer and admins should always see add-on detail pages, but with a
> message at the top explaining why others can't see it.

Can we get precise (and concise) copy for each case?

Comment 8

[Dietrich Ayala (:dietrich)]

The suggested solution covers the developer, and sounds great.

The bigger problem is that the add-on appears to not exist to *users*. Once second the URL is to the add-on, and the next it's a 404. The page should tell users that the add-on is currently under review, and whether the ball is in AMO's or the developer's court, so that users have recourse.

Comment 9

[Justin Scott [:fligtar]]

(In reply to Dietrich Ayala (:dietrich) from comment #8)
> The bigger problem is that the add-on appears to not exist to *users*. Once
> second the URL is to the add-on, and the next it's a 404. The page should
> tell users that the add-on is currently under review, and whether the ball
> is in AMO's or the developer's court, so that users have recourse.

I can't think of any cases where an add-on would be under review and not visible via a direct link. If the case you're talking about is that an add-on's status was changed to incomplete because its first version was rejected and there are no other versions to fall back to, saying it's under review would be misleading because we have no way of knowing whether the developer will submit another version or leave it incomplete.

Comment 10

[Justin Scott [:fligtar]]

(In reply to Chris Van Wiemeersch [:cvan] from comment #7)
> Can we get precise (and concise) copy for each case?

For developers and admins:
The details page should always appear, with a banner saying either:

* This add-on is currently incomplete and invisible to other users. To complete your submission, visit the Status tool. (with link)

* This add-on has been disabled by its developer and is invisible to other users. To re-enable it, visit the Status tool. (with link)

* This add-on has been disabled by Mozilla. If you have any questions about this, please email [e-mail].

For users:
No parts of the details page should be shown (including the name or icon), and a message should say:

* This add-on has been disabled by its developer and is no longer available.

* This add-on has been disabled by Mozilla and is no longer available.

* This add-on is no longer available (in general cases)

Comment 11

[Christopher Van Wiemeersch [:cvan]]

This will be committed after our Thursday push and QA'd for our next release - Thurs, Feb 16.

Comment 12

[Christopher Van Wiemeersch [:cvan]]

We did this for Marketplace. Ask cvan if you have questions.

Comment 13

[Wil Clouser [:clouserw]]

Thanks for filing this.  Due to resource constraints we are closing bugs which we won't realistically be able to fix.  If you have a patch that applies to this bug please reopen.

For more info see http://micropipes.com/blog/2014/09/24/the-great-add-on-bug-triage/