720992 - Tilt should use mozAnimation for all its animations, instead of intervals

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Victor Porof [:vporof][:vp]]

See more info in bug 718425.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

A few global consts had to be changed slightly to achieve approximately the same animation timings.

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: v2

Fixed a few fails in try.

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 594118 [details] [diff] [review]
v2

-const INTRO_TRANSITION_DURATION = 50;
-const OUTRO_TRANSITION_DURATION = 40;
+const INTRO_TRANSITION_DURATION = 1000;
+const OUTRO_TRANSITION_DURATION = 800;
 const INITIAL_Z_TRANSLATION = 400;
 const MOVE_INTO_VIEW_ACCURACY = 50;
 
what are these units? Comments please.

 const MOUSE_CLICK_THRESHOLD = 10;
-const MOUSE_INTRO_DELAY = 10;
+const MOUSE_INTRO_DELAY = 200;
 const ARCBALL_SENSITIVITY = 0.5;

these too.

Otherwise looks really solid. Could you throw this through try as well? R+ with a successful run. Thanks!

Comment 4

[Victor Porof [:vporof][:vp]]

(In reply to Rob Campbell [:rc] (robcee) from comment #3)
> Comment on attachment 594118 [details] [diff] [review]
> v2
> 
> -const INTRO_TRANSITION_DURATION = 50;
> -const OUTRO_TRANSITION_DURATION = 40;
> +const INTRO_TRANSITION_DURATION = 1000;
> +const OUTRO_TRANSITION_DURATION = 800;
>  const INITIAL_Z_TRANSLATION = 400;
>  const MOVE_INTO_VIEW_ACCURACY = 50;
>  
> what are these units? Comments please.

I can't really relate these to a unit of measurement. Just interpolation magic numbers. Definitely not pixels, not centimeters, or kilograms...

> 
>  const MOUSE_CLICK_THRESHOLD = 10;
> -const MOUSE_INTRO_DELAY = 10;
> +const MOUSE_INTRO_DELAY = 200;
>  const ARCBALL_SENSITIVITY = 0.5;
> 
> these too.
> 
> Otherwise looks really solid. Could you throw this through try as well? R+
> with a successful run. Thanks!

Try: https://tbpl.mozilla.org/?tree=Try&rev=97ff4518c7

Comment 5

[Rob Campbell [:rc] (:robcee)]

(In reply to Victor Porof from comment #4)
> (In reply to Rob Campbell [:rc] (robcee) from comment #3)
> > Comment on attachment 594118 [details] [diff] [review]
> > v2
> > 
> > -const INTRO_TRANSITION_DURATION = 50;
> > -const OUTRO_TRANSITION_DURATION = 40;
> > +const INTRO_TRANSITION_DURATION = 1000;
> > +const OUTRO_TRANSITION_DURATION = 800;
> >  const INITIAL_Z_TRANSLATION = 400;
> >  const MOVE_INTO_VIEW_ACCURACY = 50;
> >  
> > what are these units? Comments please.
> 
> I can't really relate these to a unit of measurement. Just interpolation
> magic numbers. Definitely not pixels, not centimeters, or kilograms...

I was thinking fractions of a second, frames or intervals. "Interpolation magic" is kind of unsatisfying.

> >  const MOUSE_CLICK_THRESHOLD = 10;
> > -const MOUSE_INTRO_DELAY = 10;
> > +const MOUSE_INTRO_DELAY = 200;
> >  const ARCBALL_SENSITIVITY = 0.5;
> > 
> > these too.
> > 
> > Otherwise looks really solid. Could you throw this through try as well? R+
> > with a successful run. Thanks!
> 
> Try: https://tbpl.mozilla.org/?tree=Try&rev=97ff4518c7

ah well. Land ho!

Comment 6

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/3b55713894a6

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/3b55713894a6