722816 - Admin status issues

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P1)

Description

[Justin Scott [:fligtar]]

1. Being in the admins group should be the same as superuser/staff in django and give the user access to the model admin.

2. I can't give other users those permissions because when I try to save their user object, the password hash field gives me a validation error: Ensure this value has at most 128 characters (it has 200).

Comment 1

[Justin Scott [:fligtar]]

can this be fixed soonish? I've had to do things for other admins 3 times in the last week because of the disconnect

Comment 2

[Wil Clouser [:clouserw]]

I think this can just be done with a post save hook in the admin interface for editing groups to set the superuser/staff for people in the admin group.

Comment 3

[Rob Hudson [:robhudson]]

For 2) The django admin is validating the password field, which in the "contrib/auth/models.py" is defined as max 128 characters. Somewhere along the way we extended that out to 255 characters at the database level, but the django admin still is using the models.py value to validate it at the Python level.

I think the easiest django way to fix that is to define our own django `UserAdmin` (copy from Django's contrib/auth/admin.py) and our own forms for users where we override the max length on these fields.

Comment 4

[Allen Short [:ashort]]

https://github.com/washort/zamboni/commit/6a07408

Comment 5

[krupa raj[:krupa]]

I still see the issue from comment 0 at https://addons-dev.allizom.org/en-US/admin/models/auth/user/5540398/

Reopening..

Comment 6

[Wil Clouser [:clouserw]]

What's the status of this?

Comment 7

[Christopher Van Wiemeersch [:cvan]]

Is this blocked on anything?

Comment 8

[Allen Short [:ashort]]

https://github.com/mozilla/zamboni/commit/92ac903920425eb55bfcd841315901a910e90c9b

Comment 9

[krupa raj[:krupa]]

I filed bug 740256 for newer accounts created using BrowserID.

But I can make changes to Users now. verified fixed at  https://addons-dev.allizom.org/en-US/admin/models/auth/user/5540398/