Status

addons.mozilla.org Graveyard
Admin/Editor Tools
P1
normal
VERIFIED FIXED
6 years ago
2 years ago

People

(Reporter: fligtar, Assigned: ashort)

Tracking

Details

(Reporter)

Description

6 years ago
1. Being in the admins group should be the same as superuser/staff in django and give the user access to the model admin.

2. I can't give other users those permissions because when I try to save their user object, the password hash field gives me a validation error: Ensure this value has at most 128 characters (it has 200).
(Reporter)

Comment 1

6 years ago
can this be fixed soonish? I've had to do things for other admins 3 times in the last week because of the disconnect
I think this can just be done with a post save hook in the admin interface for editing groups to set the superuser/staff for people in the admin group.
Assignee: nobody → ashort
Target Milestone: --- → 6.4.2
For 2) The django admin is validating the password field, which in the "contrib/auth/models.py" is defined as max 128 characters. Somewhere along the way we extended that out to 255 characters at the database level, but the django admin still is using the models.py value to validate it at the Python level.

I think the easiest django way to fix that is to define our own django `UserAdmin` (copy from Django's contrib/auth/admin.py) and our own forms for users where we override the max length on these fields.
(Assignee)

Comment 4

6 years ago
https://github.com/washort/zamboni/commit/6a07408
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 5

6 years ago
I still see the issue from comment 0 at https://addons-dev.allizom.org/en-US/admin/models/auth/user/5540398/

Reopening..
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 6.4.2 → 6.4.3
Target Milestone: 6.4.3 → 6.4.4
What's the status of this?
Target Milestone: 6.4.4 → 6.4.5
Target Milestone: 6.4.5 → 6.4.7
Priority: P3 → P1
Target Milestone: 6.4.7 → 6.4.8
Is this blocked on anything?
(Assignee)

Comment 8

6 years ago
https://github.com/mozilla/zamboni/commit/92ac903920425eb55bfcd841315901a910e90c9b
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED

Comment 9

6 years ago
I filed bug 740256 for newer accounts created using BrowserID.

But I can make changes to Users now. verified fixed at  https://addons-dev.allizom.org/en-US/admin/models/auth/user/5540398/
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.