Closed Bug 723563 Opened 12 years ago Closed 12 years ago

Use findScripts to retrieve the list of scripts known to the debugger


(DevTools :: Debugger, defect, P2)



(Not tracked)

Firefox 14


(Reporter: past, Assigned: past)




(1 file, 2 obsolete files)

When bug 676281 lands, the debugger server should use Debugger.prototype.getAllScripts to retrieve the list of all scripts known to the debugger. Currently we rely on onNewScript notifications to generate the list, which doesn't work when the client takes a while to attach to the server, thus missing the initial notifications.
See bug 697040 for a manifestation of the problem with the current solution.
We are implementing a workaround in bug 697040, so the first thing to do in this bug is revert that. I'll upload the necessary patch once 697040 lands.
Attached patch Backout patch (obsolete) — Splinter Review
This is the backout patch for the workaround in bug 697040.
Assignee: nobody → past
Priority: P3 → P2
Summary: Use getAllScripts to retrieve the list of scripts known to the debugger → Use findScripts to retrieve the list of scripts known to the debugger
Attached patch WIP (obsolete) — Splinter Review
This is almost there, but I'm having issues with getting the client to send the request. Might be related to bug 731537.
Attachment #599914 - Attachment is obsolete: true
Attached patch Working patchSplinter Review
Fixed the tests by adding an extra event. This may come in handy with some oranges as well. Also contains the typo fix from bug 736000.
Attachment #605843 - Attachment is obsolete: true
Attachment #606271 - Flags: review?(rcampbell)
Comment on attachment 606271 [details] [diff] [review]
Working patch

very nice. I wish I had comments for you.
Attachment #606271 - Flags: review?(rcampbell) → review+
if it fixes orange, I'll be super happy. :)
Whiteboard: [land-in-fx-team]
I sneaked in another one-liner to fix the gcli breakpoint test in the same way as the others:
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Depends on: 739995
Backed out due to new randomorange:
Whiteboard: [fixed-in-fx-team]
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 14
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.