Closed
Bug 723563
Opened 12 years ago
Closed 12 years ago
Use findScripts to retrieve the list of scripts known to the debugger
Categories
(DevTools :: Debugger, defect, P2)
DevTools
Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 14
People
(Reporter: past, Assigned: past)
References
Details
Attachments
(1 file, 2 obsolete files)
25.72 KB,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
When bug 676281 lands, the debugger server should use Debugger.prototype.getAllScripts to retrieve the list of all scripts known to the debugger. Currently we rely on onNewScript notifications to generate the list, which doesn't work when the client takes a while to attach to the server, thus missing the initial notifications.
Assignee | ||
Comment 1•12 years ago
|
||
See bug 697040 for a manifestation of the problem with the current solution.
Assignee | ||
Comment 2•12 years ago
|
||
We are implementing a workaround in bug 697040, so the first thing to do in this bug is revert that. I'll upload the necessary patch once 697040 lands.
Assignee | ||
Comment 3•12 years ago
|
||
This is the backout patch for the workaround in bug 697040.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → past
Status: NEW → ASSIGNED
Priority: P3 → P2
Summary: Use getAllScripts to retrieve the list of scripts known to the debugger → Use findScripts to retrieve the list of scripts known to the debugger
Assignee | ||
Comment 4•12 years ago
|
||
This is almost there, but I'm having issues with getting the client to send the request. Might be related to bug 731537.
Attachment #599914 -
Attachment is obsolete: true
Assignee | ||
Comment 5•12 years ago
|
||
Fixed the tests by adding an extra event. This may come in handy with some oranges as well. Also contains the typo fix from bug 736000.
Attachment #605843 -
Attachment is obsolete: true
Attachment #606271 -
Flags: review?(rcampbell)
Comment 6•12 years ago
|
||
Comment on attachment 606271 [details] [diff] [review] Working patch very nice. I wish I had comments for you.
Attachment #606271 -
Flags: review?(rcampbell) → review+
Comment 7•12 years ago
|
||
if it fixes orange, I'll be super happy. :)
Updated•12 years ago
|
Whiteboard: [land-in-fx-team]
Assignee | ||
Comment 8•12 years ago
|
||
I sneaked in another one-liner to fix the gcli breakpoint test in the same way as the others: https://hg.mozilla.org/integration/fx-team/rev/794ff67c7a9a
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Assignee | ||
Comment 9•12 years ago
|
||
Backed out due to new randomorange: https://hg.mozilla.org/integration/fx-team/rev/4b87cffba4d5
Whiteboard: [fixed-in-fx-team]
Assignee | ||
Comment 10•12 years ago
|
||
Relanded: https://hg.mozilla.org/integration/fx-team/rev/401804642db1
Whiteboard: [fixed-in-fx-team]
Comment 11•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/401804642db1
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 14
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•