725524 - Error during configure after bug 713377: "line 17185: test: -eq: unary operator expected"

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ed Morley [:emorley]]

Win7 x64 (32bit build)
MozillaBuild 1.6
https://hg.mozilla.org/integration/mozilla-inbound/rev/07da69ba7e52

{
c:/mozilla/inbound/configure: line 17185: test: -eq: unary operator expected
}

Equates to:
http://mxr.mozilla.org/mozilla-central/source/configure.in#5484
> if test $MOZ_WEBSMS_BACKEND -eq 1; then

Added by bug 713377.

Build carries on regardless, perhaps another argument (along with the similar bug 725517) for adding |set -o errexit| to configure (albeit it will require a number of other changes, along the lines of bug 698545 comment 1).

Comment 1

[Mike Hommey [:glandium]]

Quoting $MOZ_WEBSMS_BACKEND should fix it.

Comment 2

[Mounir Lamouri (:mounir)]

Attachment: Patch

I will hope glandium is true and that will fix the issue (I don't have a Windows system around to test).

Comment 3

[Ed Morley [:emorley]]

Attachment: Patch v2

> if test "$MOZ_WEBSMS_BACKEND" -eq 1; then

Unfortunately I get |test: : integer expression expected| with patch v1.

Is perhaps |if test -n "$FOO"| a better way of doing it/more consistent with the rest of configure? (and fixes the problem locally)

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 595760 [details] [diff] [review]
Patch v2

Review of attachment 595760 [details] [diff] [review]:
-----------------------------------------------------------------

Agreed

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 595760 [details] [diff] [review]
Patch v2

Except you replaced the variable name.

Comment 6

[Ed Morley [:emorley]]

Attachment: Patch v2, but with less copy-pasting incompetance

Comment 7

[Ed Morley [:emorley]]

https://tbpl.mozilla.org/?tree=Try&rev=138e2820a551

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/065f503a9ea2

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/065f503a9ea2