Closed
Bug 725524
Opened 13 years ago
Closed 13 years ago
Error during configure after bug 713377: "line 17185: test: -eq: unary operator expected"
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla13
People
(Reporter: emorley, Assigned: emorley)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file, 2 obsolete files)
1.02 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Win7 x64 (32bit build)
MozillaBuild 1.6
https://hg.mozilla.org/integration/mozilla-inbound/rev/07da69ba7e52
{
c:/mozilla/inbound/configure: line 17185: test: -eq: unary operator expected
}
Equates to:
http://mxr.mozilla.org/mozilla-central/source/configure.in#5484
> if test $MOZ_WEBSMS_BACKEND -eq 1; then
Added by bug 713377.
Build carries on regardless, perhaps another argument (along with the similar bug 725517) for adding |set -o errexit| to configure (albeit it will require a number of other changes, along the lines of bug 698545 comment 1).
Comment 1•13 years ago
|
||
Quoting $MOZ_WEBSMS_BACKEND should fix it.
Comment 2•13 years ago
|
||
I will hope glandium is true and that will fix the issue (I don't have a Windows system around to test).
Updated•13 years ago
|
Attachment #595752 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 3•13 years ago
|
||
> if test "$MOZ_WEBSMS_BACKEND" -eq 1; then
Unfortunately I get |test: : integer expression expected| with patch v1.
Is perhaps |if test -n "$FOO"| a better way of doing it/more consistent with the rest of configure? (and fixes the problem locally)
Attachment #595752 -
Attachment is obsolete: true
Attachment #595760 -
Flags: review?(mh+mozilla)
Comment 4•13 years ago
|
||
Comment on attachment 595760 [details] [diff] [review]
Patch v2
Review of attachment 595760 [details] [diff] [review]:
-----------------------------------------------------------------
Agreed
Attachment #595760 -
Flags: review?(mh+mozilla) → review+
Comment 5•13 years ago
|
||
Comment on attachment 595760 [details] [diff] [review]
Patch v2
Except you replaced the variable name.
Attachment #595760 -
Flags: review+ → review-
Assignee | ||
Comment 6•13 years ago
|
||
Assignee: mounir → bmo
Attachment #595760 -
Attachment is obsolete: true
Attachment #595763 -
Flags: review?(mh+mozilla)
Updated•13 years ago
|
Attachment #595763 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 7•13 years ago
|
||
Assignee | ||
Comment 8•13 years ago
|
||
Flags: in-testsuite-
Whiteboard: [qa-]
Target Milestone: --- → mozilla13
Assignee | ||
Comment 9•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•