Last Comment Bug 725524 - Error during configure after bug 713377: "line 17185: test: -eq: unary operator expected"
: Error during configure after bug 713377: "line 17185: test: -eq: unary operat...
Status: RESOLVED FIXED
[qa-]
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86 Windows 7
: -- normal (vote)
: mozilla13
Assigned To: Ed Morley [:emorley]
:
:
Mentors:
Depends on:
Blocks: 713377
  Show dependency treegraph
 
Reported: 2012-02-08 16:24 PST by Ed Morley [:emorley]
Modified: 2012-02-10 19:45 PST (History)
2 users (show)
emorley: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (955 bytes, patch)
2012-02-09 08:10 PST, Mounir Lamouri (:mounir)
mh+mozilla: review+
Details | Diff | Splinter Review
Patch v2 (1.02 KB, patch)
2012-02-09 08:29 PST, Ed Morley [:emorley]
mh+mozilla: review-
Details | Diff | Splinter Review
Patch v2, but with less copy-pasting incompetance (1.02 KB, patch)
2012-02-09 08:36 PST, Ed Morley [:emorley]
mh+mozilla: review+
Details | Diff | Splinter Review

Description Ed Morley [:emorley] 2012-02-08 16:24:48 PST
Win7 x64 (32bit build)
MozillaBuild 1.6
https://hg.mozilla.org/integration/mozilla-inbound/rev/07da69ba7e52

{
c:/mozilla/inbound/configure: line 17185: test: -eq: unary operator expected
}

Equates to:
http://mxr.mozilla.org/mozilla-central/source/configure.in#5484
> if test $MOZ_WEBSMS_BACKEND -eq 1; then

Added by bug 713377.

Build carries on regardless, perhaps another argument (along with the similar bug 725517) for adding |set -o errexit| to configure (albeit it will require a number of other changes, along the lines of bug 698545 comment 1).
Comment 1 Mike Hommey [:glandium] 2012-02-08 23:50:21 PST
Quoting $MOZ_WEBSMS_BACKEND should fix it.
Comment 2 Mounir Lamouri (:mounir) 2012-02-09 08:10:51 PST
Created attachment 595752 [details] [diff] [review]
Patch

I will hope glandium is true and that will fix the issue (I don't have a Windows system around to test).
Comment 3 Ed Morley [:emorley] 2012-02-09 08:29:50 PST
Created attachment 595760 [details] [diff] [review]
Patch v2

> if test "$MOZ_WEBSMS_BACKEND" -eq 1; then

Unfortunately I get |test: : integer expression expected| with patch v1.

Is perhaps |if test -n "$FOO"| a better way of doing it/more consistent with the rest of configure? (and fixes the problem locally)
Comment 4 Mike Hommey [:glandium] 2012-02-09 08:31:31 PST
Comment on attachment 595760 [details] [diff] [review]
Patch v2

Review of attachment 595760 [details] [diff] [review]:
-----------------------------------------------------------------

Agreed
Comment 5 Mike Hommey [:glandium] 2012-02-09 08:32:23 PST
Comment on attachment 595760 [details] [diff] [review]
Patch v2

Except you replaced the variable name.
Comment 6 Ed Morley [:emorley] 2012-02-09 08:36:22 PST
Created attachment 595763 [details] [diff] [review]
Patch v2, but with less copy-pasting incompetance
Comment 7 Ed Morley [:emorley] 2012-02-09 14:34:40 PST
https://tbpl.mozilla.org/?tree=Try&rev=138e2820a551
Comment 9 Ed Morley [:emorley] 2012-02-10 19:45:51 PST
https://hg.mozilla.org/mozilla-central/rev/065f503a9ea2

Note You need to log in before you can comment on or make changes to this bug.