Error during configure after bug 713377: "line 17185: test: -eq: unary operator expected"

RESOLVED FIXED in mozilla13

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Trunk
mozilla13
x86
Windows 7
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Win7 x64 (32bit build)
MozillaBuild 1.6
https://hg.mozilla.org/integration/mozilla-inbound/rev/07da69ba7e52

{
c:/mozilla/inbound/configure: line 17185: test: -eq: unary operator expected
}

Equates to:
http://mxr.mozilla.org/mozilla-central/source/configure.in#5484
> if test $MOZ_WEBSMS_BACKEND -eq 1; then

Added by bug 713377.

Build carries on regardless, perhaps another argument (along with the similar bug 725517) for adding |set -o errexit| to configure (albeit it will require a number of other changes, along the lines of bug 698545 comment 1).
Quoting $MOZ_WEBSMS_BACKEND should fix it.
Created attachment 595752 [details] [diff] [review]
Patch

I will hope glandium is true and that will fix the issue (I don't have a Windows system around to test).
Assignee: nobody → mounir
Status: NEW → ASSIGNED
Attachment #595752 - Flags: review?(mh+mozilla)
Attachment #595752 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 3

5 years ago
Created attachment 595760 [details] [diff] [review]
Patch v2

> if test "$MOZ_WEBSMS_BACKEND" -eq 1; then

Unfortunately I get |test: : integer expression expected| with patch v1.

Is perhaps |if test -n "$FOO"| a better way of doing it/more consistent with the rest of configure? (and fixes the problem locally)
Attachment #595752 - Attachment is obsolete: true
Attachment #595760 - Flags: review?(mh+mozilla)
Comment on attachment 595760 [details] [diff] [review]
Patch v2

Review of attachment 595760 [details] [diff] [review]:
-----------------------------------------------------------------

Agreed
Attachment #595760 - Flags: review?(mh+mozilla) → review+
Comment on attachment 595760 [details] [diff] [review]
Patch v2

Except you replaced the variable name.
Attachment #595760 - Flags: review+ → review-
(Assignee)

Comment 6

5 years ago
Created attachment 595763 [details] [diff] [review]
Patch v2, but with less copy-pasting incompetance
Assignee: mounir → bmo
Attachment #595760 - Attachment is obsolete: true
Attachment #595763 - Flags: review?(mh+mozilla)
Attachment #595763 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 7

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=138e2820a551
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/065f503a9ea2
Flags: in-testsuite-
Whiteboard: [qa-]
Target Milestone: --- → mozilla13
(Assignee)

Comment 9

5 years ago
https://hg.mozilla.org/mozilla-central/rev/065f503a9ea2
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.